C++: Fix BMN Rust lints

The updated Rust toolchain introduced additional Clippy lints. This
fixes the lints.

Author: paldepind

cpp/extractor/bmn/src/compiler.rs

@@ -587,13 +587,15 @@ mod tests {
     use super::*;
     use crate::test_utils::create_populate_tmp_dir;
     use all_asserts::assert_true;
+    use std::slice;
 
     #[test]
     fn test_indexing_compiler_default_folders() {
         let tmp_dir = create_populate_tmp_dir();
         let dirname = tmp_dir.path().to_path_buf();
 
-        let include_finder = CompilerDefaultIncludes::new(&[dirname.clone()], &[dirname]);
+        let include_finder =
+            CompilerDefaultIncludes::new(slice::from_ref(&dirname), slice::from_ref(&dirname));
         let default_c_include_dir_content = &include_finder.default_c_include_dir_content;
         let default_cpp_include_dir_content = &include_finder.default_cpp_include_dir_content;
 

cpp/extractor/bmn/src/include_finder.rs

@@ -638,6 +638,7 @@ mod tests {
 
     mod find_includes {
         use crate::project_definitions::IncludeKind;
+        use std::slice;
 
         use super::*;
 
@@ -836,7 +837,7 @@ mod tests {
                 &project_files,
                 &system_files,
                 &compiler_defaults,
-                &[include_directive.clone()],
+                slice::from_ref(&include_directive),
             );
 
             let empty: Vec<PathBuf> = vec![];

cpp/extractor/bmn/src/project_definitions.rs

@@ -116,7 +116,7 @@ impl Hash for SourceFile {
 
 impl PartialOrd<Self> for SourceFile {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        Some(self.path.cmp(&other.path))
+        Some(self.cmp(other))
     }
 }
 

cpp/extractor/bmn/src/test_utils.rs

@@ -2,7 +2,7 @@ use all_asserts::assert_true;
 use std::fs::File;
 use std::path::PathBuf;
 use std::{env, fs};
-use tempfile::{tempdir, TempDir};
+use tempfile::{TempDir, tempdir};
 
 /// This function tries to get the root test resource path.
 /// If `allow_symlinks` is `false` will avoid the bazel off-tree test directory as this contains
@@ -124,9 +124,7 @@ mod tests {
         assert_true!(file_maybe_symlinked.exists());
         assert_true!(file_maybe_symlinked.ends_with("tests/resources/dir1/file1.c"));
 
-        let is_bazel = env::var("BAZEL_TEST")
-            .map(|bazel| bazel == "1")
-            .unwrap_or(false);
+        let is_bazel = env::var("BAZEL_TEST").is_ok_and(|bazel| bazel == "1");
         if is_bazel {
             assert_true!(file_maybe_symlinked.is_symlink());
         } else {