From dc135618223e2ad8a7258c207ac56320a450c990 Mon Sep 17 00:00:00 2001
From: Neel Shah <neel.shah@sentry.io>
Date: Fri, 7 Aug 2026 13:35:19 +0200
Subject: [PATCH] ci: Use booleans for apt instead of string

---
 .github/workflows/gem_test.yml | 23 +++++++++++++++++------
 .github/workflows/tests.yml    |  8 +++++---
 2 files changed, 22 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/gem_test.yml b/.github/workflows/gem_test.yml
index 904aae65b..11a384fa0 100644
--- a/.github/workflows/gem_test.yml
+++ b/.github/workflows/gem_test.yml
@@ -13,10 +13,14 @@ on:
         description: Gem directory to test (e.g. sentry-ruby).
         required: true
         type: string
-      apt:
-        description: Space-separated apt packages to install before testing.
-        type: string
-        default: ""
+      sqlite:
+        description: Install SQLite development headers.
+        type: boolean
+        default: false
+      imagemagick:
+        description: Install ImageMagick.
+        type: boolean
+        default: false
     secrets:
       CODECOV_TOKEN:
         required: false
@@ -57,10 +61,17 @@ jobs:
       - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
 
       - name: Install apt packages
-        if: inputs.apt != ''
+        if: inputs.sqlite || inputs.imagemagick
         run: |
           sudo apt-get update
-          sudo apt-get install --no-install-recommends ${{ inputs.apt }}
+          packages=()
+          if [[ "${{ inputs.sqlite }}" == "true" ]]; then
+            packages+=(libsqlite3-dev)
+          fi
+          if [[ "${{ inputs.imagemagick }}" == "true" ]]; then
+            packages+=(imagemagick)
+          fi
+          sudo apt-get install --no-install-recommends "${packages[@]}"
 
       - name: Set up Ruby
         uses: ./.github/actions/setup-mise
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 4609fc5c5..79957ea43 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -29,17 +29,19 @@ jobs:
         include:
           - gem: sentry-ruby
           - gem: sentry-rails
-            apt: libsqlite3-dev imagemagick
+            sqlite: true
+            imagemagick: true
           - gem: sentry-sidekiq
           - gem: sentry-delayed_job
-            apt: libsqlite3-dev
+            sqlite: true
           - gem: sentry-resque
           - gem: sentry-opentelemetry
           - gem: sentry-yabeda
     uses: ./.github/workflows/gem_test.yml
     with:
       gem: ${{ matrix.gem }}
-      apt: ${{ matrix.apt || '' }}
+      sqlite: ${{ matrix.sqlite || false }}
+      imagemagick: ${{ matrix.imagemagick || false }}
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}