Skip to content

Keep the native session's error count correct when a JS error is dropped by sampling #6660

Description

@antonis

Summary

When an error event is dropped by sampling on the JS side (sampleRate), the envelope is never forwarded to native, so the native session never records that an error occurred — a session that should be errored (or unhandled) can finalize as healthy/exited. Adopt updateSessionForDroppedEventNonTerminating to update the native session's error count in that path, without sending an envelope.

This is the sampling-path counterpart to #6659 (which handles unhandled errors that do produce an envelope). It is the RN equivalent of Flutter #4008.

Targeted at the next RN SDK major and stacked after #6659 — see Sequencing below.

The drift

RN sessions are owned by the native SDK; JS forwards envelopes. The only native session signal is via captureEnvelope (wrapper.ts:196-235RNSentryModuleImpl.java:500-511). So when JS drops an error by sampleRate before it reaches captureEnvelope, native never learns an error occurred, and the session's errors count / status drifts. Same motivation as Flutter #4008: without a separate update, a gracefully ending session is reported as exited instead of errored/unhandled.

Scope — sampling only, NOT beforeSend

Call this only for events dropped by sampling. The native API contract is explicit (sentry-cocoa SentryInternalEnvelopeApi):

"Do not call this for events dropped by beforeSend or ignored exception types, and do not call it in addition to captureNonTerminating for the same event."

So this path must fire for sampleRate drops only — not beforeSend returning null, not ignored/denied exception types. Flutter #4008 does the same: it "receives only final events accepted by processors and beforeSend." (This corrects the original issue text, which mentioned beforeSend.)

The API takes an unhandled: boolean — set it from the dropped event's mechanism.handled === false.

Native API (available now)

  • Android — sentry-java 8.55.0 (#5990), merged via chore(deps): update Android SDK to v8.55.0 #6658: InternalSentrySdk.updateSessionForDroppedEventNonTerminating.
  • iOS — sentry-cocoa 9.27.0 (pinned in RNSentry.podspec): SentrySDK.internal.envelope.updateSessionForDroppedEventNonTerminating(unhandled:).

Design sketch

Sequencing

Release classification

Not an API/ABI break (additive bridge method, no public JS API change). It is a Release Health behavior shift — errored/unhandled session rates become more accurate under error sampling — so it belongs in the next major with a CHANGELOG note.

Follow-up from the 8.55.0 bump (#6658). Pairs with #6659.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions