From b43cfe51d6b08b161db038cf85c3c97ff1871d1c Mon Sep 17 00:00:00 2001 From: krrrr38 Date: Fri, 5 Jun 2026 11:00:05 +0900 Subject: [PATCH 1/2] add syntax checks and tests to language workflows Signed-off-by: krrrr38 --- .github/workflows/test-go.yml | 2 ++ .github/workflows/test-java17.yml | 2 +- .github/workflows/test-java8.yml | 2 +- .github/workflows/test-php.yml | 2 ++ .github/workflows/test-python.yml | 4 +++- .github/workflows/test-ruby.yml | 2 ++ .github/workflows/test-scala.yml | 1 + .github/workflows/test-typescript.yml | 1 + .gitignore | 3 +-- README.md | 6 +----- 10 files changed, 15 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test-go.yml b/.github/workflows/test-go.yml index a227cb5..0a8f867 100644 --- a/.github/workflows/test-go.yml +++ b/.github/workflows/test-go.yml @@ -35,3 +35,5 @@ jobs: - run: go mod download - run: go build ./... - run: go fmt ./... + - run: go vet ./... + - run: go test ./test/... -run TestOptimalPortfolioScenario diff --git a/.github/workflows/test-java17.yml b/.github/workflows/test-java17.yml index 4988642..b5b04c4 100644 --- a/.github/workflows/test-java17.yml +++ b/.github/workflows/test-java17.yml @@ -33,4 +33,4 @@ jobs: distribution: temurin java-version: '17' cache: maven - - run: ./mvnw compile -DskipTests + - run: ./mvnw test -Dtest=OptimalPortfolioScenarioTest diff --git a/.github/workflows/test-java8.yml b/.github/workflows/test-java8.yml index e69b4de..b219e4e 100644 --- a/.github/workflows/test-java8.yml +++ b/.github/workflows/test-java8.yml @@ -33,4 +33,4 @@ jobs: distribution: temurin java-version: '8' cache: maven - - run: ./mvnw compile -DskipTests + - run: ./mvnw test -Dtest=OptimalPortfolioScenarioTest diff --git a/.github/workflows/test-php.yml b/.github/workflows/test-php.yml index c14aa41..1595187 100644 --- a/.github/workflows/test-php.yml +++ b/.github/workflows/test-php.yml @@ -32,3 +32,5 @@ jobs: with: php-version: '8.5' - run: composer install --no-interaction --prefer-dist + - run: find src -name '*.php' -exec php -l {} + + - run: ./vendor/bin/phpunit tests/OptimalPortfolioScenarioTest.php diff --git a/.github/workflows/test-python.yml b/.github/workflows/test-python.yml index 26d115d..12ec909 100644 --- a/.github/workflows/test-python.yml +++ b/.github/workflows/test-python.yml @@ -32,4 +32,6 @@ jobs: with: python-version-file: 'python/pyproject.toml' cache: pip - - run: pip install . + - run: pip install ".[dev]" + - run: find src -name '*.py' -exec python -m py_compile {} + + - run: python -m pytest tests/test_optimal_portfolio_scenario.py diff --git a/.github/workflows/test-ruby.yml b/.github/workflows/test-ruby.yml index 81724d3..674fb93 100644 --- a/.github/workflows/test-ruby.yml +++ b/.github/workflows/test-ruby.yml @@ -33,3 +33,5 @@ jobs: ruby-version: '3.3' bundler-cache: true working-directory: ruby + - run: find lib -name '*.rb' -exec ruby -c {} + + - run: bundle exec rspec spec/optimal_portfolio_scenario_spec.rb diff --git a/.github/workflows/test-scala.yml b/.github/workflows/test-scala.yml index e9e56c8..a50d885 100644 --- a/.github/workflows/test-scala.yml +++ b/.github/workflows/test-scala.yml @@ -36,3 +36,4 @@ jobs: cache: sbt - uses: sbt/setup-sbt@af116cce31c00823d3903ce687f9cda3a4f19f1b # v1 - run: sbt compile + - run: sbt "testOnly folio.codinginterview.OptimalPortfolioScenario" diff --git a/.github/workflows/test-typescript.yml b/.github/workflows/test-typescript.yml index e6ccbec..e4d8ff8 100644 --- a/.github/workflows/test-typescript.yml +++ b/.github/workflows/test-typescript.yml @@ -36,3 +36,4 @@ jobs: cache-dependency-path: typescript/package-lock.json - run: npm ci - run: npm run build + - run: npx vitest run tests/optimalPortfolioScenario.test.ts diff --git a/.gitignore b/.gitignore index 0f4f038..5326591 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,3 @@ .claude/settings.local.json -.serena/ -.claude/settings.local.json .claude/worktrees/ +.serena/ diff --git a/README.md b/README.md index 50db604..e68dc6d 100644 --- a/README.md +++ b/README.md @@ -2,11 +2,7 @@ ## Release -Kick the [release action](https://github.com/folio-sec/terraform-provider-zoom/actions/workflows/release.yml) manually, then release. - -## Contribution - -See also [CONTRIBUTING.md](CONTRIBUTING.md). +Kick the [release action](https://github.com/folio-sec/wrap-api-example/actions/workflows/release.yml) manually, then release. ### DCO Sign-Off Methods From e754ce2e260a6a4c4abc317021cf27bad9d1bbd6 Mon Sep 17 00:00:00 2001 From: krrrr38 Date: Fri, 5 Jun 2026 11:03:53 +0900 Subject: [PATCH 2/2] suppress progress logs on java Signed-off-by: krrrr38 --- .github/workflows/test-java17.yml | 2 +- .github/workflows/test-java8.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-java17.yml b/.github/workflows/test-java17.yml index b5b04c4..e6b1be0 100644 --- a/.github/workflows/test-java17.yml +++ b/.github/workflows/test-java17.yml @@ -33,4 +33,4 @@ jobs: distribution: temurin java-version: '17' cache: maven - - run: ./mvnw test -Dtest=OptimalPortfolioScenarioTest + - run: ./mvnw test -q -Dtest=OptimalPortfolioScenarioTest diff --git a/.github/workflows/test-java8.yml b/.github/workflows/test-java8.yml index b219e4e..6ae6e82 100644 --- a/.github/workflows/test-java8.yml +++ b/.github/workflows/test-java8.yml @@ -33,4 +33,4 @@ jobs: distribution: temurin java-version: '8' cache: maven - - run: ./mvnw test -Dtest=OptimalPortfolioScenarioTest + - run: ./mvnw test -q -Dtest=OptimalPortfolioScenarioTest