From 94d8a6aa54cf196ce3a71675d549100885a3f61f Mon Sep 17 00:00:00 2001 From: Rishabh Pandey <32699563+allexistence@users.noreply.github.com> Date: Fri, 2 Oct 2026 15:16:58 +0800 Subject: [PATCH] Fix typos and references in upgrade guide Corrected references to 'metrictemplate' and 'Flagger user' for clarity. Signed-off-by: Rishabh Pandey <32699563+allexistence@users.noreply.github.com> --- docs/gitbook/dev/upgrade-guide.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/gitbook/dev/upgrade-guide.md b/docs/gitbook/dev/upgrade-guide.md index 641f0258e..15fbc4c06 100644 --- a/docs/gitbook/dev/upgrade-guide.md +++ b/docs/gitbook/dev/upgrade-guide.md @@ -10,12 +10,12 @@ Canary CRD changes in `canaries.flagger.app/v1beta1`: * the `spec.analysis.interval` and `spec.analysis.threshold` fields are required * the `status.lastAppliedSpec` and `status.lastPromotedSpec` hashing algorithm changed to `hash/fnv` * the `spec.analysis.alerts` array can reference `alertproviders.flagger.app/v1beta1` resources -* the `spec.analysis.metrics[].templateRef` can reference a `metrictemplate.flagger.app/v1beta1` resource +* the `spec.analysis.metrics[].templateRef` can reference a `metrictemplates.flagger.app/v1beta1` resource * the `metric.threshold` field has been deprecated and replaced with `metric.thresholdRange` * the `metric.query` field has been deprecated and replaced with `metric.templateRef` * the `spec.ingressRef.apiVersion` accepts `networking.k8s.io/v1beta1` * the `spec.targetRef` can reference `DaemonSet` kind -* the `spec.service.meshName` field has been deprecated and no longer used for `provider: appmesh:v1beta2` +* the `spec.service.meshName` field has been deprecated and is no longer used for `provider: appmesh:v1beta2` Upgrade procedure: @@ -46,9 +46,9 @@ metrics: ## Istio telemetry v2 -Istio 1.5 comes with a breaking change for Flagger uses. In Istio telemetry v2 the metric `istio_request_duration_seconds_bucket` has been removed and replaced with `istio_request_duration_milliseconds_bucket` and this breaks the `request-duration` metric check. +Istio 1.5 comes with a breaking change for Flagger user. In Istio telemetry v2 the metric `istio_request_duration_seconds_bucket` has been removed and replaced with `istio_request_duration_milliseconds_bucket` and this breaks the `request-duration` metric check. -If are using **Istio 1.4**, you can create a metric template using the old duration metric like this: +If you are using **Istio 1.4**, you can create a metric template using the old duration metric like this: ```yaml apiVersion: flagger.app/v1beta1