From e14ceeeded0d4db7e052faf47941c4cc004e0ffd Mon Sep 17 00:00:00 2001 From: John McDole Date: Thu, 10 Sep 2026 16:34:32 -0700 Subject: [PATCH] fix(actions): remove paths for merge queue / required checks 1. With required checks, you could get an action that deadlocks because it doesn't trip the "paths" check. 2. fix(actions): use lowercase davidanson for action allowlist compatibility --- .github/workflows/rfc-lint.yml | 7 +++---- .github/workflows/test.yml | 9 +-------- .github/workflows/validate-rfc-number.yml | 2 -- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/.github/workflows/rfc-lint.yml b/.github/workflows/rfc-lint.yml index d0b4180..e4faf37 100644 --- a/.github/workflows/rfc-lint.yml +++ b/.github/workflows/rfc-lint.yml @@ -4,8 +4,6 @@ on: pull_request: branches: [main] types: [opened, synchronize, reopened, labeled, unlabeled] - paths: - - 'rfc/**' merge_group: types: [checks_requested] push: @@ -15,6 +13,7 @@ on: jobs: lint-rfcs: + name: lint-rfcs runs-on: ubuntu-latest permissions: contents: read @@ -81,13 +80,13 @@ jobs: - name: Markdown Lint (PR Mode) if: github.event_name == 'pull_request' && steps.changed-rfcs.outputs.has_changes == 'true' - uses: DavidAnson/markdownlint-cli2-action@05f32210e84442804257b2a6f20b273450ec8265 # v19 + uses: davidanson/markdownlint-cli2-action@05f32210e84442804257b2a6f20b273450ec8265 # v19 with: globs: ${{ steps.changed-rfcs.outputs.files }} - name: Markdown Lint (Full Repository) if: github.event_name != 'pull_request' - uses: DavidAnson/markdownlint-cli2-action@05f32210e84442804257b2a6f20b273450ec8265 # v19 + uses: davidanson/markdownlint-cli2-action@05f32210e84442804257b2a6f20b273450ec8265 # v19 with: globs: 'rfc/**/*.md' diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 305a467..2195988 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -2,14 +2,7 @@ name: Dart CI on: pull_request: - paths: - - 'lib/**' - - 'bin/**' - - 'test/**' - - 'pubspec.yaml' - - 'pubspec.lock' - - 'analysis_options.yaml' - - '.github/workflows/test.yml' + branches: [main] merge_group: types: [checks_requested] push: diff --git a/.github/workflows/validate-rfc-number.yml b/.github/workflows/validate-rfc-number.yml index 9c93a72..b372970 100644 --- a/.github/workflows/validate-rfc-number.yml +++ b/.github/workflows/validate-rfc-number.yml @@ -4,8 +4,6 @@ on: pull_request: branches: [main] types: [opened, synchronize, reopened] - paths: - - 'rfc/**' merge_group: types: [checks_requested] push: