diff --git a/app_dart/lib/src/foundation/github_checks_util.dart b/app_dart/lib/src/foundation/github_checks_util.dart index f5026ad9e..e1085482e 100644 --- a/app_dart/lib/src/foundation/github_checks_util.dart +++ b/app_dart/lib/src/foundation/github_checks_util.dart @@ -129,6 +129,7 @@ class GithubChecksUtil { String name, { github.CheckRunOutput? output, github.CheckRunConclusion? conclusion, + github.CheckRunStatus status = github.CheckRunStatus.queued, String? detailsUrl, }) async { const r = RetryOptions(maxAttempts: 3, delayFactor: Duration(seconds: 2)); @@ -141,6 +142,7 @@ class GithubChecksUtil { name, output: output, conclusion: conclusion, + status: status, detailsUrl: detailsUrl, ); }, @@ -161,6 +163,7 @@ class GithubChecksUtil { String name, { github.CheckRunOutput? output, github.CheckRunConclusion? conclusion, + github.CheckRunStatus status = github.CheckRunStatus.queued, String? detailsUrl, }) async { final gitHubClient = await config.createGitHubClient(slug: slug); @@ -170,6 +173,7 @@ class GithubChecksUtil { headSha: sha, output: output, conclusion: conclusion, + status: status, detailsUrl: detailsUrl, ); } diff --git a/app_dart/lib/src/service/luci_build_service.dart b/app_dart/lib/src/service/luci_build_service.dart index 4bad36f10..af9202284 100644 --- a/app_dart/lib/src/service/luci_build_service.dart +++ b/app_dart/lib/src/service/luci_build_service.dart @@ -470,6 +470,7 @@ class LuciBuildService { title: Config.kPresubmitCheckName, summary: Scheduler.kPresubmitCheckDescription, ), + status: CheckRunStatus.inProgress, detailsUrl: checkRun.detailsUrl, ); } diff --git a/app_dart/lib/src/service/scheduler.dart b/app_dart/lib/src/service/scheduler.dart index 6f7c5ac46..262425a29 100644 --- a/app_dart/lib/src/service/scheduler.dart +++ b/app_dart/lib/src/service/scheduler.dart @@ -136,7 +136,7 @@ class Scheduler { /// This description appears next to the Github check run in the pull request /// and merge queue UI. static const String kPresubmitCheckDescription = - 'The presubmit check is a GitHub check that prevents a PR from being ' + 'The Presubmit check is a GitHub check that prevents a PR from being ' 'merged or enqueued before it is ready. It becomes green automatically ' 'when all tests pass. It will fail if at least one job is failed and ' 'reset to in-progress when all the failed jobs are retried. If it fails, ' @@ -922,6 +922,7 @@ $s title: Config.kPresubmitCheckName, summary: kPresubmitCheckDescription, ), + status: CheckRunStatus.inProgress, detailsUrl: detailsUrl, ); } diff --git a/app_dart/test/service/luci_build_service/schedule_try_builds_test.dart b/app_dart/test/service/luci_build_service/schedule_try_builds_test.dart index 7e829fd61..266af4350 100644 --- a/app_dart/test/service/luci_build_service/schedule_try_builds_test.dart +++ b/app_dart/test/service/luci_build_service/schedule_try_builds_test.dart @@ -691,6 +691,7 @@ void main() { any, output: anyNamed('output'), conclusion: anyNamed('conclusion'), + status: anyNamed('status'), detailsUrl: anyNamed('detailsUrl'), ), ).thenAnswer( @@ -720,6 +721,7 @@ void main() { title: Config.kPresubmitCheckName, summary: Scheduler.kPresubmitCheckDescription, ), + status: CheckRunStatus.inProgress, detailsUrl: checkRunGuard.detailsUrl, ), ).called(1); @@ -797,6 +799,7 @@ void main() { Config.kPresubmitCheckName, output: anyNamed('output'), conclusion: anyNamed('conclusion'), + status: anyNamed('status'), detailsUrl: anyNamed('detailsUrl'), ), ); diff --git a/app_dart/test/service/scheduler_test.dart b/app_dart/test/service/scheduler_test.dart index ac510e1e7..1af35c7a1 100644 --- a/app_dart/test/service/scheduler_test.dart +++ b/app_dart/test/service/scheduler_test.dart @@ -2040,6 +2040,7 @@ targets: any, output: anyNamed('output'), conclusion: anyNamed('conclusion'), + status: anyNamed('status'), detailsUrl: anyNamed('detailsUrl'), ), ).thenAnswer((Invocation invocation) async { @@ -2066,6 +2067,7 @@ targets: Config.kPresubmitCheckName, output: anyNamed('output'), conclusion: anyNamed('conclusion'), + status: CheckRunStatus.inProgress, detailsUrl: anyNamed('detailsUrl'), ), ); diff --git a/packages/cocoon_integration_test/lib/src/utilities/mocks.mocks.dart b/packages/cocoon_integration_test/lib/src/utilities/mocks.mocks.dart index ab1200d06..c63f597be 100644 --- a/packages/cocoon_integration_test/lib/src/utilities/mocks.mocks.dart +++ b/packages/cocoon_integration_test/lib/src/utilities/mocks.mocks.dart @@ -2094,6 +2094,7 @@ class MockGithubChecksUtil extends _i1.Mock implements _i10.GithubChecksUtil { String? name, { _i7.CheckRunOutput? output, _i7.CheckRunConclusion? conclusion, + _i7.CheckRunStatus? status = _i7.CheckRunStatus.queued, String? detailsUrl, }) => (super.noSuchMethod( @@ -2103,6 +2104,7 @@ class MockGithubChecksUtil extends _i1.Mock implements _i10.GithubChecksUtil { { #output: output, #conclusion: conclusion, + #status: status, #detailsUrl: detailsUrl, }, ), @@ -2115,6 +2117,7 @@ class MockGithubChecksUtil extends _i1.Mock implements _i10.GithubChecksUtil { { #output: output, #conclusion: conclusion, + #status: status, #detailsUrl: detailsUrl, }, ),