fix(s3): normalize basePath and add README#1679
Open
fclairamb wants to merge 1 commit into
Open
Conversation
Strip leading/trailing slashes from basePath before passing it to afero.NewBasePathFs: S3 object keys must not start with "/" and a trailing slash produces double slashes in key names. Also adds a README for the S3 backend documenting all supported params. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1636 which added
basePathsupport for the S3 backend.afero.NewBasePathFs. S3 object keys must not start with/— a value like/uploadswould produce keys like/uploads/file.txt, which differs fromuploads/file.txtand breaks most S3 tooling.bucket,region,access_key_id,secret_access_key,endpoint,disable_ssl,path_style,basePath) with example configurations for AWS, MinIO, and isolated user directories.Test plan
basePath = "uploads"andbasePath = "/uploads"produce identical S3 key prefixesbasePath = "users/alice/"(trailing slash) works correctly🤖 Generated with Claude Code