From 9d73a35ef09c60a0d98a0ee10b7cd98792ba676d Mon Sep 17 00:00:00 2001 From: Kevin Oberlies Date: Mon, 6 Jul 2026 09:19:39 -0700 Subject: [PATCH 1/2] refactor(ansible): fix deprecation warnings for top-level facts; ignore packer_compiled in lua linter Signed-off-by: Kevin Oberlies --- dotfiles.yml | 2 +- roles/firefox/tasks/main.yml | 2 +- roles/fzf/tasks/main.yml | 2 +- roles/git/tasks/main.yml | 2 +- roles/haskell/tasks/main.yml | 2 +- roles/nvim/files/.luarc.json | 3 +++ roles/nvim/files/selene.toml | 2 +- roles/nvim/tasks/main.yml | 2 +- roles/packages/tasks/debian.yml | 6 +++--- roles/packages/tasks/main.yml | 8 ++++---- roles/penrose/tasks/main.yml | 2 +- roles/programming/tasks/main.yml | 4 ++-- roles/zsh/tasks/main.yml | 4 ++-- 13 files changed, 22 insertions(+), 19 deletions(-) diff --git a/dotfiles.yml b/dotfiles.yml index 8ee5e6b..aa66638 100644 --- a/dotfiles.yml +++ b/dotfiles.yml @@ -6,7 +6,7 @@ hosts: local tasks: - debug: - var: ansible_os_family + var: ansible_facts.os_family verbosity: 1 tags: - "git" diff --git a/roles/firefox/tasks/main.yml b/roles/firefox/tasks/main.yml index 7145543..3242af3 100644 --- a/roles/firefox/tasks/main.yml +++ b/roles/firefox/tasks/main.yml @@ -18,7 +18,7 @@ profiles_dir: >- {{ (found_profiles_ini | dirname ~ '/Profiles') - if (ansible_os_family == 'Darwin') + if (ansible_facts.os_family == 'Darwin') else (found_profiles_ini | dirname) }} when: found_profiles_ini != "" diff --git a/roles/fzf/tasks/main.yml b/roles/fzf/tasks/main.yml index 289ab53..40635ee 100644 --- a/roles/fzf/tasks/main.yml +++ b/roles/fzf/tasks/main.yml @@ -1,5 +1,5 @@ - include_tasks: debian.yml - when: ansible_os_family == "Debian" + when: ansible_facts.os_family == "Debian" - name: Update fzf git: diff --git a/roles/git/tasks/main.yml b/roles/git/tasks/main.yml index 19ac073..350e157 100644 --- a/roles/git/tasks/main.yml +++ b/roles/git/tasks/main.yml @@ -1,5 +1,5 @@ - include_tasks: debian.yml - when: ansible_os_family == "Debian" + when: ansible_facts.os_family == "Debian" - name: Check if gitconfig exists stat: path="{{dotfiles_user_home}}/.gitconfig" diff --git a/roles/haskell/tasks/main.yml b/roles/haskell/tasks/main.yml index b8f277c..d75f527 100644 --- a/roles/haskell/tasks/main.yml +++ b/roles/haskell/tasks/main.yml @@ -1,5 +1,5 @@ - include_tasks: debian.yml - when: ansible_os_family == "Debian" + when: ansible_facts.os_family == "Debian" - name: create stack directory file: diff --git a/roles/nvim/files/.luarc.json b/roles/nvim/files/.luarc.json index fdbd393..6fa1c12 100644 --- a/roles/nvim/files/.luarc.json +++ b/roles/nvim/files/.luarc.json @@ -7,5 +7,8 @@ "tests/types" ], "workspace.checkThirdParty": "Disable", + "workspace.ignoreDir": [ + "plugin/packer_compiled.lua" + ], "diagnostics.disable": ["different-requires"] } diff --git a/roles/nvim/files/selene.toml b/roles/nvim/files/selene.toml index 7beb4b2..bb45d7d 100644 --- a/roles/nvim/files/selene.toml +++ b/roles/nvim/files/selene.toml @@ -1,7 +1,7 @@ std = "neovim" # lazy.nvim's generated lockfile is not hand-written Lua. -exclude = ["lazy-lock.json"] +exclude = ["lazy-lock.json", "plugin/packer_compiled.lua"] [lints] # Neovim/plugin APIs are loosely typed; mixed-table literals (list + map) are diff --git a/roles/nvim/tasks/main.yml b/roles/nvim/tasks/main.yml index 390d02b..78f5604 100644 --- a/roles/nvim/tasks/main.yml +++ b/roles/nvim/tasks/main.yml @@ -1,5 +1,5 @@ - include_tasks: debian.yml - when: ansible_os_family == "Debian" + when: ansible_facts.os_family == "Debian" - name: Install bob-nvim with cargo-binstall command: "{{ dotfiles_user_home }}/.cargo/bin/cargo-binstall -y bob-nvim" diff --git a/roles/packages/tasks/debian.yml b/roles/packages/tasks/debian.yml index 6474932..69a9c06 100644 --- a/roles/packages/tasks/debian.yml +++ b/roles/packages/tasks/debian.yml @@ -4,15 +4,15 @@ dest: "/etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list" become: true become_method: sudo - when: ansible_distribution_version == "20.04" + when: ansible_facts.distribution_version == "20.04" - name: Install podman apt-key apt_key: - url: "https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/xUbuntu_{{ ansible_distribution_version }}/Release.key" + url: "https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/xUbuntu_{{ ansible_facts.distribution_version }}/Release.key" state: present become: true become_method: sudo - when: ansible_distribution_version == "20.04" + when: ansible_facts.distribution_version == "20.04" - name: Download 1Password GPG key get_url: diff --git a/roles/packages/tasks/main.yml b/roles/packages/tasks/main.yml index 8c0e81b..e71198d 100644 --- a/roles/packages/tasks/main.yml +++ b/roles/packages/tasks/main.yml @@ -1,7 +1,7 @@ - include_tasks: debian.yml - when: ansible_os_family == "Debian" + when: ansible_facts.os_family == "Debian" - include_tasks: arch.yml - when: ansible_os_family == "Archlinux" + when: ansible_facts.os_family == "Archlinux" - name: Install global npm packages to user local bin block: @@ -9,7 +9,7 @@ community.general.npm: name: "bash-language-server" global: true - when: ansible_os_family != "Archlinux" + when: ansible_facts.os_family != "Archlinux" - name: install prettier community.general.npm: @@ -21,7 +21,7 @@ community.general.npm: name: "@mermaid-js/mermaid-cli" global: true - when: ansible_os_family != "Archlinux" + when: ansible_facts.os_family != "Archlinux" environment: NPM_CONFIG_PREFIX: "{{ dotfiles_user_home }}/.local" when: not ansible_check_mode diff --git a/roles/penrose/tasks/main.yml b/roles/penrose/tasks/main.yml index 80d9381..a753215 100644 --- a/roles/penrose/tasks/main.yml +++ b/roles/penrose/tasks/main.yml @@ -1,5 +1,5 @@ - include_tasks: debian.yml - when: ansible_os_family == "Debian" + when: ansible_facts.os_family == "Debian" - name: Fetch penrose (favilrose) git repo git: diff --git a/roles/programming/tasks/main.yml b/roles/programming/tasks/main.yml index 448fbf3..0d243e1 100644 --- a/roles/programming/tasks/main.yml +++ b/roles/programming/tasks/main.yml @@ -1,7 +1,7 @@ - include_tasks: debian.yml - when: ansible_os_family == "Debian" + when: ansible_facts.os_family == "Debian" - include_tasks: arch.yml - when: ansible_os_family == "Archlinux" + when: ansible_facts.os_family == "Archlinux" - name: download rustup get_url: diff --git a/roles/zsh/tasks/main.yml b/roles/zsh/tasks/main.yml index e7e8f35..a3c9550 100644 --- a/roles/zsh/tasks/main.yml +++ b/roles/zsh/tasks/main.yml @@ -1,7 +1,7 @@ - include_tasks: debian.yml - when: ansible_os_family == "Debian" + when: ansible_facts.os_family == "Debian" - include_tasks: arch.yml - when: ansible_os_family == "Archlinux" + when: ansible_facts.os_family == "Archlinux" - name: download oh-my-zsh installer get_url: From e75eef9f8b9ee742989c6cc2d132ad44bec151ef Mon Sep 17 00:00:00 2001 From: Kevin Oberlies Date: Mon, 6 Jul 2026 09:34:38 -0700 Subject: [PATCH 2/2] style(nvim): collapse ignoreDir in .luarc.json to single line Signed-off-by: Kevin Oberlies --- roles/nvim/files/.luarc.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/roles/nvim/files/.luarc.json b/roles/nvim/files/.luarc.json index 6fa1c12..78906b9 100644 --- a/roles/nvim/files/.luarc.json +++ b/roles/nvim/files/.luarc.json @@ -7,8 +7,6 @@ "tests/types" ], "workspace.checkThirdParty": "Disable", - "workspace.ignoreDir": [ - "plugin/packer_compiled.lua" - ], + "workspace.ignoreDir": ["plugin/packer_compiled.lua"], "diagnostics.disable": ["different-requires"] }