Skip to content

ghstack submit --update-fields created a new pull request if the ghstack info is damaged or missing #252

Description

@rec

This might not be expected behavior. Two other possibilities are that ghstack submit --update-fields fails if the ghstack info in the commit message is damaged or missing, or to create another flag --update-only/-U, with this behavior.

I'd be willing to submit a pull request for either one of these behaviors if there were interest.

This happened when I restored my ghstack info from a branch as:

    ghstack-source-id: de78c83d0763391c27c41501f614fafd49c9395c
    Pull Request resolved: #128416

instead of

    ghstack-source-id: de78c83d0763391c27c41501f614fafd49c9395c
    Pull Request resolved: https://github.com/pytorch/pytorch/pull/128416

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions