From 8045b93142385ce44d83bd3e9697f6601e65f7b6 Mon Sep 17 00:00:00 2001 From: Eric Litman Date: Fri, 6 Nov 2026 09:34:46 -0500 Subject: [PATCH 1/3] fix(verify): let the configure case accept other providers' writer lines Setup keeps every provider's writer setting line, and the configure case's preparation removes only Codex's. The case now compares only Codex's line, so an operator sheet with another provider's line passes. Refs #270 Co-Authored-By: Claude Opus 5.5 --- .claude/skills/verify-open-pstack/features/recipes.ts | 2 +- .claude/skills/verify-open-pstack/scripts/catalog.test.ts | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.claude/skills/verify-open-pstack/features/recipes.ts b/.claude/skills/verify-open-pstack/features/recipes.ts index 2210879f..16ba16a8 100644 --- a/.claude/skills/verify-open-pstack/features/recipes.ts +++ b/.claude/skills/verify-open-pstack/features/recipes.ts @@ -483,7 +483,7 @@ const setup: Case[] = [{ const sheet = join(f.configHome, 'pstack-models.md'), assertions = [loaded(record, 'pstack:setup-pstack'), await written(record, sheet)]; const text = await readFile(sheet, 'utf8'), descriptors = text.match(DESCRIPTOR) ?? []; if (!descriptors.length || descriptors.some(d => d !== SETUP_DESCRIPTOR)) throw new Error('sheet-descriptors-mismatch'); - if (!Bun.deepEquals(settingLines(text), [FULL_ACCESS_SETTING])) throw new Error('setting-not-full-access'); + if (!Bun.deepEquals(settingLines(text).filter(line => line.startsWith(SETTING)), [FULL_ACCESS_SETTING])) throw new Error('setting-not-full-access'); return { assertions: [...assertions, `sheet:${SETUP_DESCRIPTOR}`, `setting:${FULL_ACCESS_SETTING}`], files: [sheet] }; }, }, { diff --git a/.claude/skills/verify-open-pstack/scripts/catalog.test.ts b/.claude/skills/verify-open-pstack/scripts/catalog.test.ts index b3cc8ad2..11059f43 100644 --- a/.claude/skills/verify-open-pstack/scripts/catalog.test.ts +++ b/.claude/skills/verify-open-pstack/scripts/catalog.test.ts @@ -310,6 +310,14 @@ test('the configure case answers yes to full access and requires that setting wi } }); +test('the configure case keeps another provider\'s writer setting line that setup preserves', async () => { + const f = await fixture('claude'), c = setupCase('configure'), installed = await readCatalog(location); + const written = `# pstack model configuration\n\n${[...installed.defaults].map(([role, lanes]) => + `${role}: ${lanes.map(lane => lane.includes(':') ? 'claude:opus@high' : lane).join(', ')}`).join('\n')}\nmuse writer sandbox: full-access\n${FULL_ACCESS}`; + await writeFile(join(f.dir, 'pstack-models.md'), written); + expect((await c.assert(record('claude', 'pstack:setup-pstack'), f)).assertions).toContain('setting:codex writer sandbox: full-access'); +}); + test('the configure case starts from the daily sheet with only its setting line removed, so setup asks', async () => { const f = await fixture('claude'), c = setupCase('configure'), path = join(f.dir, 'pstack-models.md'); await c.prepare!(f); From a8180695a3c3d2c1b5f13605b0e84b4a0e75d9e3 Mon Sep 17 00:00:00 2001 From: Eric Litman Date: Fri, 6 Nov 2026 09:34:52 -0500 Subject: [PATCH 2/3] fix(verify): let a recipes.ts change name the writers feature A change to features/recipes.ts can name any feature that has a recipe, and writers has one, so the shared-recipe expansion now selects it. Refs #270 Co-Authored-By: Claude Opus 5.5 --- .claude/skills/verify-open-pstack/scripts/core.test.ts | 2 +- .claude/skills/verify-open-pstack/scripts/core.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.claude/skills/verify-open-pstack/scripts/core.test.ts b/.claude/skills/verify-open-pstack/scripts/core.test.ts index b44005c8..2360deab 100644 --- a/.claude/skills/verify-open-pstack/scripts/core.test.ts +++ b/.claude/skills/verify-open-pstack/scripts/core.test.ts @@ -186,7 +186,7 @@ describe('registry and ownership', () => { }); test('the shared recipe implementation reaches every implemented recipe and preserves project proof', () => { const path = '.claude/skills/verify-open-pstack/features/recipes.ts'; - const expected = [...both('catalog', 'setup', 'runner', 'shipped-tools', 'hook:startup', 'project-skill', + const expected = [...both('catalog', 'setup', 'runner', 'shipped-tools', 'hook:startup', 'project-skill', 'writers', ...registry.skills.map(skill => `skill-invocation:${skill}`)), 'claude:agent-preload:poteto-agent'].sort(); for (const file of [{ filename: path }, { filename: 'docs/moved.md', previous_filename: path }]) { const s = classify([file], registry); diff --git a/.claude/skills/verify-open-pstack/scripts/core.ts b/.claude/skills/verify-open-pstack/scripts/core.ts index ffb2bfa7..92bb9ffc 100644 --- a/.claude/skills/verify-open-pstack/scripts/core.ts +++ b/.claude/skills/verify-open-pstack/scripts/core.ts @@ -35,7 +35,7 @@ export function classify(files: ChangedFile[], registry: Registry): Selection { features.add('codex:assets:codex'); covered = true; } const sharedRecipe = path === '.claude/skills/verify-open-pstack/features/recipes.ts'; - if (sharedRecipe) both('catalog'); + if (sharedRecipe) both('catalog', 'writers'); const catalog = registry.catalog.some(p => matches(path, p)); if (catalog) { both('catalog', 'setup', 'runner'); covered = true; } if (sharedRecipe || (!catalog && registry.shared.some(p => matches(path, p)))) { From 4e2814893c9605ed90896131f7cbab468995a6f3 Mon Sep 17 00:00:00 2001 From: Eric Litman Date: Fri, 6 Nov 2026 09:35:16 -0500 Subject: [PATCH 3/3] fix(catalog): name agy's pstack-lane agent and its 1.5.2 tool surface agy's notes still named the agent pstack-read-only and said its tools list strips web, browser and subagent tools. The runner passes `--agent pstack-lane`, and Antigravity CLI 1.5.2 ignores the list; only 1.3.6 honoured it. Regenerated model-catalog.md. Refs #270 Co-Authored-By: Claude Opus 5.5 --- .../pstack/skills/poteto-mode/references/model-catalog.md | 6 +++--- .../skills/poteto-mode/scripts/runner/providers/agy.ts | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/plugins/pstack/skills/poteto-mode/references/model-catalog.md b/plugins/pstack/skills/poteto-mode/references/model-catalog.md index 28481602..38318507 100644 --- a/plugins/pstack/skills/poteto-mode/references/model-catalog.md +++ b/plugins/pstack/skills/poteto-mode/references/model-catalog.md @@ -188,9 +188,9 @@ The runner refuses an access mode outside a provider's Access modes cell before - No agy writer is confined, so a writer needs the model sheet's opt-in (`isolated-write-full-access`); the runner refuses a bounded `isolated-write` lane before launch. On Antigravity CLI 1.5.2, `--mode auto` is not available for the measured account and falls back to the default mode, `--mode accept-edits` denies shell, and `--sandbox` blocks shell writes even in the cwd. An opted-in writer passes `--dangerously-skip-permissions`. Measured on macOS in a linked worktree under the home directory, whose main repository and a sibling directory sat beside it: edits, shell writes and a Python run inside the worktree succeeded, and the edit tool and the shell wrote into every outside target, including the main repository's shared `.git`, a home directory, `/tmp` and `$TMPDIR`. - Antigravity CLI 1.5.2 loads the run-owned agent but ignores its `tools` list: the `init` event of a read-only lane listed 60 tools, among them web search, the browser and subagents. The approval policy still denied writes in a read-only lane. - Headless agy cannot ask for approval. The first tool that needs it is denied, and the turn ends with exit 0, `status: "SUCCESS"` and a `denied_actions` list. Any `response` text is a preamble written before the denied tool, so the runner records a non-empty `denied_actions` as `child-failed`/70 whatever the response says. -- Each lane writes a run-owned agent file, `.agents/agents/pstack-lane.md`, in its private `.provider/` directory (0700, the file 0600), and runs `--add-dir --agent pstack-read-only`. The agent declares only `view_file`, no MCP servers and no skills. The lane keeps `view_file` and `manage_task` and loses web search, `read_url_content`, subagents, `schedule`, `send_message` and the browser. If the file is missing, agy exits 1 with `unknown agent`. -- An agy lane runs in any directory, and the configuration it finds there applies as it is. agy runs the hooks and MCP servers in `.agents/`, `.agent/`, `_agents/` and `_agent/` directories in the cwd and each parent up to the git root, or up to `/` outside a repository, with no trust check, and loads their rules and skills. So a lane whose cwd is under the home directory and outside any git repository, or in a repository rooted at the home directory, also loads the home directory's own `~/.agents/` and its siblings. No flag stops them. A repository agent named `pstack-read-only` replaces the run-owned one. -- No flag turns off the operator's own configuration. `~/.gemini/GEMINI.md` loads as a global rule, and host skills and agy plugin hooks under `~/.gemini/` still load in every lane. The run-owned agent limits only the lane's tools. +- Each lane writes a run-owned agent file, `.agents/agents/pstack-lane.md`, in its private `.provider/` directory (0700, the file 0600), and runs `--add-dir --agent pstack-lane`. The agent declares no MCP servers and no skills, and its `tools` list names only `view_file` for a read-only lane and adds the write and shell tools for a writer. Antigravity CLI 1.3.6 honoured that list, and a read-only lane kept only `view_file` and `manage_task`. If the file is missing, agy exits 1 with `unknown agent`. +- An agy lane runs in any directory, and the configuration it finds there applies as it is. agy runs the hooks and MCP servers in `.agents/`, `.agent/`, `_agents/` and `_agent/` directories in the cwd and each parent up to the git root, or up to `/` outside a repository, with no trust check, and loads their rules and skills. So a lane whose cwd is under the home directory and outside any git repository, or in a repository rooted at the home directory, also loads the home directory's own `~/.agents/` and its siblings. No flag stops them. A repository agent named `pstack-lane` replaces the run-owned one. +- No flag turns off the operator's own configuration. `~/.gemini/GEMINI.md` loads as a global rule, and host skills and agy plugin hooks under `~/.gemini/` still load in every lane. - The lane passes the base allowlist and nothing else. The login is in the macOS keychain, found through `HOME`, so a run-owned `HOME` would be logged out. `GEMINI_API_KEY` did not authenticate and is not passed. - The preflight runs `agy models` and passes when it exits 0 and a line's first tab-separated field is the lane's CLI model ID. Exit 0 without that line is `unavailable-model`/69. Exit 1 with `Please sign in` is `unauthenticated`/77. Any other output is `child-failed`/70. - The prompt goes to stdin as one stream-json line, `{"event":"user","message":{"role":"user","content":}}`, with `--input-format stream-json --output-format stream-json`. The reply is the `result` event's `response` without its trailing newline. The session is `conversation_id`, and usage is `usage`, with `thinking_tokens` as reasoning and `cache_read_tokens` as cached input. agy reports no cost. diff --git a/plugins/pstack/skills/poteto-mode/scripts/runner/providers/agy.ts b/plugins/pstack/skills/poteto-mode/scripts/runner/providers/agy.ts index 0d785e1a..fc51897c 100644 --- a/plugins/pstack/skills/poteto-mode/scripts/runner/providers/agy.ts +++ b/plugins/pstack/skills/poteto-mode/scripts/runner/providers/agy.ts @@ -138,9 +138,9 @@ export const agy = adapter({ "No agy writer is confined, so a writer needs the model sheet's opt-in (`isolated-write-full-access`); the runner refuses a bounded `isolated-write` lane before launch. On Antigravity CLI 1.5.2, `--mode auto` is not available for the measured account and falls back to the default mode, `--mode accept-edits` denies shell, and `--sandbox` blocks shell writes even in the cwd. An opted-in writer passes `--dangerously-skip-permissions`. Measured on macOS in a linked worktree under the home directory, whose main repository and a sibling directory sat beside it: edits, shell writes and a Python run inside the worktree succeeded, and the edit tool and the shell wrote into every outside target, including the main repository's shared `.git`, a home directory, `/tmp` and `$TMPDIR`.", "Antigravity CLI 1.5.2 loads the run-owned agent but ignores its `tools` list: the `init` event of a read-only lane listed 60 tools, among them web search, the browser and subagents. The approval policy still denied writes in a read-only lane.", "Headless agy cannot ask for approval. The first tool that needs it is denied, and the turn ends with exit 0, `status: \"SUCCESS\"` and a `denied_actions` list. Any `response` text is a preamble written before the denied tool, so the runner records a non-empty `denied_actions` as `child-failed`/70 whatever the response says.", - "Each lane writes a run-owned agent file, `.agents/agents/pstack-lane.md`, in its private `.provider/` directory (0700, the file 0600), and runs `--add-dir --agent pstack-read-only`. The agent declares only `view_file`, no MCP servers and no skills. The lane keeps `view_file` and `manage_task` and loses web search, `read_url_content`, subagents, `schedule`, `send_message` and the browser. If the file is missing, agy exits 1 with `unknown agent`.", - "An agy lane runs in any directory, and the configuration it finds there applies as it is. agy runs the hooks and MCP servers in `.agents/`, `.agent/`, `_agents/` and `_agent/` directories in the cwd and each parent up to the git root, or up to `/` outside a repository, with no trust check, and loads their rules and skills. So a lane whose cwd is under the home directory and outside any git repository, or in a repository rooted at the home directory, also loads the home directory's own `~/.agents/` and its siblings. No flag stops them. A repository agent named `pstack-read-only` replaces the run-owned one.", - "No flag turns off the operator's own configuration. `~/.gemini/GEMINI.md` loads as a global rule, and host skills and agy plugin hooks under `~/.gemini/` still load in every lane. The run-owned agent limits only the lane's tools.", + "Each lane writes a run-owned agent file, `.agents/agents/pstack-lane.md`, in its private `.provider/` directory (0700, the file 0600), and runs `--add-dir --agent pstack-lane`. The agent declares no MCP servers and no skills, and its `tools` list names only `view_file` for a read-only lane and adds the write and shell tools for a writer. Antigravity CLI 1.3.6 honoured that list, and a read-only lane kept only `view_file` and `manage_task`. If the file is missing, agy exits 1 with `unknown agent`.", + "An agy lane runs in any directory, and the configuration it finds there applies as it is. agy runs the hooks and MCP servers in `.agents/`, `.agent/`, `_agents/` and `_agent/` directories in the cwd and each parent up to the git root, or up to `/` outside a repository, with no trust check, and loads their rules and skills. So a lane whose cwd is under the home directory and outside any git repository, or in a repository rooted at the home directory, also loads the home directory's own `~/.agents/` and its siblings. No flag stops them. A repository agent named `pstack-lane` replaces the run-owned one.", + "No flag turns off the operator's own configuration. `~/.gemini/GEMINI.md` loads as a global rule, and host skills and agy plugin hooks under `~/.gemini/` still load in every lane.", "The lane passes the base allowlist and nothing else. The login is in the macOS keychain, found through `HOME`, so a run-owned `HOME` would be logged out. `GEMINI_API_KEY` did not authenticate and is not passed.", "The preflight runs `agy models` and passes when it exits 0 and a line's first tab-separated field is the lane's CLI model ID. Exit 0 without that line is `unavailable-model`/69. Exit 1 with `Please sign in` is `unauthenticated`/77. Any other output is `child-failed`/70.", "The prompt goes to stdin as one stream-json line, `{\"event\":\"user\",\"message\":{\"role\":\"user\",\"content\":}}`, with `--input-format stream-json --output-format stream-json`. The reply is the `result` event's `response` without its trailing newline. The session is `conversation_id`, and usage is `usage`, with `thinking_tokens` as reasoning and `cache_read_tokens` as cached input. agy reports no cost.",