pg-node: `npm run send` passes a `--send` flag that index.mjs silently ignores

[dobby-coder]

Problem

In pg-node/package.json:

"send":   "node --env-file-if-exists=.env index.mjs --send",
"upload": "node --env-file-if-exists=.env index.mjs --upload-only"

But pg-node/index.mjs:30 only inspects one flag:

const mode = process.argv.includes('--upload-only') ? 'upload-only' : 'send-email';

--send is parsed as no flag at all — the mode falls through to the default `send-email` branch. This works by coincidence today: anyone copying `npm start` (which has no flag) also gets send-email, so behaviour matches the script names. But:

• Adding a future mode (e.g. `--dry-run`) makes `--send` look load-bearing when it isn't.
• A typo like `--Send` would also "work", masking the bug.
• The CLI usage block in `index.mjs` only mentions npm scripts, not raw flags — so the inconsistency is invisible from a quick read.

Suggested fix

Either:

1. Drop `--send` from the npm script (preferred — keep the flag set minimal):

"send": "node --env-file-if-exists=.env index.mjs"

2. Or honour `--send` explicitly in `index.mjs` and reject unknown flags:

const args = process.argv.slice(2);
const mode =
  args.includes('--upload-only') ? 'upload-only' :
  args.includes('--send')        ? 'send-email' :
  'send-email';

Option 1 is the smaller, more honest fix.

Files

• pg-node/package.json — send script
• pg-node/index.mjs:30 — mode parsing

[dobby-coder]

/dobby

[dobby-coder]

Dobby has received the request! Routing to the right specialist now...

[dobby-coder]

Plan

Taking the issue's preferred fix (option 1): drop the no-op --send flag from the npm script.

Change

pg-node/package.json — send script:

-    "send":   "node --env-file-if-exists=.env index.mjs --send",
+    "send":   "node --env-file-if-exists=.env index.mjs",

That's it. No other files reference the --send flag:

• index.mjs:28 already routes everything that isn't --upload-only into the send-email branch, so behaviour is unchanged.
• pg-node/README.md and the root README.md document only npm run send / npm run upload; neither mentions the raw --send flag.
• index.mjs's usage comment at the top already lists npm scripts only.

Why option 1 over option 2

The issue body argues option 1 is the smaller, more honest fix — fewer moving parts, no fake "validation" of unknown flags, and send-email remains the documented default both with and without an explicit flag. Adding a real --send parser would imply support for flag-level invocation that isn't otherwise documented or tested in this single-file example.

Verification

• npm run send invokes node … index.mjs with no extra args → falls through to send-email (same as today).
• npm run upload and npm start are untouched.
• I'll run node -e syntax check on the JSON and confirm the scripts parse.

Deliverable

Draft PR against main linking back to #52.

[dobby-coder]

Opened draft PR #55 with the fix.