From 091e8050b0f60f6e15aaf5dc864ac643119aa4a2 Mon Sep 17 00:00:00 2001 From: Maciej Kaszynski Date: Thu, 13 Aug 2026 08:29:28 +0100 Subject: [PATCH 1/3] Changing reqs based on clarification --- .../docs/requirements/requirements.rst | 58 ++++++------------- 1 file changed, 18 insertions(+), 40 deletions(-) diff --git a/score/launch_manager/docs/requirements/requirements.rst b/score/launch_manager/docs/requirements/requirements.rst index b7d66dddc..5ae75044d 100644 --- a/score/launch_manager/docs/requirements/requirements.rst +++ b/score/launch_manager/docs/requirements/requirements.rst @@ -296,7 +296,7 @@ Conditional Launching ===================== .. comp_req:: Conditionally launch of processes - :id: comp_req__launch_man__cond_process_start + :id: comp_req__launch_man__config_ready_cond :reqtype: Functional :security: NO :safety: ASIL_B @@ -305,25 +305,12 @@ Conditional Launching :version: 1 :satisfied_by: comp__lifecycle_launch_manager - The :term:`Launch Manager` shall provide support to conditionally start a process - or process group based on the return value of a single or multiple :term:`Processes ` - executed before. + The :term`Launch Manager` shall support configuration of conditions that + shall be met before the component is considered to have reached its + :term:`Ready State`. -.. comp_req:: Condition timeout - :id: comp_req__launch_man__total_wait_time_support - :reqtype: Functional - :security: NO - :safety: ASIL_B - :derived_from: feat_req__lifecycle__conditional_startup[version==1] - :status: valid - :version: 1 - :satisfied_by: comp__lifecycle_launch_manager - - The :term:`Launch Manager` shall provide support for per condition configurable - total wait time for launch conditions to be satisfied. - -.. comp_req:: Conditional launch polling interval - :id: comp_req__launch_man__polling_interval +.. comp_req:: Conditionally launch of processes + :id: comp_req__launch_man__config_ready_cond :reqtype: Functional :security: NO :safety: ASIL_B @@ -332,11 +319,11 @@ Conditional Launching :version: 1 :satisfied_by: comp__lifecycle_launch_manager - The :term:`Launch Manager` shall provide support for per condition configurable - :term:`Polling Interval` for launch conditions to be checked. + The :term:`Launch Manager` shall starts a component only after all its + **dependencies** have successfully reached their **ready state**. -.. comp_req:: Pre-start validation - :id: comp_req__launch_man__validate_conditions +.. comp_req:: Condition timeout + :id: comp_req__launch_man__total_wait_time_support :reqtype: Functional :security: NO :safety: ASIL_B @@ -345,10 +332,11 @@ Conditional Launching :version: 1 :satisfied_by: comp__lifecycle_launch_manager - The :term:`Launch Manager` shall be able to validate the pre-start conditions of the executable using the conditions. + The :term:`Launch Manager` shall support configuration of the maximum time + an activation of a run target can take. -.. comp_req:: post-start validation - :id: comp_req__launch_man__validation_conditions +.. comp_req:: Condition timeout + :id: comp_req__launch_man__total_wait_time_fail :reqtype: Functional :security: NO :safety: ASIL_B @@ -357,7 +345,8 @@ Conditional Launching :version: 1 :satisfied_by: comp__lifecycle_launch_manager - The :term:`Launch Manager` shall be able to validate the start of the executable using the conditions. + If the activation of a run raget exceeds the configured maximum time, then + the :term:`Launch Manager` shall consider this activation as failed. .. comp_req:: Launched Process status :id: comp_req__launch_man__launcher_status_storage @@ -369,7 +358,8 @@ Conditional Launching :version: 1 :satisfied_by: comp__lifecycle_launch_manager - The :term:`Launch Manager` shall provide a way to store the status of the launched process. + The :term:`Launch Manager` shall provide a way to store the status of the + launched process. .. comp_req:: Condition check based on status :id: comp_req__launch_man__condition_check_method @@ -407,18 +397,6 @@ Conditional Launching The :term:`Launch Manager` shall provide a method for condition check for a path. -.. comp_req:: Condition check based on ENV - :id: comp_req__launch_man__env_variable_cond_check - :reqtype: Functional - :security: NO - :safety: ASIL_B - :derived_from: feat_req__lifecycle__conditional_startup[version==1] - :status: valid - :version: 1 - :satisfied_by: comp__lifecycle_launch_manager - - The :term:`Launch Manager` shall provide a method for condition check for environment variable. - .. comp_req:: Condition check based on all dependency :id: comp_req__launch_man__dependency_check :reqtype: Functional From 6c5dbd57fc9fa70b161f7ab0f43eaa5ec1a33d92 Mon Sep 17 00:00:00 2001 From: Maciej Kaszynski Date: Fri, 14 Aug 2026 09:03:03 +0100 Subject: [PATCH 2/3] Fixing reqs --- .../docs/requirements/requirements.rst | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/score/launch_manager/docs/requirements/requirements.rst b/score/launch_manager/docs/requirements/requirements.rst index 5ae75044d..1417db996 100644 --- a/score/launch_manager/docs/requirements/requirements.rst +++ b/score/launch_manager/docs/requirements/requirements.rst @@ -307,10 +307,10 @@ Conditional Launching The :term`Launch Manager` shall support configuration of conditions that shall be met before the component is considered to have reached its - :term:`Ready State`. + **ready state**. .. comp_req:: Conditionally launch of processes - :id: comp_req__launch_man__config_ready_cond + :id: comp_req__launch_man__ready_cond :reqtype: Functional :security: NO :safety: ASIL_B @@ -322,6 +322,10 @@ Conditional Launching The :term:`Launch Manager` shall starts a component only after all its **dependencies** have successfully reached their **ready state**. +.. TODO PR has defined the the bold terms in the glossary, however need to + wait for a release to get these. + see https://github.com/eclipse-score/score/pull/3184 + .. comp_req:: Condition timeout :id: comp_req__launch_man__total_wait_time_support :reqtype: Functional @@ -345,7 +349,7 @@ Conditional Launching :version: 1 :satisfied_by: comp__lifecycle_launch_manager - If the activation of a run raget exceeds the configured maximum time, then + If the activation of a run target exceeds the configured maximum time, then the :term:`Launch Manager` shall consider this activation as failed. .. comp_req:: Launched Process status @@ -358,8 +362,7 @@ Conditional Launching :version: 1 :satisfied_by: comp__lifecycle_launch_manager - The :term:`Launch Manager` shall provide a way to store the status of the - launched process. + The :term:`Launch Manager` shall provide a way to store the status of the launched process. .. comp_req:: Condition check based on status :id: comp_req__launch_man__condition_check_method From 352d8e3be183f7daeba84600555c0dfa65842df9 Mon Sep 17 00:00:00 2001 From: Maciej Kaszynski <161459353+MaciejKaszynski@users.noreply.github.com> Date: Fri, 14 Aug 2026 15:31:24 +0100 Subject: [PATCH 3/3] Rewording requirement titles Co-authored-by: Daniel Thwaites Signed-off-by: Maciej Kaszynski <161459353+MaciejKaszynski@users.noreply.github.com> --- .../launch_manager/docs/requirements/requirements.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/score/launch_manager/docs/requirements/requirements.rst b/score/launch_manager/docs/requirements/requirements.rst index 1417db996..ad4f815d2 100644 --- a/score/launch_manager/docs/requirements/requirements.rst +++ b/score/launch_manager/docs/requirements/requirements.rst @@ -295,7 +295,7 @@ Launching Processes Conditional Launching ===================== -.. comp_req:: Conditionally launch of processes +.. comp_req:: Configurable ready state :id: comp_req__launch_man__config_ready_cond :reqtype: Functional :security: NO @@ -309,7 +309,7 @@ Conditional Launching shall be met before the component is considered to have reached its **ready state**. -.. comp_req:: Conditionally launch of processes +.. comp_req:: Dependency ordering :id: comp_req__launch_man__ready_cond :reqtype: Functional :security: NO @@ -326,7 +326,7 @@ Conditional Launching wait for a release to get these. see https://github.com/eclipse-score/score/pull/3184 -.. comp_req:: Condition timeout +.. comp_req:: Configurable activation timeout :id: comp_req__launch_man__total_wait_time_support :reqtype: Functional :security: NO @@ -339,7 +339,7 @@ Conditional Launching The :term:`Launch Manager` shall support configuration of the maximum time an activation of a run target can take. -.. comp_req:: Condition timeout +.. comp_req:: Activation timeout :id: comp_req__launch_man__total_wait_time_fail :reqtype: Functional :security: NO @@ -349,7 +349,7 @@ Conditional Launching :version: 1 :satisfied_by: comp__lifecycle_launch_manager - If the activation of a run target exceeds the configured maximum time, then + If the activation of a run target exceeds the maximum time, then the :term:`Launch Manager` shall consider this activation as failed. .. comp_req:: Launched Process status