diff --git a/DESCRIPTION b/DESCRIPTION index 3fbdd455..81fce186 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Type: Package Package: effectsize Title: Indices of Effect Size -Version: 1.0.3 +Version: 1.0.3.1 Authors@R: c(person(given = "Mattan S.", family = "Ben-Shachar", diff --git a/NEWS.md b/NEWS.md index 4cba8f80..67185a45 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,10 @@ +# effectsize (dev) + +## Bug fixes + +- `rank_biserial(x, y, paired = TRUE)` gives the same CIs as `rank_biserial(x - y)` (#716) + + # effectsize 1.0.3 ## Bug fixes diff --git a/R/rank_diff.R b/R/rank_diff.R index ce8f7ac8..9337aeea 100644 --- a/R/rank_diff.R +++ b/R/rank_diff.R @@ -176,7 +176,7 @@ rank_biserial <- function( rank_f <- atanh(r_rbs) if (is_paired_or_onesample) { - nd <- sum((x - mu) != 0) + nd <- sum((x - y) - mu != 0) maxw <- (nd^2 + nd) / 2 # From: https://en.wikipedia.org/wiki/Wilcoxon_signed-rank_test#Historical_T_statistic/ diff --git a/tests/testthat/test-rankES.R b/tests/testthat/test-rankES.R index cf9f2fd6..27232609 100644 --- a/tests/testthat/test-rankES.R +++ b/tests/testthat/test-rankES.R @@ -1,14 +1,14 @@ test_that("rank_biserial", { - x <- c(1.83, 0.50, 1.62, 2.48, 1.68, 1.88, 1.55, 3.06, 1.30) - y <- c(0.878, 0.647, 0.598, 2.05, 1.06, 1.29, 1.06, 3.14, 1.29) + x <- c(5.1, 6.0, 7.2, 4.8, 6.5, 5.9, 7.0, 6.1, 5.5, 6.3) + y <- c(4.9, 6.0, 6.5, 4.8, 6.8, 5.3, 6.1, 6.1, 5.9, 5.0) rRB1 <- rank_biserial(x, y, paired = TRUE) rRB2 <- rank_biserial(x - y) expect_equal(rRB1, rRB2, ignore_attr = TRUE) - expect_equal(rRB1[[1]], 0.777, tolerance = 0.01) - expect_equal(rRB1$CI_low, 0.2953631, tolerance = 0.01) - expect_equal(rRB1$CI_high, 0.9441559, tolerance = 0.01) + expect_equal(rRB1[[1]], 0.6428571, tolerance = 0.01) + expect_equal(rRB1$CI_low, -0.06511553, tolerance = 0.01) + expect_equal(rRB1$CI_high, 0.9203429, tolerance = 0.01) A <- c(48, 48, 77, 86, 85, 85, 16) B <- c(14, 34, 34, 77)