Skip to content

Create a verifiable presentation even if verifiable credential does not verify #32

@alexfigtree

Description

@alexfigtree

Issue originally found on LCW: openwallet-foundation-labs/learner-credential-wallet#742

Share links can't be created on LCWs for VC's that are expired. There is a call on the LCW side for vc.createPresentation - Failure to create a public link on LCW for the "certified-safe-4-agilist.png" credential appears to be coming from app/lib/present.ts on this line:

const presentation = vc.createPresentation({ verifiableCredential, holder })

From James:

It is that the LCW needs a VerifiablePresentation to pass to verifierPlus, and so uses the @digitalcredentials/vc library to construct the verifiablePresentation, i.e, the vc.createPresentation call.

But, the vc.createPresentation call won't, by design, create a presentation if any of the credentials passed in don't verify.

So, we need to modify vc.createPresentation to allow for creating a presentation even if one of the VCs doesn't verify.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status

    Spit Shine Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions