From 4da13815c298f7363d33be29a6779564a06ff879 Mon Sep 17 00:00:00 2001 From: iliev-blnk Date: Thu, 22 Oct 2026 12:44:33 +0300 Subject: [PATCH] fix: declare type declaration dependencies The published declarations of @react-pdf/font and @react-pdf/textkit import fontkit, whose types come from @types/fontkit, which both list only as a devDependency. textkit and layout also import types from @react-pdf/font without depending on it. Projects that check library declarations (skipLibCheck: false) fail to type-check until they add these themselves. Fixes #3592 --- .changeset/declaration-dependencies.md | 7 +++++++ packages/font/package.json | 2 +- packages/layout/package.json | 1 + packages/textkit/package.json | 5 ++--- 4 files changed, 11 insertions(+), 4 deletions(-) create mode 100644 .changeset/declaration-dependencies.md diff --git a/.changeset/declaration-dependencies.md b/.changeset/declaration-dependencies.md new file mode 100644 index 000000000..7bdeeb9a8 --- /dev/null +++ b/.changeset/declaration-dependencies.md @@ -0,0 +1,7 @@ +--- +'@react-pdf/font': patch +'@react-pdf/textkit': patch +'@react-pdf/layout': patch +--- + +fix: declare the packages imported by published type declarations as dependencies (`@types/fontkit` in font and textkit, `@react-pdf/font` in textkit and layout), so they type-check with `skipLibCheck: false` diff --git a/packages/font/package.json b/packages/font/package.json index 48dfc11c9..0d76480a3 100644 --- a/packages/font/package.json +++ b/packages/font/package.json @@ -24,6 +24,7 @@ }, "dependencies": { "@react-pdf/types": "^2.14.0", + "@types/fontkit": "^2.0.7", "fontkit": "^2.0.2", "is-url": "^1.2.4", "pdfkit": "0.20.1" @@ -32,7 +33,6 @@ "lib" ], "devDependencies": { - "@types/fontkit": "^2.0.7", "@types/is-url": "^1.2.32" } } diff --git a/packages/layout/package.json b/packages/layout/package.json index 4e6c84aa3..6132c6642 100644 --- a/packages/layout/package.json +++ b/packages/layout/package.json @@ -21,6 +21,7 @@ }, "dependencies": { "@react-pdf/fns": "3.1.3", + "@react-pdf/font": "^4.1.2", "@react-pdf/image": "^3.1.2", "@react-pdf/paginate": "1.0.1", "@react-pdf/primitives": "^4.4.0", diff --git a/packages/textkit/package.json b/packages/textkit/package.json index 239d04b8b..9fa2f7af3 100644 --- a/packages/textkit/package.json +++ b/packages/textkit/package.json @@ -26,11 +26,10 @@ ], "dependencies": { "@react-pdf/fns": "3.1.3", + "@react-pdf/font": "^4.1.2", "@react-pdf/hyphenate": "^0.1.0", + "@types/fontkit": "^2.0.7", "bidi-js": "^1.0.2", "unicode-properties": "^1.4.1" - }, - "devDependencies": { - "@types/fontkit": "^2.0.7" } }