From 5500b04fb346838f52802b0f13666a033c036446 Mon Sep 17 00:00:00 2001 From: Raymond Khalife Date: Mon, 27 Jul 2026 12:12:12 +0000 Subject: [PATCH 1/3] chore: Use the offical static site recipe --- .github/workflows/deploy-ic.yml | 2 +- icp.yaml | 24 +++++++----------------- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/.github/workflows/deploy-ic.yml b/.github/workflows/deploy-ic.yml index a1555e7e..210007c5 100644 --- a/.github/workflows/deploy-ic.yml +++ b/.github/workflows/deploy-ic.yml @@ -50,4 +50,4 @@ jobs: ICP_IDENTITY: ${{ secrets.DFX_IDENTITY_DESIGN_TEAM }} - name: Deploy to IC mainnet - run: icp deploy -e ic frontend + run: ICP_CLI_PLUGIN_COMPUTE_LIMIT_SECS=120 icp deploy -e ic frontend diff --git a/icp.yaml b/icp.yaml index 0fef1433..359820be 100644 --- a/icp.yaml +++ b/icp.yaml @@ -6,20 +6,10 @@ networks: canisters: - name: frontend - build: - steps: - - type: pre-built - url: https://github.com/dfinity/certified-assets/releases/download/snapshot-pr69-7571cba/canister.wasm - sha256: aaacb5c927deb57ebd1ec1108b22693b7622b2317ebf6f859f07b7b689aecf5b - - sync: - steps: - - type: script - commands: - - npm install - - npm run build - - type: plugin - url: https://github.com/dfinity/certified-assets/releases/download/snapshot-pr69-7571cba/plugin.wasm - sha256: ee9a000ea6f3023f2996b4e9f7d2514298fe2c8fbd9e52e1c6fdf29536fa3628 - dirs: - - dist + recipe: + type: "@dfinity/static-site@v0.3.1" + configuration: + build: + - npm install + - npm run build + dir: dist From 72cfc44abb771f629abcd59f7736ad402e407b5c Mon Sep 17 00:00:00 2001 From: Raymond Khalife Date: Mon, 27 Jul 2026 12:28:12 +0000 Subject: [PATCH 2/3] bump plugin compute limit --- .github/workflows/preview-deployment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/preview-deployment.yml b/.github/workflows/preview-deployment.yml index 6209d150..17e325f1 100644 --- a/.github/workflows/preview-deployment.yml +++ b/.github/workflows/preview-deployment.yml @@ -64,7 +64,7 @@ jobs: echo "PREVIEW_CANISTER_ID=$canister_id" >> $GITHUB_ENV # Deploy (icp.yaml recipe handles the build) - icp deploy frontend -e ic --mode reinstall + ICP_CLI_PLUGIN_COMPUTE_LIMIT_SECS=120 icp deploy frontend -e ic --mode reinstall env: POOL_CONTROLLER_IDENTITY: ${{ secrets.POOL_CONTROLLER_IDENTITY }} From 89c7c1bd37318dd1cf1df098b73653c93dd56753 Mon Sep 17 00:00:00 2001 From: Marco Walz Date: Mon, 27 Jul 2026 15:20:38 +0200 Subject: [PATCH 3/3] ci: bump icp-cli to 1.2.0 so the plugin compute limit applies ICP_CLI_PLUGIN_COMPUTE_LIMIT_SECS was added in icp-cli v1.2.0. On 0.2.7 the limit is a compile-time constant, so the env var was silently ignored and brotli compression of the asset bundle hit the 60s cap. --- .github/workflows/deploy-ic.yml | 4 ++-- .github/workflows/preview-deployment.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/deploy-ic.yml b/.github/workflows/deploy-ic.yml index 210007c5..37ea1b93 100644 --- a/.github/workflows/deploy-ic.yml +++ b/.github/workflows/deploy-ic.yml @@ -37,7 +37,7 @@ jobs: - run: npm run build - name: Install icp-cli - run: npm i -g @icp-sdk/icp-cli@0.2.7 @icp-sdk/ic-wasm + run: npm i -g @icp-sdk/icp-cli@1.2.0 @icp-sdk/ic-wasm - name: Import deploy identity run: | @@ -50,4 +50,4 @@ jobs: ICP_IDENTITY: ${{ secrets.DFX_IDENTITY_DESIGN_TEAM }} - name: Deploy to IC mainnet - run: ICP_CLI_PLUGIN_COMPUTE_LIMIT_SECS=120 icp deploy -e ic frontend + run: ICP_CLI_PLUGIN_COMPUTE_LIMIT_SECS=120 icp deploy -e ic frontend diff --git a/.github/workflows/preview-deployment.yml b/.github/workflows/preview-deployment.yml index 17e325f1..0247506e 100644 --- a/.github/workflows/preview-deployment.yml +++ b/.github/workflows/preview-deployment.yml @@ -41,7 +41,7 @@ jobs: python-version: "3.10" - name: Install icp-cli - run: npm i -g @icp-sdk/icp-cli@0.2.7 @icp-sdk/ic-wasm + run: npm i -g @icp-sdk/icp-cli@1.2.0 @icp-sdk/ic-wasm - run: npm ci @@ -64,7 +64,7 @@ jobs: echo "PREVIEW_CANISTER_ID=$canister_id" >> $GITHUB_ENV # Deploy (icp.yaml recipe handles the build) - ICP_CLI_PLUGIN_COMPUTE_LIMIT_SECS=120 icp deploy frontend -e ic --mode reinstall + ICP_CLI_PLUGIN_COMPUTE_LIMIT_SECS=120 icp deploy frontend -e ic --mode reinstall env: POOL_CONTROLLER_IDENTITY: ${{ secrets.POOL_CONTROLLER_IDENTITY }}