From 98b8bd674e74c7c3fd9ae194b76693d08075b748 Mon Sep 17 00:00:00 2001 From: Scot Schuchert-Wells Date: Wed, 11 Nov 2026 14:57:40 +0000 Subject: [PATCH] fix: silence controller-runtime logger warning The CLI never sets a controller-runtime logger. When a client is built more than 30 seconds after start, as happens when an exec session ends on its time limit, controller-runtime prints a "log.SetLogger was never called" warning with a full goroutine stack trace to the user's terminal. Key changes: - set a discard logger at plugin startup so the warning never fires --- cmd/datumctl-compute/main.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cmd/datumctl-compute/main.go b/cmd/datumctl-compute/main.go index 4a0a126e..f7817d37 100644 --- a/cmd/datumctl-compute/main.go +++ b/cmd/datumctl-compute/main.go @@ -5,8 +5,10 @@ import ( "fmt" "os" + "github.com/go-logr/logr" "go.datum.net/datumctl/plugin" "go.miloapis.com/service-catalog/pkg/activation" + ctrllog "sigs.k8s.io/controller-runtime/pkg/log" "go.datum.net/compute/internal/cmd/compute" "go.datum.net/compute/internal/cmd/compute/util" @@ -16,6 +18,8 @@ import ( var version = "dev" func main() { + ctrllog.SetLogger(logr.Discard()) + plugin.ServeManifest(plugin.Manifest{ Name: "compute", Version: version,