modulegroups: right-click should adjust current preset if it is adjustable

[elstoc]

Currently, if a user right-clicks on a module group icon in the darkroom and adds or removes a module or widget, this automatically creates a new preset named "last modified layout", to which the adjustment is made.

While this is fine (and is the only reasonable behaviour) when the user has selected a read-only preset, it creates an annoying workflow if they are working with a user-defined preset - the user has to go into the preset menu and either adjust their existing preset to match or delete their existing preset and rename "last modified layout".

Please can this be changed so that the "last modified layout" preset is only created or altered when adjusting read-only presets.

[elstoc]

@AlicVB what do you think?

[AlicVB]

I see your point, but there's a drawback here : context-menu add-remove has been introduce to solve current workflow :

• you have defined a nice set of groups that work for most of your work.
• one day, you have to edit a bunch of images which some specials iop that you don't use the rest of the time.
• you add them with the context-menu
• once you are done with the work, you can go back to your usual set of group by reselecting your preset.

The idea here was to avoid as much as possible the use of the preset manager for "day-work" and "temporary" settings. Keeping the manager to define finetuned presets that you'll use many time in future.

Now I see your point too, I just don't know how to conciliate them ;)

[elstoc]

Well imo that's what the search is for. The way this would work in an iop module is that it would detect that you selected a preset and then altered it, and give you the opportunity to update that preset or create a new one. Is there a way we could do the same here? Perhaps store the last selected preset somewhere.

[github-actions]

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

[elstoc]

Still wanted.

[johnny-bit]

I want this too. It'd be very nice to have when building own presets.

[dterrahe]

For other preset menus (iop/lib) you get a menu item "update preset" when you change anything in the active preset. For read-only you have store new preset.

[AlicVB]

Ideally, we could consider "last modified" preset as a "not saved" one and propose the update preset menu in that case.

What I want to avoid is "automatic" update because of the following workflow :

• you take the time to define and refine a nice layout preset (which is read-write de facto)
• you face an unusual bunch of images that need for example perspective correction, liquify, ....
• you add them via right click
• you need to have a way to retrieve easily your previous well defined preset which won't be possible in case of "automatic" update

[dterrahe]

Ideally, we could consider "last modified" preset as a "not saved" one and propose the update preset menu in that case.

I think that would work across all preset scenarios.

The only "risk" might be auto-applied presets. Say, you are tailoring your current layout with the intention of eventually saving it/updating it. But now you go to a different image and the standard layout you set up for that image gets auto-applied and you lose your changes.

[elstoc]

@AlicVB fair enough. So you store the last used layout and the last selected preset separately. Always load the last used layout into the module groups when launching darkroom. If the last used layout differs from the last selected preset, then the presets menu also contains the options "update preset X" (for non-read-only presets) and "create new preset". This tells the user that they selected preset X and then changed it. The user should also have the choice of reverting to the saved version of preset X (discarding their changes).

The key here is that the "last used layout" remains hidden and is used only to drive the current modulegroup settings and the update/create options in the menu.