Fix #14700 FN constParameterPointer with usage in ternary (#8503)

Author: chrchr-github

lib/checkother.cpp

@@ -1947,6 +1947,10 @@ void CheckOther::checkConstPointer()
                         continue;
                     if (mSettings->library.isFunctionConst(parent->astOperand2()))
                         continue;
+                    if (parent->astOperand2()->varId()) {
+                        if (gparent->str() == "?" && astIsLHS(parent))
+                            continue;
+                    }
                 }
             }
             if (hasIncDecPlus) {

test/testother.cpp

@@ -4817,6 +4817,12 @@ class TestOther : public TestFixture {
               "  return bar = 0;\n"
               "}\n");
         ASSERT_EQUALS("", errout_str());
+
+        check("struct S { int x; };\n" // #14700
+              "int f(S* s) {\n"
+              "    return s->x ? 1 : 0;\n"
+              "}\n");
+        ASSERT_EQUALS("[test.cpp:2:10]: (style) Parameter 's' can be declared as pointer to const [constParameterPointer]\n", errout_str());
     }
 
     void constArray() {