From 6a1b8b61496683e8b032915d0e7c3ea13ff0e777 Mon Sep 17 00:00:00 2001 From: "coderabbitai[bot]" <136622811+coderabbitai[bot]@users.noreply.github.com> Date: Wed, 15 Apr 2026 20:06:46 +0000 Subject: [PATCH] fix: apply CodeRabbit auto-fixes Fixed 5 file(s) based on 5 unresolved review comments. Co-authored-by: CodeRabbit --- CONTRIBUTING.md | 3 +-- docs/cow-protocol/tutorials/cow-amm-deployer.mdx | 4 ++-- docs/cow-protocol/tutorials/solvers/evaluate.md | 4 ++-- docs/cow-protocol/tutorials/solvers/local_test.md | 4 ++-- docs/cow-protocol/tutorials/solvers/onboard.md | 4 ++-- 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e4fe16ceb..347c24d96 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -15,7 +15,6 @@ Before contributing, make sure you have the following installed: You can help other users in the community to solve their issues in the [CoW Protocol Discord]. [CoW Protocol Discord]: https://discord.gg/cowprotocol -[CoW Protocol Forums]: https://forum.cow.fi ## Opening an issue @@ -37,4 +36,4 @@ Any non-trivial documentation must be first discussed with the maintainers in an When opening the pull request you will be presented with a template and a series of instructions. Read through it carefully and follow all the steps. Expect a review and feedback from the maintainers afterwards. -If you're looking for a good place to start, look for issues labelled ["good first issue"](https://github.com/cowprotocol/docs/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22)! +If you're looking for a good place to start, look for issues labelled ["good first issue"](https://github.com/cowprotocol/docs/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22)! \ No newline at end of file diff --git a/docs/cow-protocol/tutorials/cow-amm-deployer.mdx b/docs/cow-protocol/tutorials/cow-amm-deployer.mdx index c8f1c8d78..27103ea3f 100644 --- a/docs/cow-protocol/tutorials/cow-amm-deployer.mdx +++ b/docs/cow-protocol/tutorials/cow-amm-deployer.mdx @@ -3,7 +3,7 @@ sidebar_position: 6 --- # CoW AMM Deployer -The [CoW AMM Deployer](https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=et) is a user-friendly Safe App that simplifies the process of deploying and managing [CoW AMMs](https://cow.fi/cow-amm) (Automated Market Makers) from Safe wallets. It enables users without programming skills to take advantage of the benefits of CoW AMM. +The [CoW AMM Deployer](https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=eth) is a user-friendly Safe App that simplifies the process of deploying and managing [CoW AMMs](https://cow.fi/cow-amm) (Automated Market Makers) from Safe wallets. It enables users without programming skills to take advantage of the benefits of CoW AMM. The app was developed by [bleu](https://github.com/bleu-fi) with sponsorship from the [CoW Grants DAO](https://grants.cow.fi/). @@ -80,4 +80,4 @@ From the "Manager" page, you can perform two actions: 3. **Can I change the token pair of an existing AMM?** - No, once an AMM is created with a specific token pair, you cannot change the token pair. If you want to provide liquidity for a different token pair, you need to create a new AMM. -For further assistance or questions, join the [CoW Protocol Discord](https://discord.com/invite/cowprotocol) and ask in the `#tech-talk` channel. +For further assistance or questions, join the [CoW Protocol Discord](https://discord.com/invite/cowprotocol) and ask in the `#tech-talk` channel. \ No newline at end of file diff --git a/docs/cow-protocol/tutorials/solvers/evaluate.md b/docs/cow-protocol/tutorials/solvers/evaluate.md index 2048535ef..2ee2a6e45 100644 --- a/docs/cow-protocol/tutorials/solvers/evaluate.md +++ b/docs/cow-protocol/tutorials/solvers/evaluate.md @@ -7,11 +7,11 @@ draft: true ## Getting notified about the ranking -A very useful functionality provided by the driver is the "notify" endpoint, which notifies all solvers participating in an auction about the ranking, once the bidding has closed, i.e., once all solutions have been submitted and have been ranked. (To find out about how solutions are ranked, see [this](https://docs.cow.fi/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards) section). +A very useful functionality provided by the driver is the "notify" endpoint, which notifies all solvers participating in an auction about the ranking, once the bidding has closed, i.e., once all solutions have been submitted and have been ranked. (To find out about how solutions are ranked, see [this](https://docs.cow.fi/cow-protocol/reference/core/auctions/competition-rules) section). The implementation details of the notify endpoint can be found in this PR: [https://github.com/cowprotocol/services/pull/684](https://github.com/cowprotocol/services/pull/684) which describes the callback that the driver does to the solvers once the ranking is complete. -This is very useful both for debugging purposes (as the endpoint also reveals whether the solution failed to simulate) and for interacting with private liquidity quotes that can be immediately "released", once the solver is notified that they did not win the auction. +This is very useful both for debugging purposes (as the endpoint also reveals whether the solution failed to simulate) and for interacting with private liquidity quotes that can be immediately "released", once the solver is notified that they did not win the auction. \ No newline at end of file diff --git a/docs/cow-protocol/tutorials/solvers/local_test.md b/docs/cow-protocol/tutorials/solvers/local_test.md index aa54faf82..03a8c0c0d 100644 --- a/docs/cow-protocol/tutorials/solvers/local_test.md +++ b/docs/cow-protocol/tutorials/solvers/local_test.md @@ -23,7 +23,7 @@ The repository where all the backend services can be found is this one: [https:/ For the autopilot, we run ``` - cargo run --bin autopilot -- --native-price-estimators "baseline|http://driver/baseline" --skip-event-sync true --node-url $NODE_URL --shadow https://api.cow.fi/mainnet --drivers "mysolver1|http://localhost:11088/mysolver1" + cargo run --bin autopilot -- --native-price-estimators "Driver|baseline|http://driver/baseline" --skip-event-sync true --node-url $NODE_URL --shadow https://api.cow.fi/mainnet --drivers "mysolver1|http://localhost:11088/mysolver1|0x0000000000000000000000000000000000000000|0" ``` where one needs to set the NODE_URL appropriately (e.g., a free Infura endpoint). @@ -67,4 +67,4 @@ Once the above are set up and running, one can then start testing their solver e | | Ink | Staging | | | Ink | Production | | | Sepolia | Staging | -| | Sepolia | Production | +| | Sepolia | Production | \ No newline at end of file diff --git a/docs/cow-protocol/tutorials/solvers/onboard.md b/docs/cow-protocol/tutorials/solvers/onboard.md index 06d5172ab..eeca443ab 100644 --- a/docs/cow-protocol/tutorials/solvers/onboard.md +++ b/docs/cow-protocol/tutorials/solvers/onboard.md @@ -123,7 +123,7 @@ Every week on Tuesday your solver will receive payments and rewards for settling We advise using a single rewards address that is available on all networks. -[You can find more information about how we calculate and distribute rewards here.](https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards). The accounting process is documented in detail [here](https://docs.cow.fi/cow-protocol/reference/core/auctions/accounting). +[You can find more information about how we calculate and distribute rewards](https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards). [The accounting process for auctions is documented in detail](https://docs.cow.fi/cow-protocol/reference/core/auctions/accounting). ## 8. Moving to other networks After joining the solver competition on Arbitrum we can enable your solver on other chains relatively soon. For this we will go through the same process of generating addresses, vouching for them, and whitelisting them. For each new chain that we deploy your solver on we will need: @@ -156,4 +156,4 @@ In the staging (barn) competition settling happens on-chain but the volume is mu Finally, production is where the solver is participating in the main solver competition. ### Are there any prerequisites in the shadow environment that we must meet before being allowed to join staging? -No, there are no prerequisites (other than KYC if joining the CoW DAO bonding pool) but it is recommended that the solver manages to submit and win solutions on shadow before staging. +No, there are no prerequisites (other than KYC if joining the CoW DAO bonding pool) but it is recommended that the solver manages to submit and win solutions on shadow before staging. \ No newline at end of file