Remove remaining echo-route coverage from isolation/e2e suites (CL-7381)

Author: TheGreatAxios

apps/hub/test/composition.test.ts

@@ -1,5 +1,5 @@
 // Exercises the hub's own wiring: platform routes answering at boot,
-// the echo extension mounted inside the native tenant middleware, and
+// an extension route mounted inside the native tenant middleware, and
 // same-origin static serving. Platform behavior behind the mounted
 // routes belongs to its own packages and is not re-proven here. Booting
 // the hub runs package migrations, so a reachable DATABASE_URL is
@@ -122,23 +122,22 @@ describeIfDb("shutdown", () => {
 });
 
 describeIfDb("extension mounting", () => {
-  test("echo mounts inside the native tenant middleware", async () => {
+  test("chat mounts inside the native tenant middleware", async () => {
     const hub = await bootHub();
 
-    // Anonymous request to the echo route: the platform's tenant
+    // Anonymous request to an extension route: the platform's tenant
     // middleware answers 401 before the extension's handler runs.
-    const gated = await hub.app.request("/api/tenants/some-tenant/echo", {
-      method: "POST",
-      body: "hello",
-    });
+    const gated = await hub.app.request(
+      "/api/tenants/some-tenant/chat/workbenches",
+    );
     expect(gated.status).toBe(401);
     expect(await gated.json()).toEqual({
       error: { code: "unauthorized", message: "Authentication required" },
     });
 
     // The route exists only under the tenant scope; outside it the
     // path falls through to the interface shell.
-    const outside = await hub.app.request("/echo");
+    const outside = await hub.app.request("/chat/workbenches");
     expect(await outside.text()).toBe("<html>shell</html>");
   });
 

scripts/e2e/walking-skeleton.test.ts

@@ -3,10 +3,10 @@
 // as spawned processes, and a real Postgres named by DATABASE_URL.
 //
 // The path proven, hop by hop: database setup → hub boot → sidecar
-// dial-in → sign-up → tenant creation → the echo extension route inside
-// that tenant → workflow-asset publication over the platform's git
-// smart-HTTP surface → the native workflow deploy → the deployment
-// answering at its mail address (trigger accepted for delivery).
+// dial-in → sign-up → tenant creation → workflow-asset publication over
+// the platform's git smart-HTTP surface → the native workflow deploy →
+// the deployment answering at its mail address (trigger accepted for
+// delivery).
 //
 // The gate this suite holds is deployment-addressable: the trigger mail
 // is minted and accepted (HTTP 202) at the deployment's address. Full
@@ -148,29 +148,6 @@ describe.skipIf(databaseUrl === undefined)("walking skeleton", () => {
       return stringField(res.data, "id", "create tenant");
     });
 
-    // Hop: echo extension route. The one extension the hub mounts,
-    // reached inside the platform's native tenant middleware: an
-    // anonymous request is refused, a member's body comes back
-    // verbatim.
-    await hop("echo extension route", async () => {
-      const anonymous = await api(
-        hub.baseUrl,
-        "POST",
-        `/api/tenants/${tenantId}/echo`,
-        { probe: true },
-      );
-      expectStatus("echo without a session", anonymous, 401);
-
-      const body = `hello from the walking skeleton ${crypto.randomUUID()}`;
-      const res = await fetch(`${hub.baseUrl}/api/tenants/${tenantId}/echo`, {
-        method: "POST",
-        headers: { cookie: user.cookies.join("; ") },
-        body,
-      });
-      expect(res.status).toBe(200);
-      expect(await res.text()).toBe(body);
-    });
-
     // Hop: workflow asset. The echo workflow definition, built by its
     // own package, published as a workflow asset whose source tree
     // arrives over the platform's git smart-HTTP surface — the only

test/isolation/isolation.test.ts

@@ -7,7 +7,8 @@
 // gate working rather than dead routes.
 //
 // To extend coverage to a new extension, see the registry note in
-// surfaces.ts and the echo describe block below.
+// surfaces.ts and the "chat workbench move" describe block below for
+// the pattern of an extension-specific assertion.
 
 import { afterAll, describe, expect, test } from "bun:test";
 import {
@@ -198,35 +199,8 @@ if (!databaseUrl) {
 
   // Extension-specific block — the pattern every future extension
   // copies: the generic sweep above already covers its surface entry;
-  // this block asserts the behavior only that extension has.
-  describe("echo extension", () => {
-    test("echoes for a member of the tenant it is mounted under", async () => {
-      const response = await app.request(
-        `/api/tenants/${tenantA.tenantId}/echo`,
-        {
-          method: "POST",
-          headers: { cookie: tenantA.cookie, "content-type": "text/plain" },
-          body: "hello from tenant a",
-        },
-      );
-      expect(response.status).toBe(200);
-      expect(await response.text()).toBe("hello from tenant a");
-    });
-
-    test("refuses a foreign principal before the handler runs", async () => {
-      const response = await app.request(
-        `/api/tenants/${tenantB.tenantId}/echo`,
-        {
-          method: "POST",
-          headers: { cookie: tenantA.cookie, "content-type": "text/plain" },
-          body: "should never be echoed",
-        },
-      );
-      await expectRefusal(response, 403, "forbidden", tenantB.markers);
-      // The refusal must come from the platform's tenant gate, not the
-      // extension: the body is the error envelope, never the echo.
-    });
-  });
+  // a block like this asserts the behavior only that extension has (the
+  // echo demo agent that used to live here was deleted in CL-7381).
 
   describe("chat workbench move", () => {
     /** The `tenancy` annotation `GET .../chat/workbenches` carries for one

test/isolation/surfaces.ts

@@ -81,14 +81,6 @@ export const tenantSurfaces: TenantSurface[] = [
     memberStatus: 404,
   },
   // Extension surfaces. One entry per extension route the hub mounts.
-  {
-    name: "echo extension",
-    method: "POST",
-    path: (t) => `/api/tenants/${t}/echo`,
-    body: "isolation-ping",
-    contentType: "text/plain",
-    memberStatus: 200,
-  },
   {
     // Every workbench is now minted as a child tenant of the bench that
     // creates it (see packages/chat/src/workbench-tenancy.ts); this