fix(session): strip needle periods and require http(s) schemes

Author: TheGreatAxios

src/session/compaction-verify.test.ts

@@ -119,6 +119,13 @@ describe("extractContinuationFacts", () => {
     const report = verifyCompactionSummary("anything", facts);
     expect(report.supported).toBe(true);
   });
+
+  test("uppercase HTTP URL in user text is lifted into exactNames", () => {
+    const facts = extractContinuationFacts([
+      textTurn("user", "Call HTTP://API.COM next"),
+    ]);
+    expect(facts.exactNames).toContain("HTTP://API.COM");
+  });
 });
 
 describe("verifyCompactionSummary", () => {
@@ -160,6 +167,28 @@ describe("verifyCompactionSummary", () => {
     }
   });
 
+  test("trailing period on a goal needle does not miss an unpunctuated summary", () => {
+    const facts = extractContinuationFacts([textTurn("user", "Fix auth now.")]);
+    const report = verifyCompactionSummary("Fix auth now", facts);
+    expect(report.misses.some((m) => m.kind === "goal")).toBe(false);
+  });
+
+  test("trailing period on a constraint needle does not miss an unpunctuated summary", () => {
+    const facts = {
+      goal: "Fix auth now",
+      constraints: ["Never use emojis."],
+      nextAction: "",
+      verification: [],
+      blockers: [],
+      exactNames: [],
+    };
+    const report = verifyCompactionSummary(
+      "Fix auth now. Never use emojis",
+      facts,
+    );
+    expect(report.misses.some((m) => m.kind === "constraint")).toBe(false);
+  });
+
   test("denying failure while errors were dropped is a contradiction", () => {
     const facts = extractContinuationFacts(droppedTurns());
     const report = verifyCompactionSummary(
@@ -337,6 +366,31 @@ describe("verifyCompactionSummary", () => {
     expect(report.misses.some((m) => m.kind === "exactName")).toBe(false);
   });
 
+  test("http/client.ts is covered by basename client.ts", () => {
+    for (const filePath of ["http/client.ts", "HTTP/Client.ts"]) {
+      const facts = extractContinuationFacts([
+        textTurn("user", "Fix auth now"),
+        {
+          role: "assistant",
+          content: [
+            {
+              type: "tool_call",
+              id: "c1",
+              name: "read_file",
+              arguments: { path: filePath },
+            },
+          ],
+          timestamp: 2,
+        },
+      ]);
+      const report = verifyCompactionSummary(
+        "Fix auth now. Read client.ts next.",
+        facts,
+      );
+      expect(report.misses.some((m) => m.kind === "exactName")).toBe(false);
+    }
+  });
+
   test("uppercase HTTP URL scores hostname case-insensitively", () => {
     const facts = extractContinuationFacts([
       textTurn("user", "Fix auth now"),

src/session/compaction-verify.ts

@@ -115,7 +115,11 @@ const STOPWORDS = new Set([
 
 function significantTokens(text: string, cap = 24): string[] {
   const out: string[] = [];
-  for (const word of text.toLowerCase().split(/[^a-z0-9_./-]+/)) {
+  for (const raw of text.toLowerCase().split(/[^a-z0-9_./-]+/)) {
+    // `.` stays in the splitter so `vite.config.ts` is one token; a sentence
+    // period still glues to the last word (`now.`, `emojis.`). Strip it from
+    // the needle so an unpunctuated summary still covers the fact.
+    const word = raw.replace(/\.+$/, "");
     if (word.length < 4 || STOPWORDS.has(word)) continue;
     if (!out.includes(word)) out.push(word);
     if (out.length >= cap) break;
@@ -292,7 +296,7 @@ export function extractContinuationFacts(
     }
   }
   for (const text of [...users, ...assistants]) {
-    for (const match of text.match(/https?:\/\/[^\s)]+/g) ?? []) {
+    for (const match of text.match(/https?:\/\/[^\s)]+/gi) ?? []) {
       if (!exactNames.includes(match)) exactNames.push(match);
     }
   }
@@ -319,11 +323,12 @@ export function extractContinuationFacts(
 // its basename.
 function exactNameSupported(name: string, summary: string): boolean {
   const lowered = summary.toLowerCase();
-  if (name.toLowerCase().startsWith("http")) {
+  const loweredName = name.toLowerCase();
+  if (loweredName.startsWith("http://") || loweredName.startsWith("https://")) {
     const host = hostnameOf(name);
     if (host !== undefined && tokenAppears(host.toLowerCase(), lowered))
       return true;
-    return tokenAppears(name.toLowerCase(), lowered);
+    return tokenAppears(loweredName, lowered);
   }
   const base = name.split("/").pop() ?? name;
   return base.length > 0 && tokenAppears(base.toLowerCase(), lowered);