fix(permissions): omit /yolo hint from exec skip-permissions warning

Exec cannot run slash commands, so the recovery hint is TUI-only.
Default-source exec stays path-only; custom sources stay path-only.

Author: TheGreatAxios

src/exec/runner.ts

@@ -611,7 +611,7 @@ export async function runExec(config: Config): Promise<ExecResult> {
 
     if (config.skipPermissionsFromSettings) {
       stderr.write(
-        `${savedSkipPermissionsWarning(config.globalSettingsPath)}\n`,
+        `${savedSkipPermissionsWarning(config.globalSettingsPath, "exec")}\n`,
       );
     }
 

src/permission/saved-skip-warning.test.ts

@@ -6,36 +6,65 @@ import { SETTINGS_DIR_NAME } from "../branding.js";
 import { savedSkipPermissionsWarning } from "./saved-skip-warning.js";
 
 describe("savedSkipPermissionsWarning", () => {
-  test("default machine-wide source appends the /yolo off hint", () => {
+  test("TUI default machine-wide source appends the /yolo off hint", () => {
     const source = join(homedir(), SETTINGS_DIR_NAME, "settings.json");
 
-    const warning = savedSkipPermissionsWarning(source);
+    const warning = savedSkipPermissionsWarning(source, "tui");
 
     expect(warning).toContain(source);
     expect(warning).toContain("edit that file to re-enable");
     expect(warning).toContain("/yolo off");
   });
 
-  test("symlinked-home alias of the default source still appends the hint", async () => {
+  test("TUI symlinked-home alias of the default source still appends the hint", async () => {
     const sandbox = await mkdtemp(join(tmpdir(), "corbits-skip-warning-"));
     const homeLink = join(sandbox, "home");
     await symlink(homedir(), homeLink);
     const aliased = join(homeLink, SETTINGS_DIR_NAME, "settings.json");
 
-    const warning = savedSkipPermissionsWarning(aliased);
+    const warning = savedSkipPermissionsWarning(aliased, "tui");
 
     expect(warning).toContain(aliased);
     expect(warning).toContain("edit that file to re-enable");
     expect(warning).toContain("/yolo off");
   });
 
-  test("custom source keeps file-path wording with no false provenance", () => {
-    const warning = savedSkipPermissionsWarning(
-      "/tmp/custom-corbits-settings.json",
+  test("exec default source stays path-only with no slash", () => {
+    const source = join(homedir(), SETTINGS_DIR_NAME, "settings.json");
+
+    const warning = savedSkipPermissionsWarning(source, "exec");
+
+    expect(warning).toContain(source);
+    expect(warning).toContain("edit that file to re-enable");
+    expect(warning).not.toContain("/yolo");
+    expect(warning).toBe(
+      `Warning: permission prompts are disabled by saved settings at ${source}; edit that file to re-enable.`,
     );
+  });
+
+  test("exec symlinked-home alias of the default source stays path-only", async () => {
+    const sandbox = await mkdtemp(join(tmpdir(), "corbits-skip-warning-"));
+    const homeLink = join(sandbox, "home");
+    await symlink(homedir(), homeLink);
+    const aliased = join(homeLink, SETTINGS_DIR_NAME, "settings.json");
+
+    const warning = savedSkipPermissionsWarning(aliased, "exec");
 
-    expect(warning).toContain("/tmp/custom-corbits-settings.json");
+    expect(warning).toContain(aliased);
     expect(warning).toContain("edit that file to re-enable");
-    expect(warning).not.toMatch(/machine-wide|saved default|\/yolo off/i);
+    expect(warning).not.toContain("/yolo");
+  });
+
+  test("custom source keeps file-path wording with no false provenance on both surfaces", () => {
+    for (const surface of ["tui", "exec"] as const) {
+      const warning = savedSkipPermissionsWarning(
+        "/tmp/custom-corbits-settings.json",
+        surface,
+      );
+
+      expect(warning).toContain("/tmp/custom-corbits-settings.json");
+      expect(warning).toContain("edit that file to re-enable");
+      expect(warning).not.toMatch(/machine-wide|saved default|\/yolo off/i);
+    }
   });
 });

src/permission/saved-skip-warning.ts

@@ -12,9 +12,10 @@ function isDefaultSettingsSource(sourcePath: string): boolean {
 
 export function savedSkipPermissionsWarning(
   globalSettingsPath: string,
+  surface: "tui" | "exec",
 ): string {
   const base = `Warning: permission prompts are disabled by saved settings at ${globalSettingsPath}; edit that file to re-enable`;
-  if (isDefaultSettingsSource(globalSettingsPath)) {
+  if (surface === "tui" && isDefaultSettingsSource(globalSettingsPath)) {
     return `${base} (/yolo off to re-enable).`;
   }
   return `${base}.`;

src/tui/runner/wiring.ts

@@ -96,7 +96,7 @@ export function surfaceSavedSkipPermissionsWarning(
   if (!config.skipPermissionsFromSettings) return;
   surfaceSystemNotice(
     shell,
-    savedSkipPermissionsWarning(config.globalSettingsPath),
+    savedSkipPermissionsWarning(config.globalSettingsPath, "tui"),
   );
 }
 

tests/unit/exec/runner.test.ts

@@ -491,8 +491,9 @@ describe("runExec", () => {
                 );
                 const stderrOutput = stderrChunks.join("");
                 expect(stderrOutput).toContain(
-                  `Warning: permission prompts are disabled by saved settings at ${defaultSettingsPath}; edit that file to re-enable (/yolo off to re-enable).\n`,
+                  `Warning: permission prompts are disabled by saved settings at ${defaultSettingsPath}; edit that file to re-enable.\n`,
                 );
+                expect(stderrOutput).not.toContain("/yolo");
                 expect(stderrOutput).toMatch(/runtime dispose failed/i);
                 expect(disposeCalls).toBe(1);
                 expect(getActiveDisposeHost()).toBeNull();