Bake Corbits PostHog survey ids into /feedback

Operators never configure survey routing; same public-id class as the
baked PostHog project key. Env overrides remain for tests and forks.

Author: TheGreatAxios

docs/TELEMETRY.md

@@ -158,11 +158,12 @@ because the operator typed the text for that purpose. Hard env kill switches
 still win — `DO_NOT_TRACK=1` or `CORBITS_TELEMETRY=0/false/off/no` block
 `/feedback` as well. Sending also requires an installation id and API key.
 
-Survey id / question id come from env (`CORBITS_FEEDBACK_SURVEY_ID`,
-`CORBITS_FEEDBACK_QUESTION_ID`). Both must be set or capture fails closed with
-an “not configured” message — no default survey is baked into the client. When
-ids are missing the command is also hidden from the slash menu (still callable
-if typed). Success copy says “queued,” not delivered; free text over 2000
+Survey id / question id are **baked into the client** (Corbits team survey
+`Corbits Code Feedback`). Same trust class as the public PostHog project key —
+operators never configure them. Optional env overrides
+(`CORBITS_FEEDBACK_SURVEY_ID`, `CORBITS_FEEDBACK_QUESTION_ID`) exist for tests
+and forks; setting either to empty fails closed and hides the command from the
+slash menu. Success copy says “queued,” not delivered; free text over 2000
 characters is truncated with an explicit notice.
 
 ## Opting out

src/telemetry/feedback.test.ts

@@ -62,38 +62,40 @@ describe("buildSurveyProperties", () => {
   test("shapes PostHog custom survey properties", () => {
     const props = buildSurveyProperties("ship it", {
       turnTraceId: "trace-1",
-      env: {
-        CORBITS_FEEDBACK_SURVEY_ID: "survey-abc",
-        CORBITS_FEEDBACK_QUESTION_ID: "q-1",
-      },
     });
-    expect(props.$survey_id).toBe("survey-abc");
+    expect(props.$survey_id).toBe("019fe7ff-d12a-0000-7a63-303f3a874b90");
     expect(props.$survey_response).toBe("ship it");
     expect(props.turn_trace_id).toBe("trace-1");
     expect(props.$survey_questions).toEqual([
       {
-        id: "q-1",
-        question: "What feedback do you have for Corbits Code?",
+        id: "913862f4-82aa-4814-8f68-146c05c38a74",
+        question: "What feedback do you have about Corbits Code?",
         response: "ship it",
       },
     ]);
   });
+
+  test("env override can blank the survey ids", () => {
+    const props = buildSurveyProperties("x", {
+      env: {
+        CORBITS_FEEDBACK_SURVEY_ID: "",
+        CORBITS_FEEDBACK_QUESTION_ID: "",
+      },
+    });
+    expect(props.$survey_id).toBe("");
+  });
 });
 
 describe("captureFeedback", () => {
   test("sends survey sent when ambient telemetry is off", () => {
     const { telemetry, events } = captureSpy();
     expect(telemetry.enabled).toBe(false);
-    const status = captureFeedback(telemetry, "great product", {
-      env: {
-        CORBITS_FEEDBACK_SURVEY_ID: "s1",
-        CORBITS_FEEDBACK_QUESTION_ID: "q1",
-      },
-    });
+    const status = captureFeedback(telemetry, "great product");
     expect(status).toBe("sent");
     expect(events).toHaveLength(1);
     expect(events[0]?.event).toBe("survey sent");
     expect(events[0]?.properties.$survey_response).toBe("great product");
+    expect(events[0]?.properties.$survey_id).toBe("019fe7ff-d12a-0000-7a63-303f3a874b90");
   });
 
   test("rejects empty text", () => {
@@ -110,14 +112,7 @@ describe("captureFeedback", () => {
       batch: { size: 100, intervalMs: 60_000, queueLimit: 100 },
       fetchFn: noopFetch,
     });
-    expect(
-      captureFeedback(telemetry, "hi", {
-        env: {
-          CORBITS_FEEDBACK_SURVEY_ID: "s1",
-          CORBITS_FEEDBACK_QUESTION_ID: "q1",
-        },
-      }),
-    ).toBe("blocked");
+    expect(captureFeedback(telemetry, "hi")).toBe("blocked");
   });
 
   test("blocks under env kill switch even with identity", () => {
@@ -133,30 +128,28 @@ describe("captureFeedback", () => {
     });
     expect(
       captureFeedback(telemetry, "hi", {
-        env: {
-          CORBITS_TELEMETRY: "0",
-          CORBITS_FEEDBACK_SURVEY_ID: "s1",
-          CORBITS_FEEDBACK_QUESTION_ID: "q1",
-        },
+        env: { CORBITS_TELEMETRY: "0" },
       }),
     ).toBe("blocked");
   });
 
-  test("fails closed when survey ids are missing", () => {
+  test("fails closed when survey ids are blanked via env", () => {
     const { telemetry, events } = captureSpy();
-    expect(captureFeedback(telemetry, "hi", { env: {} })).toBe("unconfigured");
+    expect(
+      captureFeedback(telemetry, "hi", {
+        env: {
+          CORBITS_FEEDBACK_SURVEY_ID: "",
+          CORBITS_FEEDBACK_QUESTION_ID: "",
+        },
+      }),
+    ).toBe("unconfigured");
     expect(events).toHaveLength(0);
   });
 
   test("reports truncation when free text exceeds the cap", () => {
     const { telemetry, events } = captureSpy();
     const long = "x".repeat(FEEDBACK_MAX_CHARS + 50);
-    const status = captureFeedback(telemetry, long, {
-      env: {
-        CORBITS_FEEDBACK_SURVEY_ID: "s1",
-        CORBITS_FEEDBACK_QUESTION_ID: "q1",
-      },
-    });
+    const status = captureFeedback(telemetry, long);
     expect(status).toBe("sent_truncated");
     expect(events).toHaveLength(1);
     expect(String(events[0]?.properties.$survey_response).length).toBe(FEEDBACK_MAX_CHARS);

src/telemetry/feedback.ts

@@ -23,24 +23,34 @@ export const FEEDBACK_BLOCKED =
   "Feedback could not be sent (disabled by environment or missing install identity).";
 
 export const FEEDBACK_UNCONFIGURED =
-  "Feedback is not configured (missing survey id). Set CORBITS_FEEDBACK_SURVEY_ID and CORBITS_FEEDBACK_QUESTION_ID.";
+  "Feedback is not configured (missing survey id).";
 
 /**
- * PostHog survey id for /feedback. Set via CORBITS_FEEDBACK_SURVEY_ID once the
- * survey exists in the project (user creates it in PostHog UI).
+ * Corbits team survey — public routing ids (same trust class as the baked-in
+ * PostHog project key). Operators never set these. Env override is for tests
+ * and forks: when the env key is present (even empty), it wins over the default.
  */
+export const DEFAULT_FEEDBACK_SURVEY_ID = "019fe7ff-d12a-0000-7a63-303f3a874b90";
+export const DEFAULT_FEEDBACK_QUESTION_ID = "913862f4-82aa-4814-8f68-146c05c38a74";
+export const FEEDBACK_QUESTION_TEXT = "What feedback do you have about Corbits Code?";
+
+function envOverride(env: NodeJS.ProcessEnv, key: string): string | undefined {
+  // Present key wins (including empty → fail closed for tests/forks).
+  if (!Object.prototype.hasOwnProperty.call(env, key)) return undefined;
+  return (env[key] ?? "").trim();
+}
+
+/** PostHog survey id for /feedback. */
 export function feedbackSurveyId(env: NodeJS.ProcessEnv = process.env): string {
-  return env.CORBITS_FEEDBACK_SURVEY_ID?.trim() ?? "";
+  return envOverride(env, "CORBITS_FEEDBACK_SURVEY_ID") ?? DEFAULT_FEEDBACK_SURVEY_ID;
 }
 
-/**
- * Free-text question id inside the survey. Set via CORBITS_FEEDBACK_QUESTION_ID.
- */
+/** Free-text question id inside the survey. */
 export function feedbackQuestionId(env: NodeJS.ProcessEnv = process.env): string {
-  return env.CORBITS_FEEDBACK_QUESTION_ID?.trim() ?? "";
+  return envOverride(env, "CORBITS_FEEDBACK_QUESTION_ID") ?? DEFAULT_FEEDBACK_QUESTION_ID;
 }
 
-/** True when both survey env ids are present (command is useful to show). */
+/** True when both survey ids resolve (defaults always do unless env blanks them). */
 export function isFeedbackConfigured(env: NodeJS.ProcessEnv = process.env): boolean {
   return feedbackSurveyId(env).length > 0 && feedbackQuestionId(env).length > 0;
 }
@@ -68,7 +78,7 @@ export function buildSurveyProperties(
     $survey_questions: [
       {
         id: questionId,
-        question: "What feedback do you have for Corbits Code?",
+        question: FEEDBACK_QUESTION_TEXT,
         response: capped,
       },
     ],