chore(auth): pin oauth-core to npm 0.2.0

Author: TheGreatAxios

bun.lock

@@ -88,7 +88,7 @@
   "dependencies": {
     "@corbits/agent-intern": "workspace:*",
     "@corbits/codex-provider": "github:corbitsdev/corbits-codex-provider",
-    "@corbits/oauth-core": "github:corbitsdev/corbits-oauth-core",
+    "@corbits/oauth-core": "0.2.0",
     "@corbits/openai-responses": "github:corbitsdev/corbits-openai-responses",
     "@corbits/xai-provider": "github:corbitsdev/corbits-xai-provider",
     "@intx/agent": "workspace:*",

package.json

@@ -5,7 +5,11 @@ import {
   callbackPageHtml,
   type CallbackPageCopy,
 } from "../callback-page.js";
-import { CODEX_CALLBACK_PATH, CODEX_CALLBACK_PORT } from "./constants.js";
+import {
+  CODEX_CALLBACK_HOST,
+  CODEX_CALLBACK_PATH,
+  CODEX_CALLBACK_PORT,
+} from "./constants.js";
 
 export type CodexCallbackServer = CallbackServer;
 
@@ -18,7 +22,7 @@ export async function startCodexCallbackServer(
   return startCallbackServer(expectedState, {
     port: CODEX_CALLBACK_PORT,
     // Codex's registered redirect_uri uses localhost (not 127.0.0.1).
-    host: "localhost",
+    host: CODEX_CALLBACK_HOST,
     path: CODEX_CALLBACK_PATH,
     doneHtml: authorizationDoneHtml("Codex", copy),
     failedHtml: (reason) =>

src/auth/codex/callback-server.ts

@@ -1,4 +1,5 @@
-import { CODEX_REDIRECT_URI } from "@corbits/codex-provider";
+import { callbackTargetFor } from "@corbits/oauth-core";
+import { codexOAuthConfig } from "@corbits/codex-provider";
 
 export {
   CODEX_BASE_URL,
@@ -7,9 +8,10 @@ export {
   CODEX_RESPONSES_PATH,
 } from "@corbits/codex-provider";
 
-const codexRedirect = new URL(CODEX_REDIRECT_URI);
-export const CODEX_CALLBACK_PORT = Number(codexRedirect.port);
-export const CODEX_CALLBACK_PATH = codexRedirect.pathname;
+const callbackTarget = callbackTargetFor(codexOAuthConfig);
+export const CODEX_CALLBACK_HOST = callbackTarget.host;
+export const CODEX_CALLBACK_PORT = callbackTarget.port;
+export const CODEX_CALLBACK_PATH = callbackTarget.path;
 
 // The account's available model catalog. The models endpoint requires a
 // client_version query param.

src/auth/codex/constants.ts

@@ -2,13 +2,11 @@ import { mkdtemp, rm } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { describe, expect, test } from "bun:test";
-import {
-  OAuthRefreshFailedError,
-  OAuthTokenEndpointError,
-} from "@corbits/oauth-core";
+import { OAuthRefreshFailedError } from "@corbits/oauth-core";
 import { errorMessage } from "../../agent/error-message.js";
 import { saveCodexProfile } from "../../config/oauth-stores.js";
 import { formatSubAgentSpawnAuthFailureMessage } from "../../subagent/inference-auth-failure.js";
+import { isOAuthTokenEndpointError } from "../token-session-boundary.js";
 import {
   codexAuthFailureDiagnostic,
   CodexAuthError,
@@ -150,21 +148,21 @@ describe("codex auth failure surface", () => {
         .catch((error: unknown) => error);
       expect(normal).toBeInstanceOf(OAuthRefreshFailedError);
       const normalCause = (normal as OAuthRefreshFailedError).cause;
-      expect(normalCause).toBeInstanceOf(OAuthTokenEndpointError);
+      expect(isOAuthTokenEndpointError(normalCause)).toBe(true);
       expect(normalCause).toMatchObject({ status: 401 });
 
       const staged = await refreshStagedCodexTokens({ ...tokens }, now).catch(
         (error: unknown) => error,
       );
-      expect(staged).toBeInstanceOf(OAuthTokenEndpointError);
+      expect(isOAuthTokenEndpointError(staged)).toBe(true);
       expect(staged).toMatchObject({ status: 401 });
 
       for (const failure of [normal, staged]) {
         let current: unknown = failure;
         while (current instanceof Error) {
           expect(current.message).not.toContain(refresh);
           expect(current.stack).not.toContain(refresh);
-          if (current instanceof OAuthTokenEndpointError)
+          if (isOAuthTokenEndpointError(current))
             expect(current.detail).not.toContain(refresh);
           current = current.cause;
         }

src/auth/codex/session-failure.test.ts

@@ -10,7 +10,7 @@
 // Never logs or persists the token or any response body — only the HTTP
 // status is inspected to classify the result.
 
-import { OAuthTokenEndpointError } from "@corbits/oauth-core";
+import { isOAuthTokenEndpointError } from "./token-session-boundary.js";
 
 import {
   CODEX_BASE_URL,
@@ -81,7 +81,7 @@ export function isBlockingOAuthScopeCheckResult(
 }
 
 function isDefinitiveRefreshAuthRejection(err: unknown): boolean {
-  if (!(err instanceof OAuthTokenEndpointError)) return false;
+  if (!isOAuthTokenEndpointError(err)) return false;
   if (err.status === 401 || err.status === 403) return true;
   return /invalid_grant|revoked/i.test(err.detail);
 }

src/auth/oauth-scope-check.ts

@@ -1,6 +1,9 @@
 import { describe, expect, test } from "bun:test";
 import { OAuthTokenEndpointError } from "@corbits/oauth-core";
-import { sanitizedRefreshFailure } from "./token-session-boundary.js";
+import {
+  isOAuthTokenEndpointError,
+  sanitizedRefreshFailure,
+} from "./token-session-boundary.js";
 
 describe("sanitizedRefreshFailure", () => {
   test("scrubs already-materialized stacks recursively without losing classification", () => {
@@ -28,3 +31,27 @@ describe("sanitizedRefreshFailure", () => {
     expect(endpoint.stack).not.toContain(refresh);
   });
 });
+
+describe("isOAuthTokenEndpointError", () => {
+  test("accepts the host class and a foreign copy with the same name", () => {
+    const local = new OAuthTokenEndpointError(401, "denied");
+    expect(isOAuthTokenEndpointError(local)).toBe(true);
+
+    const foreign = Object.assign(
+      new Error("OAuth token endpoint returned 401"),
+      {
+        name: "OAuthTokenEndpointError",
+        status: 401,
+        detail: "denied",
+      },
+    );
+    expect(foreign).not.toBeInstanceOf(OAuthTokenEndpointError);
+    expect(isOAuthTokenEndpointError(foreign)).toBe(true);
+  });
+
+  test("rejects errors that only share a message", () => {
+    expect(
+      isOAuthTokenEndpointError(new Error("OAuth token endpoint returned 401")),
+    ).toBe(false);
+  });
+});

src/auth/token-session-boundary.test.ts

@@ -10,6 +10,22 @@ export function replaceMutableTokens<TTokens extends object>(
   Object.assign(target, replacement);
 }
 
+// Sibling provider packages may still ship a distinct @corbits/oauth-core
+// copy, so `instanceof` against this host's class identity is not reliable.
+export type OAuthTokenEndpointFailure = Error & {
+  status: number;
+  detail: string;
+};
+
+export function isOAuthTokenEndpointError(
+  err: unknown,
+): err is OAuthTokenEndpointFailure {
+  if (!(err instanceof Error) || err.name !== "OAuthTokenEndpointError")
+    return false;
+  if (!("status" in err) || typeof err.status !== "number") return false;
+  return "detail" in err && typeof err.detail === "string";
+}
+
 export function sanitizedRefreshFailure(
   error: unknown,
   refreshToken: string,

src/auth/token-session-boundary.ts

@@ -1,7 +1,8 @@
 import { describe, expect, test } from "bun:test";
+import { setTimeout as delay } from "node:timers/promises";
 
 import type { CallbackPageCopy } from "../callback-page.js";
-import { XAI_CALLBACK_PORT } from "./constants.js";
+import { XAI_CALLBACK_PATH, XAI_CALLBACK_PORT } from "./constants.js";
 import { startXaiCallbackServer } from "./callback-server.js";
 
 const copy: CallbackPageCopy = {
@@ -12,12 +13,13 @@ const copy: CallbackPageCopy = {
   githubLabel: "github.com/fixture",
 };
 
-const base = `http://127.0.0.1:${String(XAI_CALLBACK_PORT)}/callback`;
+const base = `http://127.0.0.1:${String(XAI_CALLBACK_PORT)}${XAI_CALLBACK_PATH}`;
 
 describe("xAI callback server", () => {
   test("accepts a matching state and returns the code", async () => {
     const server = await startXaiCallbackServer("expected", copy);
     try {
+      expect(server.port).toBe(XAI_CALLBACK_PORT);
       const wait = server.waitForCode(new AbortController().signal);
       const res = await fetch(`${base}?code=abc&state=expected`);
       expect(res.status).toBe(200);
@@ -27,20 +29,21 @@ describe("xAI callback server", () => {
     }
   });
 
-  test("rejects state mismatches before accepting a code", async () => {
+  test("keeps waiting after a state mismatch until a matching redirect", async () => {
     const server = await startXaiCallbackServer("expected", copy);
     try {
-      const wait = server.waitForCode(new AbortController().signal).then(
-        () => ({ ok: true as const }),
-        (err: unknown) => ({ ok: false as const, err }),
-      );
-      const res = await fetch(`${base}?code=abc&state=wrong`);
-      expect(res.status).toBe(400);
-      const result = await wait;
-      expect(result.ok).toBe(false);
-      if (!result.ok) expect(result.err).toBeInstanceOf(Error);
-      if (!result.ok && result.err instanceof Error)
-        expect(result.err.message).toMatch(/state did not match/);
+      const wait = server.waitForCode(new AbortController().signal);
+      const mismatch = await fetch(`${base}?code=abc&state=wrong`);
+      expect(mismatch.status).toBe(400);
+      expect(
+        await Promise.race([
+          wait.then(() => "settled"),
+          delay(50).then(() => "pending"),
+        ]),
+      ).toBe("pending");
+      const match = await fetch(`${base}?code=abc&state=expected`);
+      expect(match.status).toBe(200);
+      await expect(wait).resolves.toBe("abc");
     } finally {
       server.close();
     }

src/auth/xai/callback-server.test.ts

@@ -5,7 +5,11 @@ import {
   callbackPageHtml,
   type CallbackPageCopy,
 } from "../callback-page.js";
-import { XAI_CALLBACK_PATH, XAI_CALLBACK_PORT } from "./constants.js";
+import {
+  XAI_CALLBACK_HOST,
+  XAI_CALLBACK_PATH,
+  XAI_CALLBACK_PORT,
+} from "./constants.js";
 
 export type XaiCallbackServer = CallbackServer;
 
@@ -15,7 +19,7 @@ export async function startXaiCallbackServer(
 ): Promise<XaiCallbackServer> {
   return startCallbackServer(expectedState, {
     port: XAI_CALLBACK_PORT,
-    host: "127.0.0.1",
+    host: XAI_CALLBACK_HOST,
     path: XAI_CALLBACK_PATH,
     doneHtml: authorizationDoneHtml("xAI", copy),
     failedHtml: (reason) =>