fix(permissions): classify symlinked default settings source via path identity

Author: TheGreatAxios

src/permission/saved-skip-warning.test.ts

@@ -1,10 +1,13 @@
 import { describe, expect, test } from "bun:test";
-import { globalSettingsPath } from "../config/settings.js";
+import { mkdtemp, symlink } from "node:fs/promises";
+import { homedir, tmpdir } from "node:os";
+import { join } from "node:path";
+import { SETTINGS_DIR_NAME } from "../branding.js";
 import { savedSkipPermissionsWarning } from "./saved-skip-warning.js";
 
 describe("savedSkipPermissionsWarning", () => {
   test("default machine-wide source appends the /yolo off hint", () => {
-    const source = globalSettingsPath();
+    const source = join(homedir(), SETTINGS_DIR_NAME, "settings.json");
 
     const warning = savedSkipPermissionsWarning(source);
 
@@ -13,6 +16,19 @@ describe("savedSkipPermissionsWarning", () => {
     expect(warning).toContain("/yolo off");
   });
 
+  test("symlinked-home alias of the default source still appends the hint", async () => {
+    const sandbox = await mkdtemp(join(tmpdir(), "corbits-skip-warning-"));
+    const homeLink = join(sandbox, "home");
+    await symlink(homedir(), homeLink);
+    const aliased = join(homeLink, SETTINGS_DIR_NAME, "settings.json");
+
+    const warning = savedSkipPermissionsWarning(aliased);
+
+    expect(warning).toContain(aliased);
+    expect(warning).toContain("edit that file to re-enable");
+    expect(warning).toContain("/yolo off");
+  });
+
   test("custom source keeps file-path wording with no false provenance", () => {
     const warning = savedSkipPermissionsWarning(
       "/tmp/custom-corbits-settings.json",

src/permission/saved-skip-warning.ts

@@ -1,7 +1,13 @@
-import { globalSettingsPath as defaultGlobalSettingsPath } from "../config/settings.js";
+import {
+  globalSettingsPath as defaultGlobalSettingsPath,
+  isProgrammaticSettingsOverride,
+} from "../config/settings.js";
 
 function isDefaultSettingsSource(sourcePath: string): boolean {
-  return sourcePath === defaultGlobalSettingsPath();
+  return !isProgrammaticSettingsOverride(
+    sourcePath,
+    defaultGlobalSettingsPath(),
+  );
 }
 
 export function savedSkipPermissionsWarning(