feat(telemetry): emit session_end for exec and surface on cli_start

Author: TheGreatAxios

src/exec/runner.ts

@@ -371,6 +371,33 @@ export interface ExecResult {
   model?: string;
 }
 
+/**
+ * Builds the `session_end` payload for exec runs, mirroring the TUI exit
+ * reporter's status/exit_reason contract. Falls back to the live turn count
+ * and wall clock when the run never produced a result.
+ */
+export function execSessionEndProperties(
+  result: ExecResult | undefined,
+  startedAt: number,
+  sinkTurns: number,
+): {
+  status: "done" | "failed" | "cancelled";
+  turn_count: number;
+  duration_ms: number;
+  session_mode: "exec";
+  exit_reason: "done" | "error" | "cancelled";
+} {
+  const status = result?.status ?? "failed";
+  return {
+    status,
+    turn_count: result?.turnsUsed ?? sinkTurns,
+    duration_ms: result?.durationMs ?? Date.now() - startedAt,
+    session_mode: "exec",
+    exit_reason:
+      status === "done" ? "done" : status === "failed" ? "error" : "cancelled",
+  };
+}
+
 export function createExecToolCallGate(
   isAdvertised: (name: string) => boolean,
 ): (name: string) => boolean {
@@ -406,7 +433,7 @@ export async function runExec(config: Config): Promise<ExecResult> {
   const task = config.task.trim();
   if (task.length === 0) {
     stderr.write('Usage: corbits exec "<prompt>"\n');
-    return {
+    const result: ExecResult = {
       exitCode: 2,
       sessionId: config.sessionId,
       text: "",
@@ -425,6 +452,11 @@ export async function runExec(config: Config): Promise<ExecResult> {
       provider: config.providerName,
       model: config.model,
     };
+    liveTelemetry.capture(
+      "session_end",
+      execSessionEndProperties(result, Date.now(), 0),
+    );
+    return result;
   }
 
   const sessionId =
@@ -1307,6 +1339,14 @@ export async function runExec(config: Config): Promise<ExecResult> {
         result.error = `runtime dispose failed: ${message}`;
       }
     }
+    liveTelemetry.capture(
+      "session_end",
+      execSessionEndProperties(
+        result,
+        startedAt,
+        runSink?.getTurnCount() ?? turnsUsed,
+      ),
+    );
     clearActiveDisposeHost();
   }
 }

src/index.ts

@@ -79,7 +79,9 @@ export async function mainWithRunners(
     if (settings?.telemetry?.noticeShown === true) {
       const telemetry = createTelemetry({ settings });
       setTelemetry(telemetry);
-      telemetry.capture("cli_start");
+      telemetry.capture("cli_start", {
+        surface: config.command === "exec" ? "exec" : "tui",
+      });
     }
   }
 

src/telemetry/first-run.ts

@@ -60,6 +60,7 @@ export async function activateHeldTelemetry(
   globalSettingsPath: string,
   confirmIntent: () => boolean = () => true,
   deps: FirstRunDeps = defaultDeps,
+  surface: "tui" | "exec" = "tui",
 ): Promise<void> {
   try {
     await deps.markTelemetryNoticeShown(globalSettingsPath);
@@ -89,5 +90,5 @@ export async function activateHeldTelemetry(
   if (!confirmIntent()) return;
   const telemetry = deps.createTelemetry({ settings });
   deps.setTelemetry(telemetry);
-  telemetry.capture("cli_start");
+  telemetry.capture("cli_start", { surface });
 }

src/telemetry/index.ts

@@ -106,7 +106,7 @@ export function getSessionId(): string {
 // capture() appends ($app_version, service_version, os_type, os_arch,
 // schema_version, session_id), this bounds everything telemetry can ever contain.
 const EVENT_PROPERTY_ALLOWLIST: Record<TelemetryEvent, readonly string[]> = {
-  cli_start: [],
+  cli_start: ["surface"],
   session_end: [
     "status",
     "turn_count",