test(permissions): expect /yolo off hint on default-source skip warning

Author: TheGreatAxios

src/permission/saved-skip-warning.test.ts

@@ -0,0 +1,25 @@
+import { describe, expect, test } from "bun:test";
+import { globalSettingsPath } from "../config/settings.js";
+import { savedSkipPermissionsWarning } from "./saved-skip-warning.js";
+
+describe("savedSkipPermissionsWarning", () => {
+  test("default machine-wide source appends the /yolo off hint", () => {
+    const source = globalSettingsPath();
+
+    const warning = savedSkipPermissionsWarning(source);
+
+    expect(warning).toContain(source);
+    expect(warning).toContain("edit that file to re-enable");
+    expect(warning).toContain("/yolo off");
+  });
+
+  test("custom source keeps file-path wording with no false provenance", () => {
+    const warning = savedSkipPermissionsWarning(
+      "/tmp/custom-corbits-settings.json",
+    );
+
+    expect(warning).toContain("/tmp/custom-corbits-settings.json");
+    expect(warning).toContain("edit that file to re-enable");
+    expect(warning).not.toMatch(/machine-wide|saved default|\/yolo off/i);
+  });
+});

src/tui/runner/wiring.skip-permissions-warning.test.ts

@@ -1,4 +1,5 @@
 import { describe, expect, test } from "bun:test";
+import { globalSettingsPath } from "../../config/settings.js";
 import { createAppShell } from "../shell/index.js";
 import { shellInternals } from "../shell/internals.js";
 import { withTestRenderer } from "../harness.js";
@@ -34,12 +35,12 @@ describe("saved skip-permissions startup warning", () => {
     expect(warning).not.toMatch(/machine-wide|saved default|\/yolo off/i);
   });
 
-  test("identifies the default settings path", async () => {
-    const warning = await surfacedWarning(
-      "/home/operator/.corbits/settings.json",
-    );
+  test("appends the /yolo off hint for the default settings path", async () => {
+    const source = globalSettingsPath();
+    const warning = await surfacedWarning(source);
 
-    expect(warning).toContain("/home/operator/.corbits/settings.json");
+    expect(warning).toContain(source);
     expect(warning).toContain("edit that file to re-enable");
+    expect(warning).toContain("/yolo off");
   });
 });

tests/unit/exec/runner.test.ts

@@ -470,7 +470,11 @@ describe("runExec", () => {
               async () => {
                 const { runExec: runExecUnderMock } =
                   await import("../../../src/exec/runner.js");
-                const defaultSettingsPath = join(home, "settings.json");
+                const defaultSettingsPath = join(
+                  home,
+                  ".corbits",
+                  "settings.json",
+                );
                 const result = await runExecUnderMock({
                   ...bareConfig("do the thing"),
                   cwd,
@@ -487,9 +491,8 @@ describe("runExec", () => {
                 );
                 const stderrOutput = stderrChunks.join("");
                 expect(stderrOutput).toContain(
-                  `Warning: permission prompts are disabled by saved settings at ${defaultSettingsPath}; edit that file to re-enable.\n`,
+                  `Warning: permission prompts are disabled by saved settings at ${defaultSettingsPath}; edit that file to re-enable (/yolo off to re-enable).\n`,
                 );
-                expect(stderrOutput).not.toContain("/yolo");
                 expect(stderrOutput).toMatch(/runtime dispose failed/i);
                 expect(disposeCalls).toBe(1);
                 expect(getActiveDisposeHost()).toBeNull();