Skip to content

Commit 0212868

Browse files
committed
Document that ask ids mint at gate emit
Ids exist on the gate event before the overlay opens, so the selector contract and PermissionGateEvent comment should not say they mint at overlay-open.
1 parent 20cff93 commit 0212868

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

‎docs/TUI.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,9 @@ viewport kit: shared windowing, keep-active-visible, and page/jump behavior.
342342
There is exactly one scroll lease at a time; keyboard paging and the mouse
343343
wheel both follow whichever surface currently holds it, so a modal open on
344344
top of the transcript never lets the wheel move the transcript underneath it.
345-
Ask and permission rows are namespaced by the ask id minted when the overlay
346-
opens. Paint replaces the whole options array (labels and ids together);
345+
Ask and permission rows are namespaced by the ask id minted on the gate
346+
event at emit, before the overlay opens. Paint replaces the whole options
347+
array (labels and ids together);
347348
there is no drop-by-id merge. Enter binds by the painted id against the live
348349
bag — a painted value that is not in that bag, or Enter on an empty gate
349350
with no answer field, fail-closes the accept as unavailable rather than

‎src/tui/gate-events.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export interface OperatorGateEvent {
2626
}
2727

2828
export interface PermissionGateEvent {
29-
/** Minted at overlay-open by the TUI emitter, never on PermissionRequest. */
29+
/** Minted by the session emitter at gate emit, never on PermissionRequest. */
3030
id: string;
3131
request: PermissionRequest;
3232
resolve: (outcome: ApprovalOutcome) => void;

0 commit comments

Comments
 (0)