Skip to content

Request to fix a typo in flowmod.go #33

@vanytsvetkov

Description

@vanytsvetkov

My apologies, however, are you sure that this code should look exactly like it does?

binary.BigEndian.PutUint32(bytes[n:], f.OutPort)
n += 4
binary.BigEndian.PutUint32(bytes[n:], f.OutPort)
n += 4

Perhaps you wanted to write something like:

        binary.BigEndian.PutUint32(bytes[n:], f.OutPort) 
        n += 4 
        binary.BigEndian.PutUint32(bytes[n:], f.OutGroup) 
        n += 4 

Just check the source code of OpenvSwitch to be completely sure.

        ofm->out_port = ofputil_port_to_ofp11(fm->out_port);
        ofm->out_group = htonl(fm->out_group);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions