Skip to content

Commit a807b77

Browse files
committed
Improve SRP in RendererContext by extracting initialization logic
1 parent 56f3cf4 commit a807b77

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

commonmark/src/main/java/org/commonmark/renderer/html/HtmlRenderer.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,18 @@ private class RendererContext implements HtmlNodeRendererContext, AttributeProvi
247247

248248
private RendererContext(HtmlWriter htmlWriter) {
249249
this.htmlWriter = htmlWriter;
250-
251-
attributeProviders = new ArrayList<>(attributeProviderFactories.size());
250+
this.attributeProviders = createAttributeProviders();
251+
initializeNodeRenderers();
252+
}
253+
private List<AttributeProvider> createAttributeProviders() {
254+
List<AttributeProvider> providers = new ArrayList<>(attributeProviderFactories.size());
252255
for (var attributeProviderFactory : attributeProviderFactories) {
253-
attributeProviders.add(attributeProviderFactory.create(this));
256+
providers.add(attributeProviderFactory.create(this));
254257
}
258+
return providers;
259+
}
255260

261+
private void initializeNodeRenderers() {
256262
for (var factory : nodeRendererFactories) {
257263
var renderer = factory.create(this);
258264
nodeRendererMap.add(renderer);

0 commit comments

Comments
 (0)