no-mistakes(review): Preserve major short-circuit in multiline bump detection

Author: bearomorphism

commitizen/version_increment.py

@@ -90,14 +90,21 @@ def from_message(
         This method preserves that behavior while returning a comparable enum.
         """
         select_pattern = cls._compile_pattern(regex)
-        increments = []
+        increment = cls.NONE
 
         for line in message.split("\n"):
             result = select_pattern.search(line)
-            if result:
-                increments.append(cls.from_match(result.group(1), increments_map))
+            if not result:
+                continue
 
-        return max(increments, default=cls.NONE)
+            increment = max(
+                increment,
+                cls.from_match(result.group(1), increments_map),
+            )
+            if increment == cls.MAJOR:
+                return increment
+
+        return increment
 
     @classmethod
     def get_highest_by_messages(

tests/test_version_increment.py

@@ -222,6 +222,19 @@ def test_get_highest_by_messages_supports_custom_none_mapping() -> None:
 
 
 
+def test_from_message_stops_after_major_match() -> None:
+    """A major match on one line shields later invalid lines in that message."""
+    assert (
+        VersionIncrement.from_message(
+            "break: api\n\noops: typo",
+            r"^(break|oops)",
+            {"break": "MAJOR", "oops": "MINORR"},
+        )
+        == VersionIncrement.MAJOR
+    )
+
+
+
 def test_get_highest_by_messages_raises_for_invalid_bump_map_value() -> None:
     """A matched custom bump-map value must fail instead of becoming NONE."""
     with pytest.raises(ValueError, match="MINORR"):