Skip to content

Commit 2a8f771

Browse files
committed
Fix PHPStan warnings for RedisHandler and update changelog
1 parent b3ed687 commit 2a8f771

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎system/Session/Handlers/RedisHandler.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ public function __construct(SessionConfig $config, string $ipAddress)
9898
$this->keyPrefix .= $this->ipAddress . ':';
9999
}
100100

101-
$this->lockRetryInterval = $config->lockRetryInterval ?? $this->lockRetryInterval;
102-
$this->lockMaxRetries = $config->lockMaxRetries ?? $this->lockMaxRetries;
101+
$this->lockRetryInterval = $config->lockRetryInterval ?? $this->lockRetryInterval; // @phpstan-ignore nullCoalesce.property
102+
$this->lockMaxRetries = $config->lockMaxRetries ?? $this->lockMaxRetries; // @phpstan-ignore nullCoalesce.property
103103
}
104104

105105
protected function setSavePath(): void

‎user_guide_src/source/changelogs/v4.7.4.rst‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ Bugs Fixed
3333
- **API:** Fixed a bug in Transformers where the root request's ``fields`` and ``include`` query parameters leaked into nested transformers created inside ``include*()`` methods, causing incorrect field filtering, unexpected includes, or infinite recursion.
3434
- **Database:** Fixed a bug where ``updateBatch()`` could be called after Query Builder ``where()`` conditions, even though it's not supported. In this situation, now the ``DatabaseException`` is thrown.
3535
- **HTTP:** Fixed a bug where the User Agent library reported Safari's WebKit version instead of the browser version from the ``Version`` token.
36+
- **Session:** Fixed a bug in ``RedisHandler`` where missing ``$lockRetryInterval`` and ``$lockMaxRetries`` properties in a custom ``Session`` configuration file could trigger an ``Undefined property`` warning or error.
3637

3738
See the repo's
3839
`CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_

0 commit comments

Comments
 (0)