SDK is broken: trying to get KV value throws exception

[martinbean]

When trying to retrieve the value of a key–value pair using the Cloudflare\API\Endpoints\WorkersKV::getAllKeysAndValuesForNamespace method, the SDK throws a JSONException because the response of that call (https://api.cloudflare.com/#workers-kv-namespace-read-key-value-pair) is just plain text, and not JSON as the SDK is naïvely assuming all responses are. However, the API does return application/json as the Content-Type.

The API either needs to return an appropriate content type for responses, or the SDK needs to accommodate plain text responses like this.

[dumityty]

Just ran into the same issue when I start using the code in PR #139 to use the WorkerKV endpoints.
It looks like the issue is with the Guzzle adapter in the checkError method (\Cloudflare\API\Adapter\Guzzle::checkError) where the response is always assumed to be JSON, though looks like very few endpoints can return plain text values now:

private function checkError(ResponseInterface $response)
    {
        $json = json_decode($response->getBody());
...

[deuill]

I've responded on #162 but responding here as well for clarity -- this issue needs a bit of investigation as the responses for the Workers KV endpoint (e.g. "Some Value") are indeed valid JSON and should be decoded as such via json_decode, e.g.:

$ php -r 'var_dump(json_decode(\'"Some Value"\'));'
string(10) "Some Value"

There's probably something else at play here, I'll give this a look-see and come back with more info.

--- SNIP ---

Ignore the above, the aforementioned endpoint returns application/octet-stream responses, and there's multiple places where these aren't expected, including the checkError function above. I'm opening a PR for fixing that part, but additional fixes will need to be made to #139, which we're also looking to push through.