Repository navigation
Commit ee7e06b
fix(website): deploy main, not the tag ref (#837)
* fix(website): deploy main, not the tag ref
Two fixes to the release-triggered deploy observed in run 38835604913:
1. The website environment's custom branch policy does not admit tag
refs, and the release event's ref IS a tag — the deploy can never pass
environment protection. Checkout refs/heads/main instead: the release
commit is main's tip by construction (changesets opens the release PR
from main), so the deployed build is the released content.
2. Restore job-level concurrency (lost when the workflow landed on main
without it): a relay release must fail the job's tag filter before it
enters the deploy queue, not after, or it can replace a queued website
deploy.
* chore(website): add the changeset for the deploy fix
* fix(website): check out the release tag, not main
The environment's branch policy admits nostream-website@* (every
release deploy since 1.1.1 has run on the tag ref), so the
refs/heads/main pin was never needed for admission — and it was wrong
for correctness: main can advance between the release publish and the
job starting, and the pin would build and deploy unreleased content.
Keep the default tag checkout so the deployed build is exactly the
released commit. Also restore the router-worker deploy line the branch
predates.
* docs(website): correct the changeset's checkout description
The changeset still claimed releases deploy main because the
environment rejects tag refs; the fix actually keeps the triggering
tag (which the policy admits) and the real change is the job-scoped
deploy queue. Rewritten before it becomes release notes.
---------
Co-authored-by: Abhay <pandeyabhay967@gmail.com>1 parent 4d7d0d0 commit ee7e06b
2 files changed
Lines changed: 18 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | 15 | | |
20 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
21 | 25 | | |
22 | 26 | | |
23 | 27 | | |
| |||
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
34 | 43 | | |
35 | 44 | | |
36 | 45 | | |
| |||
0 commit comments