Skip to content

Commit df1ed5d

Browse files
Ferryx349cameri
andauthored
fix(admin): update aria-expanded and label when mobile menu is toggled (#714)
* fix(admin): update aria-expanded and label on menu toggle (#712) * chore(changeset): add changeset for menu toggle a11y fix --------- Co-authored-by: Ricardo Cabral <me@ricardocabral.io>
1 parent ef4123e commit df1ed5d

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"nostream": patch
3+
---
4+
5+
fix(admin): update aria-expanded and label when mobile menu is toggled

‎resources/admin/assets/dashboard.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@
282282
document.body.classList.toggle('nav-open', isOpen)
283283
if (menuToggle) {
284284
menuToggle.setAttribute('aria-expanded', String(isOpen))
285+
menuToggle.setAttribute('aria-label', isOpen ? 'Close navigation' : 'Open navigation')
285286
}
286287
if (navPanel) {
287288
navPanel.setAttribute('aria-hidden', String(!isOpen))
@@ -294,7 +295,7 @@
294295
}
295296

296297
const tag = target.tagName.toLowerCase()
297-
return tag === 'input' || tag === 'textarea' || target.isContentEditable
298+
return tag === 'input' || tag === 'textarea' || tag === 'select' || target.isContentEditable
298299
}
299300

300301
const showLogin = () => {
@@ -1300,7 +1301,7 @@
13001301
return
13011302
}
13021303

1303-
if (isTypingTarget(event.target)) {
1304+
if (event.metaKey || event.ctrlKey || event.altKey || isTypingTarget(event.target)) {
13041305
return
13051306
}
13061307

0 commit comments

Comments
 (0)