update code

Author: congminh1254

boxsdk/client/client.py

@@ -2015,7 +2015,7 @@ def get_ai_agent_default_config(
             response_object=box_response.json(),
         )
 
-    def get_authentication(
+    def get_sdk_gen_authentication(
         self, *, token_storage: Optional[TokenStorage] = None
     ) -> Authentication:
         """
@@ -2038,7 +2038,7 @@ def get_authentication(
         """
         return config_adapter.get_authentication(self, token_storage=token_storage)
 
-    def get_network_session(
+    def get_sdk_gen_network_session(
         self,
         *,
         network_client=None,
@@ -2071,6 +2071,32 @@ def get_network_session(
             additional_headers=additional_headers,
         )
 
+    def get_authentication(
+        self, *, token_storage: Optional[TokenStorage] = None
+    ) -> Authentication:
+        """
+        Backward-compatible alias for `get_sdk_gen_authentication()`.
+        """
+        return self.get_sdk_gen_authentication(token_storage=token_storage)
+
+    def get_network_session(
+        self,
+        *,
+        network_client=None,
+        retry_strategy=None,
+        data_sanitizer=None,
+        additional_headers=None,
+    ) -> NetworkSession:
+        """
+        Backward-compatible alias for `get_sdk_gen_network_session()`.
+        """
+        return self.get_sdk_gen_network_session(
+            network_client=network_client,
+            retry_strategy=retry_strategy,
+            data_sanitizer=data_sanitizer,
+            additional_headers=additional_headers,
+        )
+
     def get_sdk_gen_client(
         self,
         *,

boxsdk/client/config_adapter.py

@@ -25,7 +25,6 @@
 from box_sdk_gen.networking.base_urls import BaseUrls
 from box_sdk_gen.networking.network import NetworkSession
 from box_sdk_gen.networking.retries import BoxRetryStrategy
-from box_sdk_gen.schemas.access_token import AccessToken
 
 
 def get_authentication(

docs/config-sharing-implementation.md

@@ -21,7 +21,7 @@ The `LegacyTokenStorageAdapter` class bridges the gap between legacy OAuth2 toke
 
 Three new methods have been added to the `Client` class in `boxsdk/client/client.py`:
 
-#### `get_authentication(token_storage=None)`
+#### `get_sdk_gen_authentication(token_storage=None)`
 
 Extracts authentication configuration from the legacy client and converts it to a generated SDK `Authentication` object.
 
@@ -47,10 +47,10 @@ legacy_auth = OAuth2(client_id="...", client_secret="...")
 legacy_client = Client(legacy_auth)
 
 # Get generated SDK authentication
-gen_auth = legacy_client.get_authentication()
+gen_auth = legacy_client.get_sdk_gen_authentication()
 ```
 
-#### `get_network_session(**options)`
+#### `get_sdk_gen_network_session(**options)`
 
 Extracts network configuration from the legacy client and converts it to a generated SDK `NetworkSession` object.
 
@@ -71,14 +71,14 @@ Extracts network configuration from the legacy client and converts it to a gener
 
 **Example:**
 ```python
-network_session = legacy_client.get_network_session(
+network_session = legacy_client.get_sdk_gen_network_session(
     additional_headers={"X-Custom-Header": "value"}
 )
 ```
 
 #### `get_sdk_gen_client(auth_options=None, network_options=None)`
 
-Creates a fully configured generated SDK client from the legacy client. This is the main convenience method that combines `get_authentication()` and `get_network_session()`.
+Creates a fully configured generated SDK client from the legacy client. This is the main convenience method that combines `get_sdk_gen_authentication()` and `get_sdk_gen_network_session()`.
 
 **Parameters:**
 - `auth_options` (optional): Dictionary with authentication options
@@ -237,37 +237,3 @@ Network settings are extracted from:
 - `Session.proxy_config`: Proxy settings
 - `Session._default_headers`: Custom headers
 - `API.MAX_RETRY_ATTEMPTS`: Retry configuration
-
-## Limitations
-
-1. **JWT Private Key**: If the JWT private key was originally encrypted, the passphrase cannot be extracted from the normalized `RSAPrivateKey` object. The key will be serialized unencrypted.
-
-2. **Token Expiry**: The legacy SDK doesn't always track token expiry times, so the adapter uses a default value (3600 seconds) when converting to `AccessToken`.
-
-3. **Custom Token Storage**: If using custom token storage callbacks in the legacy SDK, ensure they're thread-safe if both clients will be used concurrently.
-
-## Error Handling
-
-The implementation raises:
-
-- `ValueError`: for unsupported auth types or missing credentials
-
-Note: Since `boxsdk` and `box_sdk_gen` are always installed together, import errors for `box_sdk_gen` should not occur in practice.
-
-## Testing
-
-Unit tests should cover:
-- Token storage adapter conversion
-- Each authentication type conversion
-- Network configuration extraction
-- Error cases (missing credentials, unsupported types)
-- Integration tests for `get_sdk_gen_client()`
-
-## Future Enhancements
-
-Potential improvements:
-1. Support for additional authentication types
-2. Better token expiry tracking
-3. Support for encrypted JWT keys with passphrase extraction
-4. More comprehensive network configuration mapping
-

test/boxsdk/integration/test_config_sharing.py

@@ -270,7 +270,7 @@ def test_parallel_client_usage(self, mock_box_session):
         assert gen_client.network_session is not None
 
     def test_get_authentication_with_custom_token_storage(self, mock_box_session):
-        """Test get_authentication() with custom token storage."""
+        """Test get_sdk_gen_authentication() with custom token storage."""
         from box_sdk_gen.box.token_storage import InMemoryTokenStorage
 
         legacy_auth = OAuth2(
@@ -282,13 +282,13 @@ def test_get_authentication_with_custom_token_storage(self, mock_box_session):
 
         custom_storage = InMemoryTokenStorage()
         legacy_client = Client(legacy_auth, session=mock_box_session)
-        gen_auth = legacy_client.get_authentication(token_storage=custom_storage)
+        gen_auth = legacy_client.get_sdk_gen_authentication(token_storage=custom_storage)
 
         assert isinstance(gen_auth, BoxOAuth)
         assert gen_auth.config.token_storage is custom_storage
 
     def test_get_network_session_with_custom_options(self, mock_box_session):
-        """Test get_network_session() with custom options."""
+        """Test get_sdk_gen_network_session() with custom options."""
         from box_sdk_gen.networking.retries import BoxRetryStrategy
 
         legacy_auth = DeveloperTokenAuth(get_new_token_callback=lambda: 'token')
@@ -297,7 +297,7 @@ def test_get_network_session_with_custom_options(self, mock_box_session):
         custom_retry = BoxRetryStrategy(max_attempts=20, retry_base_interval=2.5)
         custom_headers = {'X-Custom': 'value'}
 
-        network_session = legacy_client.get_network_session(
+        network_session = legacy_client.get_sdk_gen_network_session(
             retry_strategy=custom_retry, additional_headers=custom_headers
         )
 

test/boxsdk/unit/client/test_config_sharing.py

@@ -1,7 +1,7 @@
 """
 Unit tests for configuration sharing methods in Client class.
 
-Tests get_authentication(), get_network_session(), and get_sdk_gen_client() methods.
+Tests get_sdk_gen_authentication(), get_sdk_gen_network_session(), and get_sdk_gen_client() methods.
 """
 
 from unittest.mock import Mock
@@ -22,16 +22,16 @@
 from box_sdk_gen.client import BoxClient
 
 
-class TestGetAuthentication:
-    """Test cases for get_authentication() method."""
+class TestGetSdkGenAuthentication:
+    """Test cases for get_sdk_gen_authentication() method."""
 
     def test_get_authentication_developer_token(self, mock_box_session):
         """Test converting DeveloperTokenAuth to BoxDeveloperTokenAuth."""
         token = 'dev_token_123'
         auth = DeveloperTokenAuth(get_new_token_callback=lambda: token)
 
         client = Client(auth, session=mock_box_session)
-        gen_auth = client.get_authentication()
+        gen_auth = client.get_sdk_gen_authentication()
 
         assert isinstance(gen_auth, BoxDeveloperTokenAuth)
         assert gen_auth.token == token
@@ -45,7 +45,7 @@ def test_get_authentication_developer_token_missing_token(self, mock_box_session
         client = Client(auth, session=mock_box_session)
 
         with pytest.raises(ValueError, match="Developer token is not available"):
-            client.get_authentication()
+            client.get_sdk_gen_authentication()
 
     def test_get_authentication_oauth2(self, mock_box_session):
         """Test converting OAuth2 to BoxOAuth."""
@@ -62,7 +62,7 @@ def test_get_authentication_oauth2(self, mock_box_session):
         )
 
         client = Client(auth, session=mock_box_session)
-        gen_auth = client.get_authentication()
+        gen_auth = client.get_sdk_gen_authentication()
 
         assert isinstance(gen_auth, BoxOAuth)
         assert gen_auth.config.client_id == client_id
@@ -77,7 +77,7 @@ def test_get_authentication_oauth2_missing_credentials(self, mock_box_session):
         with pytest.raises(
             ValueError, match="OAuth2 client_id and client_secret are required"
         ):
-            client.get_authentication()
+            client.get_sdk_gen_authentication()
 
     def test_get_authentication_oauth2_with_custom_token_storage(
         self, mock_box_session
@@ -94,7 +94,7 @@ def test_get_authentication_oauth2_with_custom_token_storage(
 
         custom_storage = InMemoryTokenStorage()
         client = Client(auth, session=mock_box_session)
-        gen_auth = client.get_authentication(token_storage=custom_storage)
+        gen_auth = client.get_sdk_gen_authentication(token_storage=custom_storage)
 
         assert isinstance(gen_auth, BoxOAuth)
         assert gen_auth.config.token_storage is custom_storage
@@ -124,7 +124,7 @@ def test_get_authentication_jwt(self, mock_box_session):
         )
 
         client = Client(auth, session=mock_box_session)
-        gen_auth = client.get_authentication()
+        gen_auth = client.get_sdk_gen_authentication()
 
         assert isinstance(gen_auth, BoxJWTAuth)
         assert gen_auth.config.client_id == client_id
@@ -154,7 +154,7 @@ def test_get_authentication_jwt_missing_credentials(self, mock_box_session):
         client = Client(auth, session=mock_box_session)
 
         with pytest.raises(ValueError, match="JWT authentication requires"):
-            client.get_authentication()
+            client.get_sdk_gen_authentication()
 
     def test_get_authentication_ccg(self, mock_box_session):
         """Test converting CCGAuth to BoxCCGAuth."""
@@ -169,7 +169,7 @@ def test_get_authentication_ccg(self, mock_box_session):
         )
 
         client = Client(auth, session=mock_box_session)
-        gen_auth = client.get_authentication()
+        gen_auth = client.get_sdk_gen_authentication()
 
         assert isinstance(gen_auth, BoxCCGAuth)
         assert gen_auth.config.client_id == client_id
@@ -183,7 +183,7 @@ def test_get_authentication_ccg_missing_credentials(self, mock_box_session):
         client = Client(auth, session=mock_box_session)
 
         with pytest.raises(ValueError, match="CCG authentication requires"):
-            client.get_authentication()
+            client.get_sdk_gen_authentication()
 
     def test_get_authentication_unsupported_type(self, mock_box_session):
         """Test that unsupported auth type raises ValueError."""
@@ -194,18 +194,18 @@ def test_get_authentication_unsupported_type(self, mock_box_session):
         client = Client(mock_auth, session=mock_box_session)
 
         with pytest.raises(ValueError, match="Unsupported authentication type"):
-            client.get_authentication()
+            client.get_sdk_gen_authentication()
 
 
-class TestGetNetworkSession:
-    """Test cases for get_network_session() method."""
+class TestGetSdkGenNetworkSession:
+    """Test cases for get_sdk_gen_network_session() method."""
 
     def test_get_network_session_default(self, mock_box_session):
         """Test extracting network session with default settings."""
         auth = Mock(OAuth2)
         client = Client(auth, session=mock_box_session)
 
-        network_session = client.get_network_session()
+        network_session = client.get_sdk_gen_network_session()
 
         assert isinstance(network_session, NetworkSession)
         assert isinstance(network_session.base_urls, BaseUrls)
@@ -216,7 +216,7 @@ def test_get_network_session_with_custom_headers(self, mock_box_session):
         client = Client(auth, session=mock_box_session)
 
         additional_headers = {'X-Custom-Header': 'custom_value'}
-        network_session = client.get_network_session(
+        network_session = client.get_sdk_gen_network_session(
             additional_headers=additional_headers
         )
 
@@ -232,7 +232,7 @@ def test_get_network_session_with_proxy(self, mock_box_session):
         auth = Mock(OAuth2)
         client = Client(auth, session=mock_box_session)
 
-        network_session = client.get_network_session()
+        network_session = client.get_sdk_gen_network_session()
 
         # Proxy URL should be set
         assert network_session.proxy_url is not None
@@ -250,7 +250,7 @@ def test_get_network_session_with_authenticated_proxy(self, mock_box_session):
         auth = Mock(OAuth2)
         client = Client(auth, session=mock_box_session)
 
-        network_session = client.get_network_session()
+        network_session = client.get_sdk_gen_network_session()
 
         # Proxy URL should include authentication
         assert network_session.proxy_url is not None
@@ -269,7 +269,7 @@ def test_get_network_session_with_custom_retry_strategy(self, mock_box_session):
         client = Client(auth, session=mock_box_session)
 
         custom_retry = BoxRetryStrategy(max_attempts=10, retry_base_interval=2.0)
-        network_session = client.get_network_session(retry_strategy=custom_retry)
+        network_session = client.get_sdk_gen_network_session(retry_strategy=custom_retry)
 
         assert network_session.retry_strategy is custom_retry
         assert network_session.retry_strategy.max_attempts == 10
@@ -286,7 +286,7 @@ def test_get_network_session_base_urls(self, mock_box_session):
         auth = Mock(OAuth2)
         client = Client(auth, session=mock_box_session)
 
-        network_session = client.get_network_session()
+        network_session = client.get_sdk_gen_network_session()
 
         # URLs should have version suffix removed
         assert 'custom.api.box.com' in network_session.base_urls.base_url