From efe34a19e91c7634977ad9d6e46141bbd72f3bb8 Mon Sep 17 00:00:00 2001
From: Haonan Chen <chn@chn.moe>
Date: Sat, 25 Apr 2026 16:57:00 +0800
Subject: [PATCH] properly close pipe in parent

---
 include/boost/process/v2/stdio.hpp | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

diff --git a/include/boost/process/v2/stdio.hpp b/include/boost/process/v2/stdio.hpp
index 01d021613..882418644 100644
--- a/include/boost/process/v2/stdio.hpp
+++ b/include/boost/process/v2/stdio.hpp
@@ -173,10 +173,18 @@ struct process_io_binding
   bool fd_needs_closing{false};
   error_code ec;
 
-  ~process_io_binding()
+  void close()
   {
     if (fd_needs_closing)
+    {
       ::close(fd);
+      fd = target;
+      fd_needs_closing = false;
+    }
+  }
+  ~process_io_binding()
+  {
+    close();
   }
 
   process_io_binding() = default;
@@ -193,8 +201,7 @@ struct process_io_binding
 
   process_io_binding & operator=(process_io_binding && other) noexcept
   {
-    if (fd_needs_closing)
-      ::close(fd);
+    close();
 
     fd = other.fd;
     fd_needs_closing = other.fd_needs_closing;
@@ -358,6 +365,22 @@ struct process_stdio
 
     return error_code {};
   };
+
+  // weather fork succeeded or not, we should close the pipe properly in the parent
+  void close_pipes()
+  {
+    in.close();
+    out.close();
+    err.close();
+  };
+  void on_success(posix::default_launcher & /*launcher*/, const filesystem::path &, const char * const *)
+  {
+    close_pipes();
+  };
+  void on_error(posix::default_launcher & /*launcher*/, const filesystem::path &, const char * const *)
+  {
+    close_pipes();
+  };
 #endif
 
 };