bugfix: slow mb cutscenese with short fight option.#354
Open
nn357 wants to merge 1 commit into
Open
Conversation
The short option previously called the fast_mb_cutscenes patch (which isn't applied with slow mb cutscenes) so it causes the game to crash. I moved the standup part of that patch to it's own patch that is applied if the fight is set to short (like the hyper_slowlock is done for skip) There was a couple of other speedups i hadn't noticed which are now only applied if fast cutscenes are enabled. Tested the 3 fights (short/skip/vanilla) with / without fast cutscenes.
Contributor
|
Looks good, pretty straightforward on the ASM side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The short option called the fast_mb_cutscenes patch (which isn't applied with slow mb cutscenes) so it causes the game to crash.
Noticed it during my plando with the help of Loptr managed to find it was this setting.
I moved the standup part of that patch to it's own patch that is applied if the fight is set to short (like the hyper_slowlock is done for skip)
There was a couple of other speedups i hadn't noticed in the same function which are now only applied if fast cutscenes are enabled.
Tested the 3 fights (short/skip/vanilla) with / without fast cutscenes.
This is finished but i'll mark it as draft for now as I'm not sure if there's a better way of it being implemented