Map station reveal custom#353
Merged
Merged
Conversation
start moving mapstation activation reveal into QOL and add a gear button to allow map stations to do more than just partial / full.
details of setting to be added to seed page later.
still needs to match the actual maptiles, currently just set to return everything based on what the refill stations options is set to for testing how area transitions would work (perhaps they can also be added as a toggle?)
still something wrong with the bitmask generation map not being correct
also or the revealed tiles into partial tiles else scrolling doesnt work
hopefully this fixes my stupid rust_analyzer formatting
…rning about (unreleated)
also fixed the json of the kraid recharge station being wrong.
blkerby
reviewed
Jun 6, 2026
| sta $702000, x ; maptiles bitmask | ||
| lda $89b200, x | ||
| sta $702700, x | ||
| ora $702700, x ; don't clear any bits already marked explored as it can break scrolling with sub area reveal set to off. |
Owner
There was a problem hiding this comment.
I think we also want to do the same thing for the revealed bitmask (ora $702000, x). Otherwise activating the map could change revealed tiles back to only partially revealed. It might not result in a visible problem if the explored bits still take priority; still, explored + not revealed is a weird state that I wouldn't want to rely on working correctly.
Contributor
Author
There was a problem hiding this comment.
Sure yeah that makes sense. Will give it a try.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ok i've tested it some more and it seems to work ok now!
Might be worth testing it yourself before merging
I also didn't add any release notes yet.
fixed a bug with the kraid recharge station json too and a clippy warning about a collapisble if block in traverse.rs.