Skip to content

Commit b6cc275

Browse files
Tsvetan StoychevTsvetan Stoychev
authored andcommitted
Move script position to performance settings
1 parent c8fa932 commit b6cc275

4 files changed

Lines changed: 39 additions & 38 deletions

File tree

‎plugins/basicrum/languages/basicrum-bg_BG.po‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -144,23 +144,23 @@ msgstr ""
144144
msgid "Milliseconds to delay the beacon after onload. Leave 0 to disable the delay."
145145
msgstr ""
146146

147-
#: src/Admin/Settings/Page.php:253
147+
#: src/Admin/Settings/Page.php:269
148148
msgid "Developer Settings"
149149
msgstr ""
150150

151-
#: src/Admin/Settings/Page.php:272
151+
#: src/Admin/Settings/Page.php:246
152152
msgid "Script Position"
153153
msgstr ""
154154

155-
#: src/Admin/Settings/Page.php:278
155+
#: src/Admin/Settings/Page.php:252
156156
msgid "Where to insert the monitoring script."
157157
msgstr ""
158158

159-
#: src/Admin/Settings/Page.php:280
159+
#: src/Admin/Settings/Page.php:254
160160
msgid "Header (wp_head)"
161161
msgstr ""
162162

163-
#: src/Admin/Settings/Page.php:281
163+
#: src/Admin/Settings/Page.php:255
164164
msgid "Footer (wp_footer)"
165165
msgstr ""
166166

@@ -212,10 +212,10 @@ msgstr "Невалиден Brum Site ID. Копирайте го от админ
212212
msgid "Delay cannot exceed 30000 milliseconds. It has been capped at 30000."
213213
msgstr ""
214214

215-
#: src/Admin/Settings/Page.php:260
215+
#: src/Admin/Settings/Page.php:276
216216
msgid "Development Mode"
217217
msgstr ""
218218

219-
#: src/Admin/Settings/Page.php:266
219+
#: src/Admin/Settings/Page.php:282
220220
msgid "Allow HTTP beacon URLs for local testing. Do not enable this on production sites."
221221
msgstr ""

‎plugins/basicrum/languages/basicrum.pot‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -143,32 +143,32 @@ msgstr ""
143143
msgid "Milliseconds to delay the beacon after onload. Leave 0 to disable the delay."
144144
msgstr ""
145145

146-
#: src/Admin/Settings/Page.php:253
147-
msgid "Developer Settings"
146+
#: src/Admin/Settings/Page.php:246
147+
msgid "Script Position"
148148
msgstr ""
149149

150-
#: src/Admin/Settings/Page.php:260
151-
msgid "Development Mode"
150+
#: src/Admin/Settings/Page.php:252
151+
msgid "Where to insert the monitoring script."
152152
msgstr ""
153153

154-
#: src/Admin/Settings/Page.php:266
155-
msgid "Allow HTTP beacon URLs for local testing. Do not enable this on production sites."
154+
#: src/Admin/Settings/Page.php:254
155+
msgid "Header (wp_head)"
156156
msgstr ""
157157

158-
#: src/Admin/Settings/Page.php:272
159-
msgid "Script Position"
158+
#: src/Admin/Settings/Page.php:255
159+
msgid "Footer (wp_footer)"
160160
msgstr ""
161161

162-
#: src/Admin/Settings/Page.php:278
163-
msgid "Where to insert the monitoring script."
162+
#: src/Admin/Settings/Page.php:269
163+
msgid "Developer Settings"
164164
msgstr ""
165165

166-
#: src/Admin/Settings/Page.php:280
167-
msgid "Header (wp_head)"
166+
#: src/Admin/Settings/Page.php:276
167+
msgid "Development Mode"
168168
msgstr ""
169169

170-
#: src/Admin/Settings/Page.php:281
171-
msgid "Footer (wp_footer)"
170+
#: src/Admin/Settings/Page.php:282
171+
msgid "Allow HTTP beacon URLs for local testing. Do not enable this on production sites."
172172
msgstr ""
173173

174174
#: src/Admin/Settings/Page.php:288

‎plugins/basicrum/readme.txt‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ Yes. Enable Development Mode under Basicrum's Developer Settings to preserve HTT
7171

7272
1. Admin settings page - General settings with beacon URL and Brum Site ID.
7373
2. Privacy settings - Consent mode configuration with JS API documentation.
74-
3. Developer settings - Script position and debug options.
74+
3. Performance settings - Beacon timing and script position options.
75+
4. Developer settings - Development mode and loader debugging options.
7576

7677
== Changelog ==
7778

‎plugins/basicrum/src/Admin/Settings/Page.php‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,22 @@ private function add_performance_section() {
240240
'max' => 30000,
241241
)
242242
);
243+
244+
add_settings_field(
245+
'script_position',
246+
esc_html__( 'Script Position', 'basicrum' ),
247+
array( $this, 'render_radio_field' ),
248+
self::SLUG,
249+
'basicrum_section_performance',
250+
array(
251+
'id' => 'script_position',
252+
'label' => __( 'Where to insert the monitoring script.', 'basicrum' ),
253+
'options' => array(
254+
'header' => __( 'Header (wp_head)', 'basicrum' ),
255+
'footer' => __( 'Footer (wp_footer)', 'basicrum' ),
256+
),
257+
)
258+
);
243259
}
244260

245261
/**
@@ -267,22 +283,6 @@ private function add_developer_section() {
267283
)
268284
);
269285

270-
add_settings_field(
271-
'script_position',
272-
esc_html__( 'Script Position', 'basicrum' ),
273-
array( $this, 'render_radio_field' ),
274-
self::SLUG,
275-
'basicrum_section_developer',
276-
array(
277-
'id' => 'script_position',
278-
'label' => __( 'Where to insert the monitoring script.', 'basicrum' ),
279-
'options' => array(
280-
'header' => __( 'Header (wp_head)', 'basicrum' ),
281-
'footer' => __( 'Footer (wp_footer)', 'basicrum' ),
282-
),
283-
)
284-
);
285-
286286
add_settings_field(
287287
'use_unminified_loaders',
288288
esc_html__( 'Use Unminified Loaders', 'basicrum' ),

0 commit comments

Comments
 (0)