fix(admin): preserve wait dependency config path

Author: ceckoslab

.github/copilot-instructions.md

@@ -102,7 +102,7 @@ The block is added to the `before_body_end` reference in `basicrum_analytics.xml
    - `config.xml`: Module version, models, blocks, helpers, events.
    - `system.xml`: Backend configuration fields (ACL, Scope).
    - `adminhtml.xml`: Admin menu items and ACL resources.
-   - Keep Beacon Endpoint URL and BasicRUM Site ID visible while the module is disabled. Runtime-only privacy, wait, and developer fields use cross-group `system.xml` dependencies on `basicrum_analytics/general/enabled`; preserve those dependencies and Magento's scoped inheritance behavior.
+   - Keep Beacon Endpoint URL and BasicRUM Site ID visible while the module is disabled. Runtime-only privacy, wait, and developer fields use cross-group `system.xml` dependencies on `basicrum_analytics/general/enabled`; preserve those dependencies and Magento's scoped inheritance behavior. The wait toggle uses the unique admin field ID `wait_enabled` with `config_path` mapped to the established public path `basicrum_analytics/wait_after_onload/enabled`, avoiding duplicate dependency node names in Magento's merged XML.
 
 ## Important Patterns
 - **Helpers**: Always access helpers via `Mage::helper('basicrum_analytics')`.

app/code/community/BasicRum/Analytics/etc/system.xml

@@ -133,10 +133,11 @@
                     <show_in_website>1</show_in_website>
                     <show_in_store>1</show_in_store>
                     <fields>
-                        <enabled translate="label">
+                        <wait_enabled translate="label">
                             <label>Enable Wait After Onload</label>
                             <frontend_type>select</frontend_type>
                             <source_model>adminhtml/system_config_source_yesno</source_model>
+                            <config_path>basicrum_analytics/wait_after_onload/enabled</config_path>
                             <sort_order>1</sort_order>
                             <show_in_default>1</show_in_default>
                             <show_in_website>1</show_in_website>
@@ -147,7 +148,7 @@
                                     <value>1</value>
                                 </enabled>
                             </depends>
-                        </enabled>
+                        </wait_enabled>
                         <wait_ms translate="label">
                             <label>Wait After Onload (ms)</label>
                             <frontend_type>text</frontend_type>
@@ -162,7 +163,7 @@
                                     <fieldset>general</fieldset>
                                     <value>1</value>
                                 </enabled>
-                                <enabled>1</enabled>
+                                <wait_enabled>1</wait_enabled>
                             </depends>
                         </wait_ms>
                     </fields>

tests/php/run.php

@@ -231,13 +231,18 @@ function basicrum_config_dependency_map(SimpleXMLElement $field, $defaultFieldse
     );
     basicrum_assert_same(
         $generalEnabledOnly,
-        basicrum_config_dependency_map($waitFields->enabled, 'wait_after_onload'),
+        basicrum_config_dependency_map($waitFields->wait_enabled, 'wait_after_onload'),
         'wait control must depend on monitoring being enabled'
     );
+    basicrum_assert_same(
+        'basicrum_analytics/wait_after_onload/enabled',
+        (string) $waitFields->wait_enabled->config_path,
+        'wait control must retain the established public configuration path'
+    );
     basicrum_assert_same(
         array(
             'general/enabled' => '1',
-            'wait_after_onload/enabled' => '1',
+            'wait_after_onload/wait_enabled' => '1',
         ),
         basicrum_config_dependency_map($waitFields->wait_ms, 'wait_after_onload'),
         'wait duration must require both enabled monitoring and enabled waiting'

tests/platform/verify.php

@@ -117,13 +117,18 @@
 );
 basicrum_platform_assert_same(
     $generalEnabledOnly,
-    basicrum_platform_dependency_map($waitFields->enabled, 'wait_after_onload'),
+    basicrum_platform_dependency_map($waitFields->wait_enabled, 'wait_after_onload'),
     'wait control does not depend on enabled monitoring'
 );
+basicrum_platform_assert_same(
+    'basicrum_analytics/wait_after_onload/enabled',
+    (string) $waitFields->wait_enabled->config_path,
+    'wait control did not retain its established public configuration path'
+);
 basicrum_platform_assert_same(
     array(
         'general/enabled' => '1',
-        'wait_after_onload/enabled' => '1',
+        'wait_after_onload/wait_enabled' => '1',
     ),
     basicrum_platform_dependency_map($waitFields->wait_ms, 'wait_after_onload'),
     'wait duration dependencies were not preserved by the native config parser'