Skip to content

Commit 48e30ea

Browse files
committed
Fix verification violations
1 parent ee790e7 commit 48e30ea

50 files changed

Lines changed: 3546 additions & 126 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Makefile‎

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ BATCH_SIZE ?= 25
1010
.PHONY: docs docs-serve docs-clean docs-install docs-lock venv gen clients fragments publish-codegen aio-check meta-package-check static-analysis test-unit test-functional test-integration \
1111
check-imports check-conventions check-api check-dependencies check-packaging check-import-stability verify-venv api-snapshot \
1212
canonical-imports dunder-all source-order dynamic-imports banned-imports docstrings declared-deps import-cycles \
13-
dep-specifiers package-metadata version-consistency export-names exception-hierarchy secret-repr import-hygiene \
13+
dep-specifiers package-metadata package-metadata-fix version-consistency export-names exception-hierarchy secret-repr import-hygiene \
1414
import-deprecations import-side-effects import-cost wheel-contents type-completeness optional-deps lowest-bounds
1515

1616
# Each client and package runs in its own .venv. Dependencies outside this repo,
@@ -20,6 +20,13 @@ RUFF_VERSION := 0.15.22
2020
PYRIGHT_VERSION := 1.1.406
2121
UV_RUN = uv run --python $(PYTHON_VERSION) --project
2222

23+
# The verifications import, build and inspect every client and package together,
24+
# so they share one venv holding all of them editable, plus the pinned tools.
25+
# CAUTION: defined before any rule, since make expands prerequisites as it reads each rule.
26+
VERIFY_VENV := .venv-verify
27+
VERIFY_STAMP := $(VERIFY_VENV)/.installed
28+
VERIFY = $(VERIFY_VENV)/bin/python scripts/verifications
29+
2330
# Q Business is sunsetting; new application creation is unavailable.
2431
INTEGRATION_SKIP := clients/aws-sdk-qbusiness
2532

@@ -33,8 +40,7 @@ static-analysis:
3340
uvx ruff@$(RUFF_VERSION) format --check --config $$p/pyproject.toml $$dirs; \
3441
$(UV_RUN) $$p $$group --with pyright==$(PYRIGHT_VERSION) pyright -p $$p $$dirs; \
3542
done
36-
# TODO: enable once smithy-python codegen passes the aio naming rules.
37-
# $(MAKE) aio-check
43+
$(MAKE) aio-check
3844
$(MAKE) check-imports
3945
$(MAKE) check-conventions
4046
$(MAKE) check-api
@@ -105,45 +111,39 @@ meta-package-check:
105111

106112
check-imports: ## Keeps the import graph explicit, acyclic, and free of test-only modules.
107113
$(MAKE) canonical-imports
108-
# $(MAKE) import-cycles # TODO: enable once it passes
109-
# $(MAKE) dynamic-imports # TODO: enable once it passes
114+
$(MAKE) import-cycles
115+
$(MAKE) dynamic-imports
110116
$(MAKE) banned-imports
111117

112118
check-conventions: ## Holds shipped code to our ordering, docstring, error, and secret-handling conventions.
113-
# $(MAKE) source-order # TODO: enable once it passes
114-
# $(MAKE) docstrings # TODO: enable once it passes
119+
$(MAKE) source-order
120+
$(MAKE) docstrings
115121
$(MAKE) exception-hierarchy
116-
# $(MAKE) secret-repr # TODO: enable once it passes
122+
$(MAKE) secret-repr
117123

118124
check-api: ## Keeps the public API surface reviewed, typed, and exported under its own names.
119125
$(MAKE) api-snapshot
120126
$(MAKE) export-names
121127
$(MAKE) dunder-all
122-
# $(MAKE) type-completeness # TODO: enable once it passes
128+
$(MAKE) type-completeness
123129

124130
check-dependencies: ## Keeps declared dependencies honest for customers who install only some packages.
125-
# $(MAKE) declared-deps # TODO: enable once it passes
131+
$(MAKE) declared-deps
126132
$(MAKE) dep-specifiers
127133
$(MAKE) optional-deps
128134
$(MAKE) lowest-bounds
129135

130136
check-packaging: ## Keeps what we publish to PyPI consistent across packages.
131-
# $(MAKE) package-metadata # TODO: enable once it passes
132-
# $(MAKE) version-consistency # TODO: enable once it passes
133-
# $(MAKE) wheel-contents # TODO: enable once it passes
137+
$(MAKE) package-metadata
138+
$(MAKE) version-consistency
139+
$(MAKE) wheel-contents
134140

135141
check-import-stability: ## Keeps importing our packages cheap and free of side effects.
136142
$(MAKE) import-hygiene
137143
$(MAKE) import-deprecations
138144
$(MAKE) import-side-effects
139145
$(MAKE) import-cost
140146

141-
# The verifications import, build and inspect every client and package together,
142-
# so they share one venv holding all of them editable, plus the pinned tools.
143-
VERIFY_VENV := .venv-verify
144-
VERIFY_STAMP := $(VERIFY_VENV)/.installed
145-
VERIFY = $(VERIFY_VENV)/bin/python scripts/verifications
146-
147147
$(VERIFY_STAMP): $(addsuffix /pyproject.toml,$(PROJECTS))
148148
uv venv --allow-existing --quiet --python $(PYTHON_VERSION) $(VERIFY_VENV)
149149
uv pip install --quiet --python $(VERIFY_VENV)/bin/python --all-extras \
@@ -186,6 +186,9 @@ dep-specifiers: $(VERIFY_STAMP) ## Keeps packages co-installable and in-repo ver
186186
package-metadata: $(VERIFY_STAMP) ## Catches pyproject.toml drift between packages.
187187
$(VERIFY)/package_metadata.py
188188

189+
package-metadata-fix: $(VERIFY_STAMP) ## Repairs canonical classifiers and LICENSE files that package-metadata flags.
190+
$(VERIFY)/package_metadata.py --fix
191+
189192
version-consistency: $(VERIFY_STAMP) ## Keeps __version__ truthful for user agents and bug reports.
190193
$(VERIFY)/version_consistency.py
191194

‎clients/aws-sdk-acm/LICENSE‎

Lines changed: 175 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,175 @@
1+
2+
Apache License
3+
Version 2.0, January 2004
4+
http://www.apache.org/licenses/
5+
6+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
7+
8+
1. Definitions.
9+
10+
"License" shall mean the terms and conditions for use, reproduction,
11+
and distribution as defined by Sections 1 through 9 of this document.
12+
13+
"Licensor" shall mean the copyright owner or entity authorized by
14+
the copyright owner that is granting the License.
15+
16+
"Legal Entity" shall mean the union of the acting entity and all
17+
other entities that control, are controlled by, or are under common
18+
control with that entity. For the purposes of this definition,
19+
"control" means (i) the power, direct or indirect, to cause the
20+
direction or management of such entity, whether by contract or
21+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
22+
outstanding shares, or (iii) beneficial ownership of such entity.
23+
24+
"You" (or "Your") shall mean an individual or Legal Entity
25+
exercising permissions granted by this License.
26+
27+
"Source" form shall mean the preferred form for making modifications,
28+
including but not limited to software source code, documentation
29+
source, and configuration files.
30+
31+
"Object" form shall mean any form resulting from mechanical
32+
transformation or translation of a Source form, including but
33+
not limited to compiled object code, generated documentation,
34+
and conversions to other media types.
35+
36+
"Work" shall mean the work of authorship, whether in Source or
37+
Object form, made available under the License, as indicated by a
38+
copyright notice that is included in or attached to the work
39+
(an example is provided in the Appendix below).
40+
41+
"Derivative Works" shall mean any work, whether in Source or Object
42+
form, that is based on (or derived from) the Work and for which the
43+
editorial revisions, annotations, elaborations, or other modifications
44+
represent, as a whole, an original work of authorship. For the purposes
45+
of this License, Derivative Works shall not include works that remain
46+
separable from, or merely link (or bind by name) to the interfaces of,
47+
the Work and Derivative Works thereof.
48+
49+
"Contribution" shall mean any work of authorship, including
50+
the original version of the Work and any modifications or additions
51+
to that Work or Derivative Works thereof, that is intentionally
52+
submitted to Licensor for inclusion in the Work by the copyright owner
53+
or by an individual or Legal Entity authorized to submit on behalf of
54+
the copyright owner. For the purposes of this definition, "submitted"
55+
means any form of electronic, verbal, or written communication sent
56+
to the Licensor or its representatives, including but not limited to
57+
communication on electronic mailing lists, source code control systems,
58+
and issue tracking systems that are managed by, or on behalf of, the
59+
Licensor for the purpose of discussing and improving the Work, but
60+
excluding communication that is conspicuously marked or otherwise
61+
designated in writing by the copyright owner as "Not a Contribution."
62+
63+
"Contributor" shall mean Licensor and any individual or Legal Entity
64+
on behalf of whom a Contribution has been received by Licensor and
65+
subsequently incorporated within the Work.
66+
67+
2. Grant of Copyright License. Subject to the terms and conditions of
68+
this License, each Contributor hereby grants to You a perpetual,
69+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
70+
copyright license to reproduce, prepare Derivative Works of,
71+
publicly display, publicly perform, sublicense, and distribute the
72+
Work and such Derivative Works in Source or Object form.
73+
74+
3. Grant of Patent License. Subject to the terms and conditions of
75+
this License, each Contributor hereby grants to You a perpetual,
76+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
77+
(except as stated in this section) patent license to make, have made,
78+
use, offer to sell, sell, import, and otherwise transfer the Work,
79+
where such license applies only to those patent claims licensable
80+
by such Contributor that are necessarily infringed by their
81+
Contribution(s) alone or by combination of their Contribution(s)
82+
with the Work to which such Contribution(s) was submitted. If You
83+
institute patent litigation against any entity (including a
84+
cross-claim or counterclaim in a lawsuit) alleging that the Work
85+
or a Contribution incorporated within the Work constitutes direct
86+
or contributory patent infringement, then any patent licenses
87+
granted to You under this License for that Work shall terminate
88+
as of the date such litigation is filed.
89+
90+
4. Redistribution. You may reproduce and distribute copies of the
91+
Work or Derivative Works thereof in any medium, with or without
92+
modifications, and in Source or Object form, provided that You
93+
meet the following conditions:
94+
95+
(a) You must give any other recipients of the Work or
96+
Derivative Works a copy of this License; and
97+
98+
(b) You must cause any modified files to carry prominent notices
99+
stating that You changed the files; and
100+
101+
(c) You must retain, in the Source form of any Derivative Works
102+
that You distribute, all copyright, patent, trademark, and
103+
attribution notices from the Source form of the Work,
104+
excluding those notices that do not pertain to any part of
105+
the Derivative Works; and
106+
107+
(d) If the Work includes a "NOTICE" text file as part of its
108+
distribution, then any Derivative Works that You distribute must
109+
include a readable copy of the attribution notices contained
110+
within such NOTICE file, excluding those notices that do not
111+
pertain to any part of the Derivative Works, in at least one
112+
of the following places: within a NOTICE text file distributed
113+
as part of the Derivative Works; within the Source form or
114+
documentation, if provided along with the Derivative Works; or,
115+
within a display generated by the Derivative Works, if and
116+
wherever such third-party notices normally appear. The contents
117+
of the NOTICE file are for informational purposes only and
118+
do not modify the License. You may add Your own attribution
119+
notices within Derivative Works that You distribute, alongside
120+
or as an addendum to the NOTICE text from the Work, provided
121+
that such additional attribution notices cannot be construed
122+
as modifying the License.
123+
124+
You may add Your own copyright statement to Your modifications and
125+
may provide additional or different license terms and conditions
126+
for use, reproduction, or distribution of Your modifications, or
127+
for any such Derivative Works as a whole, provided Your use,
128+
reproduction, and distribution of the Work otherwise complies with
129+
the conditions stated in this License.
130+
131+
5. Submission of Contributions. Unless You explicitly state otherwise,
132+
any Contribution intentionally submitted for inclusion in the Work
133+
by You to the Licensor shall be under the terms and conditions of
134+
this License, without any additional terms or conditions.
135+
Notwithstanding the above, nothing herein shall supersede or modify
136+
the terms of any separate license agreement you may have executed
137+
with Licensor regarding such Contributions.
138+
139+
6. Trademarks. This License does not grant permission to use the trade
140+
names, trademarks, service marks, or product names of the Licensor,
141+
except as required for reasonable and customary use in describing the
142+
origin of the Work and reproducing the content of the NOTICE file.
143+
144+
7. Disclaimer of Warranty. Unless required by applicable law or
145+
agreed to in writing, Licensor provides the Work (and each
146+
Contributor provides its Contributions) on an "AS IS" BASIS,
147+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
148+
implied, including, without limitation, any warranties or conditions
149+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
150+
PARTICULAR PURPOSE. You are solely responsible for determining the
151+
appropriateness of using or redistributing the Work and assume any
152+
risks associated with Your exercise of permissions under this License.
153+
154+
8. Limitation of Liability. In no event and under no legal theory,
155+
whether in tort (including negligence), contract, or otherwise,
156+
unless required by applicable law (such as deliberate and grossly
157+
negligent acts) or agreed to in writing, shall any Contributor be
158+
liable to You for damages, including any direct, indirect, special,
159+
incidental, or consequential damages of any character arising as a
160+
result of this License or out of the use or inability to use the
161+
Work (including but not limited to damages for loss of goodwill,
162+
work stoppage, computer failure or malfunction, or any and all
163+
other commercial damages or losses), even if such Contributor
164+
has been advised of the possibility of such damages.
165+
166+
9. Accepting Warranty or Additional Liability. While redistributing
167+
the Work or Derivative Works thereof, You may choose to offer,
168+
and charge a fee for, acceptance of support, warranty, indemnity,
169+
or other liability obligations and/or rights consistent with this
170+
License. However, in accepting such obligations, You may act only
171+
on Your own behalf and on Your sole responsibility, not on behalf
172+
of any other Contributor, and only if You agree to indemnify,
173+
defend, and hold each Contributor harmless for any liability
174+
incurred by, or claims asserted against, such Contributor by reason
175+
of your accepting any such warranty or additional liability.

0 commit comments

Comments
 (0)