fix(anthropic): send temperature via extra_body so it works when set

The previous fix stopped forwarding `temperature` when unset, but forwarding it
when a value *was* set still crashed on anthropic clients that removed the typed
parameter (e.g. 1.2.0) - which affects BOTH AnthropicVlmProvider and
AskUIVlmProvider, since both route Claude through this AnthropicMessagesApi.

The Messages API still accepts `temperature` in the request body, so send it via
`extra_body` (only when set) instead of as a typed keyword. Verified against the
real anthropic 1.2.0 client: `extra_body={"temperature": x}` binds cleanly while
`temperature=x` raises TypeError.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: philipph-askui

src/askui/models/anthropic/messages_api.py

@@ -269,18 +269,17 @@ def create_message(
             temperature,
         )
 
-        # Only forward `temperature` when a value was actually requested. It is
-        # an optional sampling parameter that some `anthropic` client versions do
-        # not expose on `beta.messages.create` (and the client does not accept
-        # `**kwargs`), so passing it unconditionally - even as the `omit`
-        # sentinel - raises `TypeError` at argument binding on those clients.
-        # The other options remain passed as `omit`; they are still part of the
-        # client signature.
-        temperature_kwarg: dict[str, float] = {}
+        # `temperature` was removed from the typed `beta.messages.create`
+        # signature in newer `anthropic` clients (e.g. 1.2.0), which accept no
+        # `**kwargs` - so forwarding it as a normal keyword raises `TypeError` at
+        # argument binding. The Messages API itself still accepts `temperature`
+        # in the request body, so send it via `extra_body` (only when a value was
+        # actually requested). This works regardless of client version.
+        extra_body: dict[str, Any] = {}
         if not isinstance(_temperature, Omit):
-            temperature_kwarg["temperature"] = _temperature
+            extra_body["temperature"] = _temperature
 
-        response = self._client.beta.messages.create(  # type: ignore[misc, call-overload]
+        response = self._client.beta.messages.create(  # type: ignore[misc]
             messages=_messages,
             max_tokens=max_tokens or 8192,
             cache_control=_cache_control,
@@ -292,6 +291,6 @@ def create_message(
             output_config=_output_config,
             tool_choice=_tool_choice,
             timeout=300.0,
-            **temperature_kwarg,
+            extra_body=extra_body or omit,
         )
         return MessageParam.model_validate(response.model_dump())

tests/unit/models/anthropic/test_messages_api.py

@@ -85,7 +85,7 @@ def test_no_output_config_omits_it(self) -> None:
         assert kwargs["output_config"] is omit
         assert kwargs["thinking"] == {"type": "enabled", "budget_tokens": 2048}
 
-    def test_temperature_not_forwarded_when_unset(self) -> None:
+    def test_temperature_not_in_body_when_unset(self) -> None:
         api, client = self._make_api()
 
         api.create_message(
@@ -94,11 +94,11 @@ def test_temperature_not_forwarded_when_unset(self) -> None:
         )
 
         kwargs = client.beta.messages.create.call_args.kwargs
-        # Not passed at all (not even as `omit`) so clients that dropped the
-        # parameter do not raise TypeError.
+        # Never sent as a typed keyword, and no temperature in the body.
         assert "temperature" not in kwargs
+        assert kwargs["extra_body"] is omit
 
-    def test_temperature_forwarded_when_set(self) -> None:
+    def test_temperature_sent_via_extra_body_when_set(self) -> None:
         api, client = self._make_api()
 
         api.create_message(
@@ -108,13 +108,27 @@ def test_temperature_forwarded_when_set(self) -> None:
         )
 
         kwargs = client.beta.messages.create.call_args.kwargs
-        assert kwargs["temperature"] == 0.3
+        # Routed through the request body (not the typed `temperature=` kwarg,
+        # which newer clients removed).
+        assert "temperature" not in kwargs
+        assert kwargs["extra_body"] == {"temperature": 0.3}
+
+    def test_temperature_zero_sent_via_extra_body(self) -> None:
+        api, client = self._make_api()
+
+        api.create_message(
+            messages=[MessageParam(role="user", content="hi")],
+            model_id="claude-sonnet-5",
+            temperature=0.0,
+        )
 
-    def test_succeeds_on_client_that_rejects_temperature(self) -> None:
-        """Regression: mirrors an anthropic client whose create() has no
-        `temperature` parameter (and no **kwargs). Passing `temperature` at all -
-        even as the `omit` sentinel - would raise TypeError, so the SDK must not
-        forward it when it is unset."""
+        kwargs = client.beta.messages.create.call_args.kwargs
+        assert kwargs["extra_body"] == {"temperature": 0.0}
+
+    def test_succeeds_on_client_that_rejects_temperature_kwarg(self) -> None:
+        """Regression: a client whose create() has no `temperature` parameter
+        (and no **kwargs) must not receive it as a keyword - even when a
+        temperature is requested. It goes into the request body instead."""
 
         def create(**kwargs: object) -> MagicMock:
             if "temperature" in kwargs:
@@ -131,16 +145,16 @@ def create(**kwargs: object) -> MagicMock:
         result = api.create_message(
             messages=[MessageParam(role="user", content="hi")],
             model_id="claude-sonnet-5",
+            temperature=0.5,  # even when set, must not become a kwarg
         )
         assert isinstance(result, MessageParam)
 
     def test_kwargs_accepted_by_real_client_signature(self) -> None:
-        """Integration guard: every kwarg the SDK sends must be accepted by the
-        REAL installed `anthropic` client's `beta.messages.create` signature.
-
-        This binds against the real signature (no network), so it fails if the
-        SDK forwards a parameter the installed client version does not support -
-        catching this class of breakage on whatever anthropic CI resolves."""
+        """Integration guard: every kwarg the SDK sends - with and without a
+        temperature - must be accepted by the REAL installed `anthropic` client's
+        `beta.messages.create` signature (bound with no network). This catches
+        the SDK forwarding a parameter the installed client version does not
+        support, on whatever anthropic CI resolves."""
         real_client = anthropic.Anthropic(api_key="dummy")
         real_signature = inspect.signature(real_client.beta.messages.create)
 
@@ -154,8 +168,10 @@ def spy(**kwargs: Any) -> MagicMock:
         real_client.beta.messages.create = spy  # type: ignore[method-assign]
         api = AnthropicMessagesApi(client=real_client)
 
-        result = api.create_message(
-            messages=[MessageParam(role="user", content="hi")],
-            model_id="claude-sonnet-5",
-        )
-        assert isinstance(result, MessageParam)
+        for temperature in (None, 0.0, 0.7):
+            result = api.create_message(
+                messages=[MessageParam(role="user", content="hi")],
+                model_id="claude-sonnet-5",
+                temperature=temperature,
+            )
+            assert isinstance(result, MessageParam)