From 2aa63cc8aff8e51ef99529ef444b3300e14b5517 Mon Sep 17 00:00:00 2001 From: Gerd Aschemann Date: Mon, 8 Jun 2026 01:03:17 +0200 Subject: [PATCH] Fix effective-pom_properties IT for Maven 4 compatibility The effective-pom_properties IT's verify.groovy was updated in PR #344 (merged 2025-10-31) to assert that user properties override pom properties on Maven 4, expecting maven.compiler.source/target=8 in the rendered effective POM. However the change updated only verify.groovy. The corresponding invoker.properties was never extended to actually pass the user properties into the invoked Maven build, so the assertion fired unconditionally on Maven 4 (the rendered effective POM legitimately showed the pom-property values 1.6/1.6). Add invoker.systemProperties.maven.compiler.source/target=8 so the IT exercises the assertion path it was rewritten for. No production code change; only the IT fixture. This unblocks PR #363 (enable Maven 4 CI matrix). Co-Authored-By: Claude Opus 4.7 (1M context) --- src/it/projects/effective-pom_properties/invoker.properties | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/it/projects/effective-pom_properties/invoker.properties b/src/it/projects/effective-pom_properties/invoker.properties index 954ed85f..c41141a2 100644 --- a/src/it/projects/effective-pom_properties/invoker.properties +++ b/src/it/projects/effective-pom_properties/invoker.properties @@ -16,3 +16,9 @@ # under the License. invoker.goals = ${project.groupId}:${project.artifactId}:${project.version}:effective-pom + +# verify.groovy asserts that user properties override pom properties on Maven 4, +# expecting maven.compiler.source/target = 8 in the rendered effective POM. +# Pass them as -D user properties so the override actually happens. +invoker.systemProperties.maven.compiler.source = 8 +invoker.systemProperties.maven.compiler.target = 8