Adapt V3 manifest writers to the V3 manifest list schema now on main

Author: moomindani

pyiceberg/manifest.py

@@ -1399,7 +1399,8 @@ def to_manifest_file(self) -> ManifestFile:
             field.name: value
             for field, value in zip(MANIFEST_LIST_FILE_SCHEMAS[DEFAULT_READ_VERSION].fields, manifest_file._data, strict=True)
         }
-        return ManifestFile.from_args(_table_format_version=3, first_row_id=self._first_row_id, **args)
+        args["first_row_id"] = self._first_row_id
+        return ManifestFile.from_args(_table_format_version=3, **args)
 
     def new_writer(self) -> AvroOutputFile[ManifestEntry]:
         # Use the V3 record layout so the V3-only data file fields are written

tests/avro/test_file.py

@@ -264,9 +264,11 @@ def test_todict_manifest_file_v2_layout_matches_fastavro() -> None:
     """todict must exclude ManifestFile's V3-only first_row_id for a record bound to the V2 layout,
 
     the same way it does for DataFile, otherwise the exclusion added for DataFile would be
-    inconsistent for other record types with version-dependent trailing fields.
+    inconsistent for other record types with version-dependent trailing fields. The binding is
+    explicit because the default read version is V3, whose layout does carry first_row_id.
     """
     manifest_file = ManifestFile.from_args(
+        _table_format_version=2,
         manifest_path="/manifests/m1.avro",
         manifest_length=100,
         partition_spec_id=0,