From 79decaddc33e4ef7c6800b28deb8fed7a79f80be Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Tue, 1 Sep 2026 17:27:16 +0000 Subject: [PATCH] test: enable native path in lower/upper_enabled sql fixtures Point the _enabled fixtures at spark.comet.caseConversion.enabled so they exercise the native case-conversion path instead of the no-op allowIncompatible setting. Fixes #5611 Co-authored-by: Cestercian --- .../resources/sql-tests/expressions/string/lower_enabled.sql | 5 +++-- .../resources/sql-tests/expressions/string/upper_enabled.sql | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/spark/src/test/resources/sql-tests/expressions/string/lower_enabled.sql b/spark/src/test/resources/sql-tests/expressions/string/lower_enabled.sql index 10c188b4415..637ee48f160 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/lower_enabled.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/lower_enabled.sql @@ -15,8 +15,9 @@ -- specific language governing permissions and limitations -- under the License. --- Test lower() with the standard allowIncompatible opt-in (happy path) --- Config: spark.comet.expression.Lower.allowIncompatible=true +-- Covers the native case-conversion path for lower(), not the codegen +-- dispatcher used by lower.sql. ASCII inputs only. +-- Config: spark.comet.caseConversion.enabled=true statement CREATE TABLE test_lower_enabled(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/upper_enabled.sql b/spark/src/test/resources/sql-tests/expressions/string/upper_enabled.sql index e1035ab37fa..610fc26d4ad 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/upper_enabled.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/upper_enabled.sql @@ -15,8 +15,9 @@ -- specific language governing permissions and limitations -- under the License. --- Test upper() with the standard allowIncompatible opt-in (happy path) --- Config: spark.comet.expression.Upper.allowIncompatible=true +-- Covers the native case-conversion path for upper(), not the codegen +-- dispatcher used by upper.sql. ASCII inputs only. +-- Config: spark.comet.caseConversion.enabled=true statement CREATE TABLE test_upper_enabled(s string) USING parquet