From 8e3006c56a5483d27709cbcec49424080fc3f5b9 Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Sat, 24 Oct 2026 21:12:29 -0500 Subject: [PATCH] fix(src): Read empty array test offsets at their native width --- src/nanoarrow/common/array_test.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/nanoarrow/common/array_test.cc b/src/nanoarrow/common/array_test.cc index 9324cdde6..31f442708 100644 --- a/src/nanoarrow/common/array_test.cc +++ b/src/nanoarrow/common/array_test.cc @@ -427,12 +427,15 @@ TEST(ArrayTest, ArrayTestFinishBuildingEmptyArrayOffsets) { << error.message; ASSERT_NE(array->buffers[1], nullptr); EXPECT_EQ(ArrowArrayBuffer(array.get(), 1)->size_bytes, test_case.offset_size); - int64_t first_offset = -1; - memcpy(&first_offset, array->buffers[1], test_case.offset_size); if (test_case.offset_size == 4) { - first_offset = static_cast(first_offset); + int32_t first_offset = -1; + memcpy(&first_offset, array->buffers[1], sizeof(first_offset)); + EXPECT_EQ(first_offset, 0); + } else { + int64_t first_offset = -1; + memcpy(&first_offset, array->buffers[1], sizeof(first_offset)); + EXPECT_EQ(first_offset, 0); } - EXPECT_EQ(first_offset, 0); } }