From 723038075ad3e14a1172314c0854f8fd2f5968d2 Mon Sep 17 00:00:00 2001 From: Tan Siewert Date: Wed, 19 Aug 2026 13:08:36 +0200 Subject: [PATCH] probe: remove obsolete bridge name With the migration to argp and a generic connection struct the bridge name argument became obsolete, but wasn't removed. Unfortunately, the passed argument "interface" is not the bridge name, but e.g. the UART device-path, which in the end meant that any driver that didn't match the path was skipped. Remove the argument as it isn't properly used anymore after the migration. Fixes: a120c4f ("cmd: probe: rework to argp and common connection struct") Signed-off-by: Tan Siewert --- src/cmd/probe.c | 4 +--- src/soc.c | 7 +------ src/soc.h | 3 +-- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/cmd/probe.c b/src/cmd/probe.c index 42c2a10..31c4978 100644 --- a/src/cmd/probe.c +++ b/src/cmd/probe.c @@ -121,9 +121,7 @@ static int do_probe(int argc, char **argv) soc_list_bridge_controllers(soc); rc = EXIT_SUCCESS; } else { - if ((rc = soc_probe_bridge_controllers( - soc, &discovered, - arguments.connection.interface)) < 0) { + if ((rc = soc_probe_bridge_controllers(soc, &discovered)) < 0) { loge("Failed to probe SoC bridge controllers: %d\n", rc); rc = EXIT_FAILURE; diff --git a/src/soc.c b/src/soc.c index be25a64..24880b5 100644 --- a/src/soc.c +++ b/src/soc.c @@ -638,8 +638,7 @@ void soc_list_bridge_controllers(struct soc *ctx) } } -int soc_probe_bridge_controllers(struct soc *ctx, enum bridge_mode *discovered, - const char *name) +int soc_probe_bridge_controllers(struct soc *ctx, enum bridge_mode *discovered) { enum bridge_mode current, aggregate; struct bridgectl *bridge; @@ -652,10 +651,6 @@ int soc_probe_bridge_controllers(struct soc *ctx, enum bridge_mode *discovered, list_for_each(&ctx->bridges, bridge, entry) { int rc; - if (name && strcmp(name, bridgectl_name(bridge))) { - continue; - } - /* Write the report to stdout */ if ((rc = bridgectl_report(bridge, 1, ¤t)) < 0) { loge("Failed to generate %s report: %d\n", diff --git a/src/soc.h b/src/soc.h index e7fa172..6b1841c 100644 --- a/src/soc.h +++ b/src/soc.h @@ -167,6 +167,5 @@ void soc_bridge_controller_unregister(struct soc *soc, struct bridgectl *bridge); void soc_list_bridge_controllers(struct soc *soc); -int soc_probe_bridge_controllers(struct soc *soc, enum bridge_mode *discovered, - const char *name); +int soc_probe_bridge_controllers(struct soc *soc, enum bridge_mode *discovered); #endif